org.codenarc.rule.concurrency.StaticMatcherFieldRule.groovy Maven / Gradle / Ivy
Go to download
Show more of this group Show more artifacts with this name
Show all versions of CodeNarc Show documentation
Show all versions of CodeNarc Show documentation
The CodeNarc project provides a static analysis tool for Groovy code.
/*
* Copyright 2009 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.codenarc.rule.concurrency
import org.codehaus.groovy.ast.FieldNode
import org.codenarc.rule.AbstractAstVisitorRule
import org.codenarc.rule.AbstractFieldVisitor
import org.codenarc.util.AstUtil
import java.lang.reflect.Modifier
import java.util.regex.Matcher
/**
* Matcher objects should not be used as static fields. Calendars are inherently unsafe for multithreaded use. Sharing a
* single instance across thread boundaries without proper synchronization will result in erratic behavior of the application.
*
* @author Hamlet D'Arcy
*/
class StaticMatcherFieldRule extends AbstractAstVisitorRule {
String name = 'StaticMatcherField'
int priority = 2
Class astVisitorClass = StaticMatcherFieldAstVisitor
}
class StaticMatcherFieldAstVisitor extends AbstractFieldVisitor {
@Override
void visitField(FieldNode node) {
if (Modifier.isStatic(node.modifiers) && AstUtil.classNodeImplementsType(node.type, Matcher)) {
addViolation(node, "Matcher instances are not thread safe. Wrap the Matcher field $node.name in a ThreadLocal or make it an instance field")
}
}
}