org.sonar.l10n.delphi.rules.community-delphi.InlineDeclarationCapturedByAnonymousMethod.html Maven / Gradle / Ivy

Go to download

Show more of this group Show more artifacts with this name
Show all versions of delphi-checks Show documentation

There is a newer version: 1.12.1

Why is this an issue?

  Up until Delphi 10.4.2, there are compiler bugs related to inline variables captured by anonymous
  methods:


  
    Inline variables will not have their lifetimes extended until the anonymous method goes out of
    scope. (Fixed in 10.4.1)
  
  
    Inline variables with managed types will not have their reference count updated when the
    anonymous method goes out of scope, causing memory leaks. (Fixed in 10.4.2)
  

How to fix it
Use a traditional variable declaration instead of an an inline declaration:
procedure Example;
begin
  var MyObj := TFoo.Create as IFoo;

  TTask.Run(
    procedure begin
      Sleep(1000);
      MyObj.Bar;
    end
  );
end;

procedure Example;
var
  MyObj: IFoo;
begin
  MyObj := TFoo.Create;

  TTask.Run(
    procedure begin
      Sleep(1000);
      MyObj.Bar;
    end
  );
end;

Resources

  
    
      Embarcadero Quality Portal: Inline variables don't work with anonymous methods
    
  
  
    
      Embarcadero Quality Portal: Memory leak: inline Interfaces captured by anonymous methods are not released
    
  
  
    
      Embarcadero Quality Portal: inline var reference counitng problem when captured in anonymous method