All Downloads are FREE. Search and download functionalities are using the official Maven repository.

io.trino.plugin.hive.metastore.SemiTransactionalHiveMetastore Maven / Gradle / Ivy

Go to download

This is a Databricks build of Trino's Hive plugin which includes support for HTTP based transport for it's Hive metastore thrift interface.

The newest version!
/*
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package io.trino.plugin.hive.metastore;

import com.google.common.annotations.VisibleForTesting;
import com.google.common.base.CharMatcher;
import com.google.common.base.Joiner;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.ImmutableSet;
import com.google.common.collect.Iterables;
import com.google.common.collect.Lists;
import com.google.errorprone.annotations.FormatMethod;
import io.airlift.log.Logger;
import io.airlift.units.Duration;
import io.trino.hdfs.HdfsContext;
import io.trino.hdfs.HdfsEnvironment;
import io.trino.hive.thrift.metastore.DataOperationType;
import io.trino.plugin.hive.HiveBasicStatistics;
import io.trino.plugin.hive.HiveColumnStatisticType;
import io.trino.plugin.hive.HiveMetastoreClosure;
import io.trino.plugin.hive.HiveTableHandle;
import io.trino.plugin.hive.HiveType;
import io.trino.plugin.hive.LocationHandle.WriteMode;
import io.trino.plugin.hive.PartitionNotFoundException;
import io.trino.plugin.hive.PartitionStatistics;
import io.trino.plugin.hive.PartitionUpdateAndMergeResults;
import io.trino.plugin.hive.SchemaAlreadyExistsException;
import io.trino.plugin.hive.TableAlreadyExistsException;
import io.trino.plugin.hive.TableInvalidationCallback;
import io.trino.plugin.hive.acid.AcidOperation;
import io.trino.plugin.hive.acid.AcidTransaction;
import io.trino.plugin.hive.metastore.HivePrivilegeInfo.HivePrivilege;
import io.trino.plugin.hive.security.SqlStandardAccessControlMetadataMetastore;
import io.trino.plugin.hive.util.RetryDriver;
import io.trino.plugin.hive.util.ValidTxnWriteIdList;
import io.trino.spi.TrinoException;
import io.trino.spi.connector.ConnectorSession;
import io.trino.spi.connector.SchemaNotFoundException;
import io.trino.spi.connector.SchemaTableName;
import io.trino.spi.connector.TableNotFoundException;
import io.trino.spi.predicate.TupleDomain;
import io.trino.spi.security.PrincipalType;
import io.trino.spi.security.RoleGrant;
import io.trino.spi.type.Type;
import org.apache.hadoop.fs.FileStatus;
import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.fs.LocatedFileStatus;
import org.apache.hadoop.fs.Path;
import org.apache.hadoop.fs.RemoteIterator;

import javax.annotation.concurrent.GuardedBy;

import java.io.FileNotFoundException;
import java.io.IOException;
import java.util.ArrayList;
import java.util.Collection;
import java.util.HashMap;
import java.util.HashSet;
import java.util.Iterator;
import java.util.LinkedHashSet;
import java.util.LinkedList;
import java.util.List;
import java.util.Map;
import java.util.Optional;
import java.util.OptionalLong;
import java.util.Queue;
import java.util.Set;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ConcurrentLinkedQueue;
import java.util.concurrent.Executor;
import java.util.concurrent.ScheduledExecutorService;
import java.util.concurrent.ScheduledFuture;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.function.Function;
import java.util.function.Supplier;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
import java.util.stream.Collectors;

import static com.google.common.base.MoreObjects.toStringHelper;
import static com.google.common.base.Preconditions.checkArgument;
import static com.google.common.base.Preconditions.checkState;
import static com.google.common.base.Verify.verify;
import static com.google.common.collect.ImmutableList.toImmutableList;
import static com.google.common.collect.ImmutableMap.toImmutableMap;
import static com.google.common.collect.ImmutableSet.toImmutableSet;
import static io.airlift.concurrent.MoreFutures.getFutureValue;
import static io.trino.plugin.hive.HiveErrorCode.HIVE_CORRUPTED_COLUMN_STATISTICS;
import static io.trino.plugin.hive.HiveErrorCode.HIVE_FILESYSTEM_ERROR;
import static io.trino.plugin.hive.HiveErrorCode.HIVE_METASTORE_ERROR;
import static io.trino.plugin.hive.HiveErrorCode.HIVE_PATH_ALREADY_EXISTS;
import static io.trino.plugin.hive.HiveErrorCode.HIVE_TABLE_DROPPED_DURING_QUERY;
import static io.trino.plugin.hive.HiveMetadata.PRESTO_QUERY_ID_NAME;
import static io.trino.plugin.hive.LocationHandle.WriteMode.DIRECT_TO_TARGET_NEW_DIRECTORY;
import static io.trino.plugin.hive.TableType.MANAGED_TABLE;
import static io.trino.plugin.hive.ViewReaderUtil.isPrestoView;
import static io.trino.plugin.hive.acid.AcidTransaction.NO_ACID_TRANSACTION;
import static io.trino.plugin.hive.metastore.HivePrivilegeInfo.HivePrivilege.OWNERSHIP;
import static io.trino.plugin.hive.metastore.MetastoreUtil.buildInitialPrivilegeSet;
import static io.trino.plugin.hive.metastore.PrincipalPrivileges.NO_PRIVILEGES;
import static io.trino.plugin.hive.util.AcidTables.isTransactionalTable;
import static io.trino.plugin.hive.util.HiveUtil.makePartName;
import static io.trino.plugin.hive.util.HiveUtil.toPartitionValues;
import static io.trino.plugin.hive.util.HiveWriteUtils.checkedDelete;
import static io.trino.plugin.hive.util.HiveWriteUtils.createDirectory;
import static io.trino.plugin.hive.util.HiveWriteUtils.isFileCreatedByQuery;
import static io.trino.plugin.hive.util.HiveWriteUtils.pathExists;
import static io.trino.plugin.hive.util.Statistics.ReduceOperator.SUBTRACT;
import static io.trino.plugin.hive.util.Statistics.merge;
import static io.trino.plugin.hive.util.Statistics.reduce;
import static io.trino.spi.StandardErrorCode.ALREADY_EXISTS;
import static io.trino.spi.StandardErrorCode.NOT_SUPPORTED;
import static io.trino.spi.StandardErrorCode.TRANSACTION_CONFLICT;
import static io.trino.spi.security.PrincipalType.USER;
import static java.lang.Long.parseLong;
import static java.lang.String.format;
import static java.util.Locale.ENGLISH;
import static java.util.Objects.requireNonNull;
import static java.util.concurrent.TimeUnit.DAYS;
import static java.util.concurrent.TimeUnit.HOURS;
import static java.util.concurrent.TimeUnit.MICROSECONDS;
import static java.util.concurrent.TimeUnit.MILLISECONDS;
import static java.util.concurrent.TimeUnit.MINUTES;
import static java.util.concurrent.TimeUnit.NANOSECONDS;
import static java.util.concurrent.TimeUnit.SECONDS;

public class SemiTransactionalHiveMetastore
        implements SqlStandardAccessControlMetadataMetastore
{
    private static final Logger log = Logger.get(SemiTransactionalHiveMetastore.class);
    private static final int PARTITION_COMMIT_BATCH_SIZE = 20;
    private static final Pattern DELTA_DIRECTORY_MATCHER = Pattern.compile("(delete_)?delta_[\\d]+_[\\d]+_[\\d]+$");

    private static final RetryDriver DELETE_RETRY = RetryDriver.retry()
            .maxAttempts(3)
            .exponentialBackoff(new Duration(1, SECONDS), new Duration(1, SECONDS), new Duration(10, SECONDS), 2.0);

    private static final Map ACID_OPERATION_ACTION_TYPES = ImmutableMap.of(
            AcidOperation.INSERT, ActionType.INSERT_EXISTING,
            AcidOperation.MERGE, ActionType.MERGE);

    private final HiveMetastoreClosure delegate;
    private final HdfsEnvironment hdfsEnvironment;
    private final Executor fileSystemExecutor;
    private final Executor dropExecutor;
    private final Executor updateExecutor;
    private final boolean skipDeletionForAlter;
    private final boolean skipTargetCleanupOnRollback;
    private final boolean deleteSchemaLocationsFallback;
    private final ScheduledExecutorService heartbeatExecutor;
    private final Optional configuredTransactionHeartbeatInterval;
    private final TableInvalidationCallback tableInvalidationCallback;

    private boolean throwOnCleanupFailure;

    @GuardedBy("this")
    private final Map> tableActions = new HashMap<>();
    @GuardedBy("this")
    private final Map, Action>> partitionActions = new HashMap<>();
    @GuardedBy("this")
    private long declaredIntentionsToWriteCounter;
    @GuardedBy("this")
    private final List declaredIntentionsToWrite = new ArrayList<>();
    @GuardedBy("this")
    private ExclusiveOperation bufferedExclusiveOperation;
    @GuardedBy("this")
    private State state = State.EMPTY;

    @GuardedBy("this")
    private Optional currentQueryId = Optional.empty();
    @GuardedBy("this")
    private Optional> hiveTransactionSupplier = Optional.empty();
    // hiveTransactionSupplier is used to lazily open hive transaction for queries.  It is opened
    // eagerly for insert operations. currentHiveTransaction is needed to do hive transaction
    // cleanup only if a transaction was opened
    @GuardedBy("this")
    private Optional currentHiveTransaction = Optional.empty();

    public SemiTransactionalHiveMetastore(
            HdfsEnvironment hdfsEnvironment,
            HiveMetastoreClosure delegate,
            Executor fileSystemExecutor,
            Executor dropExecutor,
            Executor updateExecutor,
            boolean skipDeletionForAlter,
            boolean skipTargetCleanupOnRollback,
            boolean deleteSchemaLocationsFallback,
            Optional hiveTransactionHeartbeatInterval,
            ScheduledExecutorService heartbeatService,
            TableInvalidationCallback tableInvalidationCallback)
    {
        this.hdfsEnvironment = requireNonNull(hdfsEnvironment, "hdfsEnvironment is null");
        this.delegate = requireNonNull(delegate, "delegate is null");
        this.fileSystemExecutor = requireNonNull(fileSystemExecutor, "fileSystemExecutor is null");
        this.dropExecutor = requireNonNull(dropExecutor, "dropExecutor is null");
        this.updateExecutor = requireNonNull(updateExecutor, "updateExecutor is null");
        this.skipDeletionForAlter = skipDeletionForAlter;
        this.skipTargetCleanupOnRollback = skipTargetCleanupOnRollback;
        this.deleteSchemaLocationsFallback = deleteSchemaLocationsFallback;
        this.heartbeatExecutor = heartbeatService;
        this.configuredTransactionHeartbeatInterval = requireNonNull(hiveTransactionHeartbeatInterval, "hiveTransactionHeartbeatInterval is null");
        this.tableInvalidationCallback = requireNonNull(tableInvalidationCallback, "tableInvalidationCallback is null");
    }

    public synchronized List getAllDatabases()
    {
        checkReadable();
        return delegate.getAllDatabases();
    }

    /**
     * Get the underlying metastore closure. Use this method with caution as it bypasses the current transactional state,
     * so modifications made in the transaction are visible.
     */
    public HiveMetastoreClosure unsafeGetRawHiveMetastoreClosure()
    {
        return delegate;
    }

    public synchronized Optional getDatabase(String databaseName)
    {
        checkReadable();
        return delegate.getDatabase(databaseName);
    }

    public synchronized List getAllTables(String databaseName)
    {
        checkReadable();
        if (!tableActions.isEmpty()) {
            throw new UnsupportedOperationException("Listing all tables after adding/dropping/altering tables/views in a transaction is not supported");
        }
        return delegate.getAllTables(databaseName);
    }

    public synchronized Optional getTable(String databaseName, String tableName)
    {
        checkReadable();
        Action tableAction = tableActions.get(new SchemaTableName(databaseName, tableName));
        if (tableAction == null) {
            return delegate.getTable(databaseName, tableName);
        }
        switch (tableAction.getType()) {
            case ADD:
            case ALTER:
            case INSERT_EXISTING:
            case MERGE:
                return Optional.of(tableAction.getData().getTable());
            case DROP:
                return Optional.empty();
            case DROP_PRESERVE_DATA:
                // TODO
                break;
        }
        throw new IllegalStateException("Unknown action type: " + tableAction.getType());
    }

    public synchronized boolean isReadableWithinTransaction(String databaseName, String tableName)
    {
        Action tableAction = tableActions.get(new SchemaTableName(databaseName, tableName));
        if (tableAction == null) {
            return true;
        }
        switch (tableAction.getType()) {
            case ADD:
            case ALTER:
                return true;
            case INSERT_EXISTING:
            case MERGE:
                // Until transaction is committed, the table data may or may not be visible.
                return false;
            case DROP:
            case DROP_PRESERVE_DATA:
                return false;
        }
        throw new IllegalStateException("Unknown action type: " + tableAction.getType());
    }

    public synchronized Set getSupportedColumnStatistics(Type type)
    {
        return delegate.getSupportedColumnStatistics(type);
    }

    public synchronized PartitionStatistics getTableStatistics(String databaseName, String tableName)
    {
        checkReadable();
        Action tableAction = tableActions.get(new SchemaTableName(databaseName, tableName));
        if (tableAction == null) {
            return delegate.getTableStatistics(databaseName, tableName);
        }
        switch (tableAction.getType()) {
            case ADD:
            case ALTER:
            case INSERT_EXISTING:
            case MERGE:
                return tableAction.getData().getStatistics();
            case DROP:
                return PartitionStatistics.empty();
            case DROP_PRESERVE_DATA:
                // TODO
                break;
        }
        throw new IllegalStateException("Unknown action type: " + tableAction.getType());
    }

    public synchronized Map getPartitionStatistics(String databaseName, String tableName, Set partitionNames)
    {
        checkReadable();
        Optional
table = getTable(databaseName, tableName); if (table.isEmpty()) { return ImmutableMap.of(); } TableSource tableSource = getTableSource(databaseName, tableName); Map, Action> partitionActionsOfTable = partitionActions.computeIfAbsent(table.get().getSchemaTableName(), k -> new HashMap<>()); ImmutableSet.Builder partitionNamesToQuery = ImmutableSet.builder(); ImmutableMap.Builder resultBuilder = ImmutableMap.builder(); for (String partitionName : partitionNames) { List partitionValues = toPartitionValues(partitionName); Action partitionAction = partitionActionsOfTable.get(partitionValues); if (partitionAction == null) { switch (tableSource) { case PRE_EXISTING_TABLE: partitionNamesToQuery.add(partitionName); break; case CREATED_IN_THIS_TRANSACTION: resultBuilder.put(partitionName, PartitionStatistics.empty()); break; default: throw new UnsupportedOperationException("unknown table source"); } } else { resultBuilder.put(partitionName, partitionAction.getData().getStatistics()); } } Map delegateResult = delegate.getPartitionStatistics(databaseName, tableName, partitionNamesToQuery.build()); if (!delegateResult.isEmpty()) { resultBuilder.putAll(delegateResult); } else { partitionNamesToQuery.build().forEach(partitionName -> resultBuilder.put(partitionName, PartitionStatistics.empty())); } return resultBuilder.buildOrThrow(); } /** * This method can only be called when the table is known to exist */ @GuardedBy("this") private TableSource getTableSource(String databaseName, String tableName) { checkHoldsLock(); checkReadable(); Action tableAction = tableActions.get(new SchemaTableName(databaseName, tableName)); if (tableAction == null) { return TableSource.PRE_EXISTING_TABLE; } switch (tableAction.getType()) { case ADD: return TableSource.CREATED_IN_THIS_TRANSACTION; case DROP: throw new TableNotFoundException(new SchemaTableName(databaseName, tableName)); case ALTER: case INSERT_EXISTING: case MERGE: return TableSource.PRE_EXISTING_TABLE; case DROP_PRESERVE_DATA: // TODO break; } throw new IllegalStateException("Unknown action type: " + tableAction.getType()); } public synchronized HivePageSinkMetadata generatePageSinkMetadata(SchemaTableName schemaTableName) { checkReadable(); Optional
table = getTable(schemaTableName.getSchemaName(), schemaTableName.getTableName()); if (table.isEmpty()) { return new HivePageSinkMetadata(schemaTableName, Optional.empty(), ImmutableMap.of()); } Map, Action> partitionActionMap = partitionActions.get(schemaTableName); Map, Optional> modifiedPartitionMap; if (partitionActionMap == null) { modifiedPartitionMap = ImmutableMap.of(); } else { ImmutableMap.Builder, Optional> modifiedPartitionMapBuilder = ImmutableMap.builder(); for (Map.Entry, Action> entry : partitionActionMap.entrySet()) { modifiedPartitionMapBuilder.put(entry.getKey(), getPartitionFromPartitionAction(entry.getValue())); } modifiedPartitionMap = modifiedPartitionMapBuilder.buildOrThrow(); } return new HivePageSinkMetadata( schemaTableName, table, modifiedPartitionMap); } public synchronized List getAllViews(String databaseName) { checkReadable(); if (!tableActions.isEmpty()) { throw new UnsupportedOperationException("Listing all tables after adding/dropping/altering tables/views in a transaction is not supported"); } return delegate.getAllViews(databaseName); } public synchronized void createDatabase(ConnectorSession session, Database database) { String queryId = session.getQueryId(); // Ensure the database has queryId set. This is relied on for exception handling verify( getQueryId(database).orElseThrow(() -> new IllegalArgumentException("Query id is not present")).equals(queryId), "Database '%s' does not have correct query id set", database.getDatabaseName()); setExclusive((delegate, hdfsEnvironment) -> { try { delegate.createDatabase(database); } catch (SchemaAlreadyExistsException e) { // Ignore SchemaAlreadyExistsException when database looks like created by us. // This may happen when an actually successful metastore create call is retried // e.g. because of a timeout on our side. Optional existingDatabase = delegate.getDatabase(database.getDatabaseName()); if (existingDatabase.isEmpty() || !isCreatedBy(existingDatabase.get(), queryId)) { throw e; } } }); } private static boolean isCreatedBy(Database database, String queryId) { Optional databaseQueryId = getQueryId(database); return databaseQueryId.isPresent() && databaseQueryId.get().equals(queryId); } public synchronized void dropDatabase(ConnectorSession session, String schemaName) { Optional location = delegate.getDatabase(schemaName) .orElseThrow(() -> new SchemaNotFoundException(schemaName)) .getLocation() .map(Path::new); setExclusive((delegate, hdfsEnvironment) -> { // If we see files in the schema location, don't delete it. // If we see no files, request deletion. // If we fail to check the schema location, behave according to fallback. boolean deleteData = location.map(path -> { try { return !hdfsEnvironment.getFileSystem(new HdfsContext(session), path) .listLocatedStatus(path).hasNext(); } catch (IOException | RuntimeException e) { log.warn(e, "Could not check schema directory '%s'", path); return deleteSchemaLocationsFallback; } }).orElse(deleteSchemaLocationsFallback); delegate.dropDatabase(schemaName, deleteData); }); } public synchronized void renameDatabase(String source, String target) { setExclusive((delegate, hdfsEnvironment) -> delegate.renameDatabase(source, target)); } public synchronized void setDatabaseOwner(String source, HivePrincipal principal) { setExclusive((delegate, hdfsEnvironment) -> delegate.setDatabaseOwner(source, principal)); } // TODO: Allow updating statistics for 2 tables in the same transaction public synchronized void setTableStatistics(Table table, PartitionStatistics tableStatistics) { AcidTransaction transaction = currentHiveTransaction.isPresent() ? currentHiveTransaction.get().getTransaction() : NO_ACID_TRANSACTION; setExclusive((delegate, hdfsEnvironment) -> delegate.updateTableStatistics(table.getDatabaseName(), table.getTableName(), transaction, statistics -> updatePartitionStatistics(statistics, tableStatistics))); } // TODO: Allow updating statistics for 2 tables in the same transaction public synchronized void setPartitionStatistics(Table table, Map, PartitionStatistics> partitionStatisticsMap) { Map> updates = partitionStatisticsMap.entrySet().stream().collect( toImmutableMap( entry -> getPartitionName(table, entry.getKey()), entry -> oldPartitionStats -> updatePartitionStatistics(oldPartitionStats, entry.getValue()))); setExclusive((delegate, hdfsEnvironment) -> delegate.updatePartitionStatistics( table.getDatabaseName(), table.getTableName(), updates)); } // For HiveBasicStatistics, we only overwrite the original statistics if the new one is not empty. // For HiveColumnStatistics, only overwrite the original statistics for columns present in the new ones and preserve the others. private static PartitionStatistics updatePartitionStatistics(PartitionStatistics oldPartitionStats, PartitionStatistics newPartitionStats) { HiveBasicStatistics oldBasicStatistics = oldPartitionStats.getBasicStatistics(); HiveBasicStatistics newBasicStatistics = newPartitionStats.getBasicStatistics(); HiveBasicStatistics updatedBasicStatistics = new HiveBasicStatistics( firstPresent(newBasicStatistics.getFileCount(), oldBasicStatistics.getFileCount()), firstPresent(newBasicStatistics.getRowCount(), oldBasicStatistics.getRowCount()), firstPresent(newBasicStatistics.getInMemoryDataSizeInBytes(), oldBasicStatistics.getInMemoryDataSizeInBytes()), firstPresent(newBasicStatistics.getOnDiskDataSizeInBytes(), oldBasicStatistics.getOnDiskDataSizeInBytes())); Map updatedColumnStatistics = updateColumnStatistics(oldPartitionStats.getColumnStatistics(), newPartitionStats.getColumnStatistics()); return new PartitionStatistics(updatedBasicStatistics, updatedColumnStatistics); } private static Map updateColumnStatistics(Map oldColumnStats, Map newColumnStats) { Map result = new HashMap<>(oldColumnStats); result.putAll(newColumnStats); return ImmutableMap.copyOf(result); } private static OptionalLong firstPresent(OptionalLong first, OptionalLong second) { return first.isPresent() ? first : second; } /** * {@code currentLocation} needs to be supplied if a writePath exists for the table. */ public synchronized void createTable( ConnectorSession session, Table table, PrincipalPrivileges principalPrivileges, Optional currentPath, Optional> files, boolean ignoreExisting, PartitionStatistics statistics, boolean cleanExtraOutputFilesOnCommit) { setShared(); // When creating a table, it should never have partition actions. This is just a sanity check. checkNoPartitionAction(table.getDatabaseName(), table.getTableName()); Action oldTableAction = tableActions.get(table.getSchemaTableName()); TableAndMore tableAndMore = new TableAndMore(table, Optional.of(principalPrivileges), currentPath, files, ignoreExisting, statistics, statistics, cleanExtraOutputFilesOnCommit); if (oldTableAction == null) { HdfsContext hdfsContext = new HdfsContext(session); tableActions.put(table.getSchemaTableName(), new Action<>(ActionType.ADD, tableAndMore, hdfsContext, session.getQueryId())); return; } switch (oldTableAction.getType()) { case DROP: if (!oldTableAction.getHdfsContext().getIdentity().getUser().equals(session.getUser())) { throw new TrinoException(TRANSACTION_CONFLICT, "Operation on the same table with different user in the same transaction is not supported"); } HdfsContext hdfsContext = new HdfsContext(session); tableActions.put(table.getSchemaTableName(), new Action<>(ActionType.ALTER, tableAndMore, hdfsContext, session.getQueryId())); return; case ADD: case ALTER: case INSERT_EXISTING: case MERGE: throw new TableAlreadyExistsException(table.getSchemaTableName()); case DROP_PRESERVE_DATA: // TODO break; } throw new IllegalStateException("Unknown action type: " + oldTableAction.getType()); } public synchronized void dropTable(ConnectorSession session, String databaseName, String tableName) { setShared(); // Dropping table with partition actions requires cleaning up staging data, which is not implemented yet. checkNoPartitionAction(databaseName, tableName); SchemaTableName schemaTableName = new SchemaTableName(databaseName, tableName); Action oldTableAction = tableActions.get(schemaTableName); if (oldTableAction == null || oldTableAction.getType() == ActionType.ALTER) { HdfsContext hdfsContext = new HdfsContext(session); tableActions.put(schemaTableName, new Action<>(ActionType.DROP, null, hdfsContext, session.getQueryId())); return; } switch (oldTableAction.getType()) { case DROP: throw new TableNotFoundException(schemaTableName); case ADD: case ALTER: case INSERT_EXISTING: case MERGE: throw new UnsupportedOperationException("dropping a table added/modified in the same transaction is not supported"); case DROP_PRESERVE_DATA: // TODO break; } throw new IllegalStateException("Unknown action type: " + oldTableAction.getType()); } public synchronized void replaceTable(String databaseName, String tableName, Table table, PrincipalPrivileges principalPrivileges) { setExclusive((delegate, hdfsEnvironment) -> delegate.replaceTable(databaseName, tableName, table, principalPrivileges)); } public synchronized void renameTable(String databaseName, String tableName, String newDatabaseName, String newTableName) { setExclusive((delegate, hdfsEnvironment) -> { Optional
oldTable = delegate.getTable(databaseName, tableName); try { delegate.renameTable(databaseName, tableName, newDatabaseName, newTableName); } finally { // perform explicit invalidation for the table in exclusive metastore operations oldTable.ifPresent(tableInvalidationCallback::invalidate); } }); } public synchronized void commentTable(String databaseName, String tableName, Optional comment) { setExclusive((delegate, hdfsEnvironment) -> delegate.commentTable(databaseName, tableName, comment)); } public synchronized void setTableOwner(String schema, String table, HivePrincipal principal) { setExclusive((delegate, hdfsEnvironment) -> delegate.setTableOwner(schema, table, principal)); } public synchronized void commentColumn(String databaseName, String tableName, String columnName, Optional comment) { setExclusive((delegate, hdfsEnvironment) -> delegate.commentColumn(databaseName, tableName, columnName, comment)); } public synchronized void addColumn(String databaseName, String tableName, String columnName, HiveType columnType, String columnComment) { setExclusive((delegate, hdfsEnvironment) -> delegate.addColumn(databaseName, tableName, columnName, columnType, columnComment)); } public synchronized void renameColumn(String databaseName, String tableName, String oldColumnName, String newColumnName) { setExclusive((delegate, hdfsEnvironment) -> delegate.renameColumn(databaseName, tableName, oldColumnName, newColumnName)); } public synchronized void dropColumn(String databaseName, String tableName, String columnName) { setExclusive((delegate, hdfsEnvironment) -> delegate.dropColumn(databaseName, tableName, columnName)); } public synchronized void finishChangingExistingTable( AcidOperation acidOperation, ConnectorSession session, String databaseName, String tableName, Path currentLocation, List fileNames, PartitionStatistics statisticsUpdate, boolean cleanExtraOutputFilesOnCommit) { // Data can only be inserted into partitions and unpartitioned tables. They can never be inserted into a partitioned table. // Therefore, this method assumes that the table is unpartitioned. setShared(); SchemaTableName schemaTableName = new SchemaTableName(databaseName, tableName); ActionType actionType = requireNonNull(ACID_OPERATION_ACTION_TYPES.get(acidOperation), "ACID_OPERATION_ACTION_TYPES doesn't contain the acidOperation"); Action oldTableAction = tableActions.get(schemaTableName); if (oldTableAction == null) { Table table = getExistingTable(schemaTableName.getSchemaName(), schemaTableName.getTableName()); if (isAcidTransactionRunning()) { table = Table.builder(table).setWriteId(OptionalLong.of(currentHiveTransaction.orElseThrow().getTransaction().getWriteId())).build(); } PartitionStatistics currentStatistics = getTableStatistics(databaseName, tableName); HdfsContext hdfsContext = new HdfsContext(session); tableActions.put( schemaTableName, new Action<>( actionType, new TableAndMore( table, Optional.empty(), Optional.of(currentLocation), Optional.of(fileNames), false, merge(currentStatistics, statisticsUpdate), statisticsUpdate, cleanExtraOutputFilesOnCommit), hdfsContext, session.getQueryId())); return; } switch (oldTableAction.getType()) { case DROP: throw new TableNotFoundException(schemaTableName); case ADD: case ALTER: case INSERT_EXISTING: case MERGE: throw new UnsupportedOperationException("Inserting into an unpartitioned table that were added, altered, or inserted into in the same transaction is not supported"); case DROP_PRESERVE_DATA: // TODO break; } throw new IllegalStateException("Unknown action type: " + oldTableAction.getType()); } private boolean isAcidTransactionRunning() { return currentHiveTransaction.isPresent() && currentHiveTransaction.get().getTransaction().isAcidTransactionRunning(); } public synchronized void truncateUnpartitionedTable(ConnectorSession session, String databaseName, String tableName) { checkReadable(); SchemaTableName schemaTableName = new SchemaTableName(databaseName, tableName); Table table = getTable(databaseName, tableName) .orElseThrow(() -> new TableNotFoundException(schemaTableName)); if (!table.getTableType().equals(MANAGED_TABLE.toString())) { throw new TrinoException(NOT_SUPPORTED, "Cannot delete from non-managed Hive table"); } if (!table.getPartitionColumns().isEmpty()) { throw new IllegalArgumentException("Table is partitioned"); } Path path = new Path(table.getStorage().getLocation()); HdfsContext context = new HdfsContext(session); setExclusive((delegate, hdfsEnvironment) -> { RecursiveDeleteResult recursiveDeleteResult = recursiveDeleteFiles(hdfsEnvironment, context, path, ImmutableSet.of(""), false); if (!recursiveDeleteResult.getNotDeletedEligibleItems().isEmpty()) { throw new TrinoException(HIVE_FILESYSTEM_ERROR, format( "Error deleting from unpartitioned table %s. These items cannot be deleted: %s", schemaTableName, recursiveDeleteResult.getNotDeletedEligibleItems())); } }); } public synchronized void finishMerge( ConnectorSession session, String databaseName, String tableName, Path currentLocation, List partitionUpdateAndMergeResults, List partitions) { if (partitionUpdateAndMergeResults.isEmpty()) { return; } checkArgument(partitionUpdateAndMergeResults.size() >= partitions.size(), "partitionUpdateAndMergeResults.size() (%s) < partitions.size() (%s)", partitionUpdateAndMergeResults.size(), partitions.size()); setShared(); if (partitions.isEmpty()) { return; } SchemaTableName schemaTableName = new SchemaTableName(databaseName, tableName); Action oldTableAction = tableActions.get(schemaTableName); if (oldTableAction == null) { Table table = getExistingTable(schemaTableName.getSchemaName(), schemaTableName.getTableName()); HdfsContext hdfsContext = new HdfsContext(session); PrincipalPrivileges principalPrivileges = table.getOwner().isEmpty() ? NO_PRIVILEGES : buildInitialPrivilegeSet(table.getOwner().get()); tableActions.put( schemaTableName, new Action<>( ActionType.MERGE, new TableAndMergeResults( table, Optional.of(principalPrivileges), Optional.of(currentLocation), partitionUpdateAndMergeResults, partitions), hdfsContext, session.getQueryId())); return; } switch (oldTableAction.getType()) { case DROP: throw new TableNotFoundException(schemaTableName); case ADD: case ALTER: case INSERT_EXISTING: case MERGE: throw new UnsupportedOperationException("Inserting, updating or deleting in a table that was added, altered, inserted into, updated or deleted from in the same transaction is not supported"); case DROP_PRESERVE_DATA: // TODO break; } throw new IllegalStateException("Unknown action type: " + oldTableAction.getType()); } public synchronized Optional> getPartitionNames(String databaseName, String tableName) { Optional
table = getTable(databaseName, tableName); if (table.isEmpty()) { return Optional.empty(); } List columnNames = table.get().getPartitionColumns().stream() .map(Column::getName) .collect(toImmutableList()); return doGetPartitionNames(databaseName, tableName, columnNames, TupleDomain.all()); } public synchronized Optional> getPartitionNamesByFilter( String databaseName, String tableName, List columnNames, TupleDomain partitionKeysFilter) { return doGetPartitionNames(databaseName, tableName, columnNames, partitionKeysFilter); } @GuardedBy("this") private Optional> doGetPartitionNames( String databaseName, String tableName, List columnNames, TupleDomain partitionKeysFilter) { checkHoldsLock(); checkReadable(); if (partitionKeysFilter.isNone()) { return Optional.of(ImmutableList.of()); } Optional
table = getTable(databaseName, tableName); if (table.isEmpty()) { return Optional.empty(); } List partitionNames; TableSource tableSource = getTableSource(databaseName, tableName); switch (tableSource) { case CREATED_IN_THIS_TRANSACTION: partitionNames = ImmutableList.of(); break; case PRE_EXISTING_TABLE: partitionNames = delegate.getPartitionNamesByFilter(databaseName, tableName, columnNames, partitionKeysFilter) .orElseThrow(() -> new TrinoException(TRANSACTION_CONFLICT, format("Table '%s.%s' was dropped by another transaction", databaseName, tableName))); break; default: throw new UnsupportedOperationException("Unknown table source"); } Map, Action> partitionActionsOfTable = partitionActions.computeIfAbsent(table.get().getSchemaTableName(), k -> new HashMap<>()); ImmutableList.Builder resultBuilder = ImmutableList.builder(); // alter/remove newly-altered/dropped partitions from the results from underlying metastore for (String partitionName : partitionNames) { List partitionValues = toPartitionValues(partitionName); Action partitionAction = partitionActionsOfTable.get(partitionValues); if (partitionAction == null) { resultBuilder.add(partitionName); continue; } switch (partitionAction.getType()) { case ADD: throw new TrinoException(TRANSACTION_CONFLICT, format("Another transaction created partition %s in table %s.%s", partitionValues, databaseName, tableName)); case DROP: case DROP_PRESERVE_DATA: // do nothing break; case ALTER: case INSERT_EXISTING: case MERGE: resultBuilder.add(partitionName); break; default: throw new IllegalStateException("Unknown action type: " + partitionAction.getType()); } } // add newly-added partitions to the results from underlying metastore. if (!partitionActionsOfTable.isEmpty()) { for (Action partitionAction : partitionActionsOfTable.values()) { if (partitionAction.getType() == ActionType.ADD) { List values = partitionAction.getData().getPartition().getValues(); resultBuilder.add(makePartName(columnNames, values)); } } } return Optional.of(resultBuilder.build()); } public synchronized Map> getPartitionsByNames(String databaseName, String tableName, List partitionNames) { checkReadable(); TableSource tableSource = getTableSource(databaseName, tableName); Map, Action> partitionActionsOfTable = partitionActions.computeIfAbsent(new SchemaTableName(databaseName, tableName), k -> new HashMap<>()); ImmutableList.Builder partitionNamesToQueryBuilder = ImmutableList.builder(); ImmutableMap.Builder> resultBuilder = ImmutableMap.builder(); for (String partitionName : partitionNames) { List partitionValues = toPartitionValues(partitionName); Action partitionAction = partitionActionsOfTable.get(partitionValues); if (partitionAction == null) { switch (tableSource) { case PRE_EXISTING_TABLE: partitionNamesToQueryBuilder.add(partitionName); break; case CREATED_IN_THIS_TRANSACTION: resultBuilder.put(partitionName, Optional.empty()); break; default: throw new UnsupportedOperationException("unknown table source"); } } else { resultBuilder.put(partitionName, getPartitionFromPartitionAction(partitionAction)); } } List partitionNamesToQuery = partitionNamesToQueryBuilder.build(); if (!partitionNamesToQuery.isEmpty()) { Map> delegateResult = delegate.getPartitionsByNames( databaseName, tableName, partitionNamesToQuery); resultBuilder.putAll(delegateResult); } return resultBuilder.buildOrThrow(); } private static Optional getPartitionFromPartitionAction(Action partitionAction) { switch (partitionAction.getType()) { case ADD: case ALTER: case INSERT_EXISTING: case MERGE: return Optional.of(partitionAction.getData().getAugmentedPartitionForInTransactionRead()); case DROP: case DROP_PRESERVE_DATA: return Optional.empty(); } throw new IllegalStateException("Unknown action type: " + partitionAction.getType()); } public synchronized void addPartition( ConnectorSession session, String databaseName, String tableName, Partition partition, Path currentLocation, Optional> files, PartitionStatistics statistics, boolean cleanExtraOutputFilesOnCommit) { setShared(); checkArgument(getQueryId(partition).isPresent()); Map, Action> partitionActionsOfTable = partitionActions.computeIfAbsent(new SchemaTableName(databaseName, tableName), k -> new HashMap<>()); Action oldPartitionAction = partitionActionsOfTable.get(partition.getValues()); HdfsContext hdfsContext = new HdfsContext(session); if (oldPartitionAction == null) { partitionActionsOfTable.put( partition.getValues(), new Action<>(ActionType.ADD, new PartitionAndMore(partition, currentLocation, files, statistics, statistics, cleanExtraOutputFilesOnCommit), hdfsContext, session.getQueryId())); return; } switch (oldPartitionAction.getType()) { case DROP: case DROP_PRESERVE_DATA: if (!oldPartitionAction.getHdfsContext().getIdentity().getUser().equals(session.getUser())) { throw new TrinoException(TRANSACTION_CONFLICT, "Operation on the same partition with different user in the same transaction is not supported"); } partitionActionsOfTable.put( partition.getValues(), new Action<>(ActionType.ALTER, new PartitionAndMore(partition, currentLocation, files, statistics, statistics, cleanExtraOutputFilesOnCommit), hdfsContext, session.getQueryId())); return; case ADD: case ALTER: case INSERT_EXISTING: case MERGE: throw new TrinoException(ALREADY_EXISTS, format("Partition already exists for table '%s.%s': %s", databaseName, tableName, partition.getValues())); } throw new IllegalStateException("Unknown action type: " + oldPartitionAction.getType()); } public synchronized void dropPartition(ConnectorSession session, String databaseName, String tableName, List partitionValues, boolean deleteData) { setShared(); Map, Action> partitionActionsOfTable = partitionActions.computeIfAbsent(new SchemaTableName(databaseName, tableName), k -> new HashMap<>()); Action oldPartitionAction = partitionActionsOfTable.get(partitionValues); if (oldPartitionAction == null) { HdfsContext hdfsContext = new HdfsContext(session); if (deleteData) { partitionActionsOfTable.put(partitionValues, new Action<>(ActionType.DROP, null, hdfsContext, session.getQueryId())); } else { partitionActionsOfTable.put(partitionValues, new Action<>(ActionType.DROP_PRESERVE_DATA, null, hdfsContext, session.getQueryId())); } return; } switch (oldPartitionAction.getType()) { case DROP: case DROP_PRESERVE_DATA: throw new PartitionNotFoundException(new SchemaTableName(databaseName, tableName), partitionValues); case ADD: case ALTER: case INSERT_EXISTING: case MERGE: throw new TrinoException( NOT_SUPPORTED, format("dropping a partition added in the same transaction is not supported: %s %s %s", databaseName, tableName, partitionValues)); } throw new IllegalStateException("Unknown action type: " + oldPartitionAction.getType()); } public synchronized void finishInsertIntoExistingPartitions( ConnectorSession session, String databaseName, String tableName, List partitionUpdateInfos, boolean cleanExtraOutputFilesOnCommit) { setShared(); SchemaTableName schemaTableName = new SchemaTableName(databaseName, tableName); HdfsContext context = new HdfsContext(session); Map, Action> partitionActionsOfTable = partitionActions.computeIfAbsent(schemaTableName, k -> new HashMap<>()); for (PartitionUpdateInfo partitionInfo : partitionUpdateInfos) { Action oldPartitionAction = partitionActionsOfTable.get(partitionInfo.partitionValues); if (oldPartitionAction != null) { switch (oldPartitionAction.getType()) { case DROP, DROP_PRESERVE_DATA -> throw new PartitionNotFoundException(schemaTableName, partitionInfo.partitionValues); case ADD, ALTER, INSERT_EXISTING, MERGE -> throw new UnsupportedOperationException("Inserting into a partition that were added, altered, or inserted into in the same transaction is not supported"); default -> throw new IllegalStateException("Unknown action type: " + oldPartitionAction.getType()); } } } for (List partitionInfoBatch : Iterables.partition(partitionUpdateInfos, 100)) { List partitionNames = partitionInfoBatch.stream() .map(PartitionUpdateInfo::partitionValues) .map(partitionValues -> getPartitionName(databaseName, tableName, partitionValues)) .collect(toImmutableList()); Map> partitionsByNames = delegate.getPartitionsByNames( schemaTableName.getSchemaName(), schemaTableName.getTableName(), partitionNames); Map partitionStatistics = delegate.getPartitionStatistics( schemaTableName.getSchemaName(), schemaTableName.getTableName(), ImmutableSet.copyOf(partitionNames)); for (int i = 0; i < partitionInfoBatch.size(); i++) { PartitionUpdateInfo partitionInfo = partitionInfoBatch.get(i); String partitionName = partitionNames.get(i); Optional partition = partitionsByNames.get(partitionName); if (partition.isEmpty()) { throw new PartitionNotFoundException(schemaTableName, partitionInfo.partitionValues); } PartitionStatistics currentStatistics = partitionStatistics.get(partitionName); if (currentStatistics == null) { throw new TrinoException(HIVE_METASTORE_ERROR, "currentStatistics is null"); } partitionActionsOfTable.put( partitionInfo.partitionValues, new Action<>( ActionType.INSERT_EXISTING, new PartitionAndMore( partition.get(), partitionInfo.currentLocation, Optional.of(partitionInfo.fileNames), merge(currentStatistics, partitionInfo.statisticsUpdate), partitionInfo.statisticsUpdate, cleanExtraOutputFilesOnCommit), context, session.getQueryId())); } } } private synchronized AcidTransaction getCurrentAcidTransaction() { return currentHiveTransaction.map(HiveTransaction::getTransaction) .orElseThrow(() -> new IllegalStateException("currentHiveTransaction not present")); } private String getPartitionName(String databaseName, String tableName, List partitionValues) { Table table = getTable(databaseName, tableName) .orElseThrow(() -> new TableNotFoundException(new SchemaTableName(databaseName, tableName))); return getPartitionName(table, partitionValues); } private static String getPartitionName(Table table, List partitionValues) { List columnNames = table.getPartitionColumns().stream() .map(Column::getName) .collect(toImmutableList()); return makePartName(columnNames, partitionValues); } @Override public synchronized void createRole(String role, String grantor) { setExclusive((delegate, hdfsEnvironment) -> delegate.createRole(role, grantor)); } @Override public synchronized void dropRole(String role) { setExclusive((delegate, hdfsEnvironment) -> delegate.dropRole(role)); } @Override public synchronized Set listRoles() { checkReadable(); return delegate.listRoles(); } @Override public synchronized void grantRoles(Set roles, Set grantees, boolean adminOption, HivePrincipal grantor) { setExclusive((delegate, hdfsEnvironment) -> delegate.grantRoles(roles, grantees, adminOption, grantor)); } @Override public synchronized void revokeRoles(Set roles, Set grantees, boolean adminOption, HivePrincipal grantor) { setExclusive((delegate, hdfsEnvironment) -> delegate.revokeRoles(roles, grantees, adminOption, grantor)); } @Override public synchronized Set listGrantedPrincipals(String role) { checkReadable(); return delegate.listGrantedPrincipals(role); } @Override public synchronized Set listRoleGrants(HivePrincipal principal) { checkReadable(); return delegate.listRoleGrants(principal); } @Override public Optional getDatabaseOwner(String databaseName) { Database database = getDatabase(databaseName) .orElseThrow(() -> new SchemaNotFoundException(databaseName)); return database.getOwnerName().map(ownerName -> new HivePrincipal(database.getOwnerType().orElseThrow(), ownerName)); } @Override public synchronized Set listTablePrivileges(String databaseName, String tableName, Optional principal) { checkReadable(); SchemaTableName schemaTableName = new SchemaTableName(databaseName, tableName); Action tableAction = tableActions.get(schemaTableName); if (tableAction == null) { return delegate.listTablePrivileges(databaseName, tableName, getExistingTable(databaseName, tableName).getOwner(), principal); } switch (tableAction.getType()) { case ADD: case ALTER: if (principal.isPresent() && principal.get().getType() == PrincipalType.ROLE) { return ImmutableSet.of(); } Optional owner = tableAction.getData().getTable().getOwner(); if (owner.isEmpty()) { // todo the existing logic below seem off. Only permissions held by the table owner are returned return ImmutableSet.of(); } String ownerUsername = owner.orElseThrow(); if (principal.isPresent() && !principal.get().getName().equals(ownerUsername)) { return ImmutableSet.of(); } Collection privileges = tableAction.getData().getPrincipalPrivileges().getUserPrivileges().get(ownerUsername); return ImmutableSet.builder() .addAll(privileges) .add(new HivePrivilegeInfo(OWNERSHIP, true, new HivePrincipal(USER, ownerUsername), new HivePrincipal(USER, ownerUsername))) .build(); case INSERT_EXISTING: case MERGE: return delegate.listTablePrivileges(databaseName, tableName, getExistingTable(databaseName, tableName).getOwner(), principal); case DROP: throw new TableNotFoundException(schemaTableName); case DROP_PRESERVE_DATA: // TODO break; } throw new IllegalStateException("Unknown action type: " + tableAction.getType()); } private synchronized String getRequiredTableOwner(String databaseName, String tableName) { return getExistingTable(databaseName, tableName).getOwner().orElseThrow(); } private Table getExistingTable(String databaseName, String tableName) { return delegate.getTable(databaseName, tableName) .orElseThrow(() -> new TableNotFoundException(new SchemaTableName(databaseName, tableName))); } @Override public synchronized void grantTablePrivileges(String databaseName, String tableName, HivePrincipal grantee, HivePrincipal grantor, Set privileges, boolean grantOption) { setExclusive((delegate, hdfsEnvironment) -> delegate.grantTablePrivileges(databaseName, tableName, getRequiredTableOwner(databaseName, tableName), grantee, grantor, privileges, grantOption)); } @Override public synchronized void revokeTablePrivileges(String databaseName, String tableName, HivePrincipal grantee, HivePrincipal grantor, Set privileges, boolean grantOption) { setExclusive((delegate, hdfsEnvironment) -> delegate.revokeTablePrivileges(databaseName, tableName, getRequiredTableOwner(databaseName, tableName), grantee, grantor, privileges, grantOption)); } public synchronized String declareIntentionToWrite(ConnectorSession session, WriteMode writeMode, Path stagingPathRoot, SchemaTableName schemaTableName) { setShared(); if (writeMode == WriteMode.DIRECT_TO_TARGET_EXISTING_DIRECTORY) { Map, Action> partitionActionsOfTable = partitionActions.get(schemaTableName); if (partitionActionsOfTable != null && !partitionActionsOfTable.isEmpty()) { throw new TrinoException(NOT_SUPPORTED, "Cannot insert into a table with a partition that has been modified in the same transaction when Trino is configured to skip temporary directories."); } } HdfsContext hdfsContext = new HdfsContext(session); String queryId = session.getQueryId(); String declarationId = queryId + "_" + declaredIntentionsToWriteCounter; declaredIntentionsToWriteCounter++; declaredIntentionsToWrite.add(new DeclaredIntentionToWrite(declarationId, writeMode, hdfsContext, queryId, stagingPathRoot, schemaTableName)); return declarationId; } public synchronized void dropDeclaredIntentionToWrite(String declarationId) { boolean removed = declaredIntentionsToWrite.removeIf(intention -> intention.getDeclarationId().equals(declarationId)); if (!removed) { throw new IllegalArgumentException("Declaration with id " + declarationId + " not found"); } } public boolean isFinished() { return state == State.FINISHED; } public synchronized void commit() { try { switch (state) { case EMPTY: return; case SHARED_OPERATION_BUFFERED: commitShared(); return; case EXCLUSIVE_OPERATION_BUFFERED: requireNonNull(bufferedExclusiveOperation, "bufferedExclusiveOperation is null"); bufferedExclusiveOperation.execute(delegate, hdfsEnvironment); return; case FINISHED: throw new IllegalStateException("Tried to commit buffered metastore operations after transaction has been committed/aborted"); } throw new IllegalStateException("Unknown state: " + state); } finally { state = State.FINISHED; } } public synchronized void rollback() { try { switch (state) { case EMPTY: case EXCLUSIVE_OPERATION_BUFFERED: return; case SHARED_OPERATION_BUFFERED: rollbackShared(); return; case FINISHED: throw new IllegalStateException("Tried to rollback buffered metastore operations after transaction has been committed/aborted"); } throw new IllegalStateException("Unknown state: " + state); } finally { state = State.FINISHED; } } public void checkSupportsHiveAcidTransactions() { delegate.checkSupportsTransactions(); } public void beginQuery(ConnectorSession session) { String queryId = session.getQueryId(); synchronized (this) { checkState( currentQueryId.isEmpty() && hiveTransactionSupplier.isEmpty(), "Query already begun: %s while starting query %s", currentQueryId, queryId); currentQueryId = Optional.of(queryId); hiveTransactionSupplier = Optional.of(() -> makeHiveTransaction(session, transactionId -> NO_ACID_TRANSACTION)); } } public AcidTransaction beginInsert(ConnectorSession session, Table table) { return beginOperation(session, table, AcidOperation.INSERT, DataOperationType.INSERT); } public AcidTransaction beginMerge(ConnectorSession session, Table table) { return beginOperation(session, table, AcidOperation.MERGE, DataOperationType.UPDATE); } private AcidTransaction beginOperation(ConnectorSession session, Table table, AcidOperation operation, DataOperationType hiveOperation) { String queryId = session.getQueryId(); synchronized (this) { currentQueryId = Optional.of(queryId); // We start the transaction immediately, and allocate the write lock and the writeId, // because we need the writeId in order to write the delta files. HiveTransaction hiveTransaction = makeHiveTransaction(session, transactionId -> { acquireTableWriteLock( new AcidTransactionOwner(session.getUser()), queryId, transactionId, table.getDatabaseName(), table.getTableName(), hiveOperation, !table.getPartitionColumns().isEmpty()); long writeId = allocateWriteId(table.getDatabaseName(), table.getTableName(), transactionId); return new AcidTransaction(operation, transactionId, writeId); }); hiveTransactionSupplier = Optional.of(() -> hiveTransaction); currentHiveTransaction = Optional.of(hiveTransaction); return hiveTransaction.getTransaction(); } } private HiveTransaction makeHiveTransaction(ConnectorSession session, Function transactionMaker) { String queryId = session.getQueryId(); long heartbeatInterval = configuredTransactionHeartbeatInterval .map(Duration::toMillis) .orElseGet(this::getServerExpectedHeartbeatIntervalMillis); // TODO consider adding query id to the owner long transactionId = delegate.openTransaction(new AcidTransactionOwner(session.getUser())); log.debug("Using hive transaction %s for %s", transactionId, queryId); ScheduledFuture heartbeatTask = heartbeatExecutor.scheduleAtFixedRate( () -> delegate.sendTransactionHeartbeat(transactionId), 0, heartbeatInterval, MILLISECONDS); AcidTransaction transaction = transactionMaker.apply(transactionId); return new HiveTransaction(queryId, transactionId, heartbeatTask, transaction); } private long getServerExpectedHeartbeatIntervalMillis() { String timeout = delegate.getConfigValue("metastore.txn.timeout").orElse("300s"); return metastoreTimeToMillis(timeout) / 2; } private static final Pattern METASTORE_TIME = Pattern.compile("([0-9]+)([a-zA-Z]+)"); // based on org.apache.hadoop.hive.metastore.conf.MetastoreConf#convertTimeStr private static long metastoreTimeToMillis(String value) { if (CharMatcher.inRange('0', '9').matches(value.charAt(value.length() - 1))) { return SECONDS.toMillis(parseLong(value)); } Matcher matcher = METASTORE_TIME.matcher(value); checkArgument(matcher.matches(), "Invalid time unit: %s", value); long duration = parseLong(matcher.group(1)); String unit = matcher.group(2).toLowerCase(ENGLISH); if (unit.equals("s") || unit.startsWith("sec")) { return SECONDS.toMillis(duration); } if (unit.equals("ms") || unit.startsWith("msec")) { return duration; } if (unit.equals("m") || unit.startsWith("min")) { return MINUTES.toMillis(duration); } if (unit.equals("us") || unit.startsWith("usec")) { return MICROSECONDS.toMillis(duration); } if (unit.equals("ns") || unit.startsWith("nsec")) { return NANOSECONDS.toMillis(duration); } if (unit.equals("h") || unit.startsWith("hour")) { return HOURS.toMillis(duration); } if (unit.equals("d") || unit.startsWith("day")) { return DAYS.toMillis(duration); } throw new IllegalArgumentException("Invalid time unit " + unit); } public Optional getValidWriteIds(ConnectorSession session, HiveTableHandle tableHandle) { HiveTransaction hiveTransaction; synchronized (this) { String queryId = session.getQueryId(); checkState(currentQueryId.equals(Optional.of(queryId)), "Invalid query id %s while current query is %s", queryId, currentQueryId); if (!isTransactionalTable(tableHandle.getTableParameters().orElseThrow(() -> new IllegalStateException("tableParameters missing")))) { return Optional.empty(); } if (currentHiveTransaction.isEmpty()) { currentHiveTransaction = Optional.of(hiveTransactionSupplier .orElseThrow(() -> new IllegalStateException("hiveTransactionSupplier is not set")) .get()); } hiveTransaction = currentHiveTransaction.get(); } return Optional.of(hiveTransaction.getValidWriteIds(new AcidTransactionOwner(session.getUser()), delegate, tableHandle)); } public synchronized void cleanupQuery(ConnectorSession session) { String queryId = session.getQueryId(); checkState(currentQueryId.equals(Optional.of(queryId)), "Invalid query id %s while current query is %s", queryId, currentQueryId); Optional transaction = currentHiveTransaction; if (transaction.isEmpty()) { clearCurrentTransaction(); return; } try { commit(); } catch (Throwable commitFailure) { try { postCommitCleanup(transaction, false); } catch (Throwable cleanupFailure) { if (cleanupFailure != commitFailure) { commitFailure.addSuppressed(cleanupFailure); } } throw commitFailure; } postCommitCleanup(transaction, true); } private void postCommitCleanup(Optional transaction, boolean commit) { clearCurrentTransaction(); long transactionId = transaction.orElseThrow().getTransactionId(); ScheduledFuture heartbeatTask = transaction.get().getHeartbeatTask(); heartbeatTask.cancel(true); if (commit) { // Any failure around aborted transactions, etc would be handled by Hive Metastore commit and TrinoException will be thrown delegate.commitTransaction(transactionId); } else { delegate.abortTransaction(transactionId); } } @GuardedBy("this") private synchronized void clearCurrentTransaction() { currentQueryId = Optional.empty(); currentHiveTransaction = Optional.empty(); hiveTransactionSupplier = Optional.empty(); } @GuardedBy("this") private void commitShared() { checkHoldsLock(); AcidTransaction transaction = currentHiveTransaction.isEmpty() ? NO_ACID_TRANSACTION : currentHiveTransaction.get().getTransaction(); Committer committer = new Committer(transaction); try { for (Map.Entry> entry : tableActions.entrySet()) { SchemaTableName schemaTableName = entry.getKey(); Action action = entry.getValue(); switch (action.getType()) { case DROP: committer.prepareDropTable(schemaTableName); break; case ALTER: committer.prepareAlterTable(action.getHdfsContext(), action.getQueryId(), action.getData()); break; case ADD: committer.prepareAddTable(action.getHdfsContext(), action.getQueryId(), action.getData()); break; case INSERT_EXISTING: committer.prepareInsertExistingTable(action.getHdfsContext(), action.getQueryId(), action.getData()); break; case MERGE: committer.prepareMergeExistingTable(action.getHdfsContext(), action.getData()); break; default: throw new IllegalStateException("Unknown action type: " + action.getType()); } } for (Map.Entry, Action>> tableEntry : partitionActions.entrySet()) { SchemaTableName schemaTableName = tableEntry.getKey(); for (Map.Entry, Action> partitionEntry : tableEntry.getValue().entrySet()) { List partitionValues = partitionEntry.getKey(); Action action = partitionEntry.getValue(); switch (action.getType()) { case DROP: committer.prepareDropPartition(schemaTableName, partitionValues, true); break; case DROP_PRESERVE_DATA: committer.prepareDropPartition(schemaTableName, partitionValues, false); break; case ALTER: committer.prepareAlterPartition(action.getHdfsContext(), action.getQueryId(), action.getData()); break; case ADD: committer.prepareAddPartition(action.getHdfsContext(), action.getQueryId(), action.getData()); break; case INSERT_EXISTING: committer.prepareInsertExistingPartition(action.getHdfsContext(), action.getQueryId(), action.getData()); break; case MERGE: committer.prepareInsertExistingPartition(action.getHdfsContext(), action.getQueryId(), action.getData()); break; default: throw new IllegalStateException("Unknown action type: " + action.getType()); } } } // Wait for all file system operations for "INSERT_EXISTING" and "ADD" action to finish committer.waitForAsyncFileSystemOperations(); // At this point, all file system operations, whether asynchronously issued or not, have completed successfully. // We are moving on to metastore operations now. committer.executeAddTableOperations(transaction); committer.executeAlterTableOperations(); committer.executeAlterPartitionOperations(); committer.executeAddPartitionOperations(transaction); committer.executeUpdateStatisticsOperations(transaction); } catch (Throwable t) { log.warn("Rolling back due to metastore commit failure: %s", t.getMessage()); try { committer.cancelUnstartedAsyncFileSystemOperations(); committer.undoUpdateStatisticsOperations(transaction); committer.undoAddPartitionOperations(); committer.undoAddTableOperations(); committer.waitForAsyncFileSystemOperationSuppressThrowable(); // fileSystemFutures must all come back before any file system cleanups are carried out. // Otherwise, files that should be deleted may be created after cleanup is done. committer.executeCleanupTasksForAbort(declaredIntentionsToWrite); committer.executeRenameTasksForAbort(); // Partition directory must be put back before relevant metastore operation can be undone committer.undoAlterTableOperations(); committer.undoAlterPartitionOperations(); rollbackShared(); } catch (RuntimeException e) { t.addSuppressed(new Exception("Failed to roll back after commit failure", e)); } throw t; } finally { committer.executeTableInvalidationCallback(); } try { // After this line, operations are no longer reversible. // The next section will deal with "dropping table/partition". Commit may still fail in // this section. Even if commit fails, cleanups, instead of rollbacks, will be executed. committer.executeIrreversibleMetastoreOperations(); // If control flow reached this point, this commit is considered successful no matter // what happens later. The only kind of operations that haven't been carried out yet // are cleanups. // The program control flow will go to finally next. And cleanup will run because // moveForwardInFinally has been set to false. } finally { // In this method, all operations are best-effort clean up operations. // If any operation fails, the error will be logged and ignored. // Additionally, other clean up operations should still be attempted. // Execute deletion tasks committer.executeDeletionTasksForFinish(); // Clean up staging directories (that may recursively contain empty directories or stale files from failed attempts) committer.pruneAndDeleteStagingDirectories(declaredIntentionsToWrite); } } private class Committer { private final AtomicBoolean fileSystemOperationsCancelled = new AtomicBoolean(false); private final List> fileSystemOperationFutures = new ArrayList<>(); // File system // For file system changes, only operations outside of writing paths (as specified in declared intentions to write) // need to MOVE_BACKWARD tasks scheduled. Files in writing paths are handled by rollbackShared(). private final List deletionTasksForFinish = new ArrayList<>(); private final List renameTasksForAbort = new ArrayList<>(); private final Queue cleanUpTasksForAbort = new ConcurrentLinkedQueue<>(); // Notify callback about changes on the schema tables / partitions private final Set
tablesToInvalidate = new LinkedHashSet<>(); private final Set partitionsToInvalidate = new LinkedHashSet<>(); // Metastore private final List addTableOperations = new ArrayList<>(); private final List alterTableOperations = new ArrayList<>(); private final Map partitionAdders = new HashMap<>(); private final List alterPartitionOperations = new ArrayList<>(); private final List updateStatisticsOperations = new ArrayList<>(); private final List metastoreDeleteOperations = new ArrayList<>(); private final AcidTransaction transaction; // Flag for better error message private boolean deleteOnly = true; Committer(AcidTransaction transaction) { this.transaction = transaction; } private void prepareDropTable(SchemaTableName schemaTableName) { metastoreDeleteOperations.add(new IrreversibleMetastoreOperation( format("drop table %s", schemaTableName), () -> { Optional
droppedTable = delegate.getTable(schemaTableName.getSchemaName(), schemaTableName.getTableName()); try { delegate.dropTable(schemaTableName.getSchemaName(), schemaTableName.getTableName(), true); } finally { // perform explicit invalidation for the table in irreversible metastore operation droppedTable.ifPresent(tableInvalidationCallback::invalidate); } })); } private void prepareAlterTable(HdfsContext hdfsContext, String queryId, TableAndMore tableAndMore) { deleteOnly = false; Table table = tableAndMore.getTable(); String targetLocation = table.getStorage().getLocation(); Table oldTable = delegate.getTable(table.getDatabaseName(), table.getTableName()) .orElseThrow(() -> new TrinoException(TRANSACTION_CONFLICT, "The table that this transaction modified was deleted in another transaction. " + table.getSchemaTableName())); String oldTableLocation = oldTable.getStorage().getLocation(); Path oldTablePath = new Path(oldTableLocation); tablesToInvalidate.add(oldTable); cleanExtraOutputFiles(hdfsContext, queryId, tableAndMore); // Location of the old table and the new table can be different because we allow arbitrary directories through LocationService. // If the location of the old table is the same as the location of the new table: // * Rename the old data directory to a temporary path with a special suffix // * Remember we will need to delete that directory at the end if transaction successfully commits // * Remember we will need to undo the rename if transaction aborts // Otherwise, // * Remember we will need to delete the location of the old partition at the end if transaction successfully commits if (targetLocation.equals(oldTableLocation)) { Path oldTableStagingPath = new Path(oldTablePath.getParent(), "_temp_" + oldTablePath.getName() + "_" + queryId); renameDirectory( hdfsContext, hdfsEnvironment, oldTablePath, oldTableStagingPath, () -> renameTasksForAbort.add(new DirectoryRenameTask(hdfsContext, oldTableStagingPath, oldTablePath))); if (!skipDeletionForAlter) { deletionTasksForFinish.add(new DirectoryDeletionTask(hdfsContext, oldTableStagingPath)); } } else { if (!skipDeletionForAlter) { deletionTasksForFinish.add(new DirectoryDeletionTask(hdfsContext, oldTablePath)); } } Path currentPath = tableAndMore.getCurrentLocation() .orElseThrow(() -> new IllegalArgumentException("location should be present for alter table")); Path targetPath = new Path(targetLocation); if (!targetPath.equals(currentPath)) { renameDirectory( hdfsContext, hdfsEnvironment, currentPath, targetPath, () -> cleanUpTasksForAbort.add(new DirectoryCleanUpTask(hdfsContext, targetPath, true))); } // Partition alter must happen regardless of whether original and current location is the same // because metadata might change: e.g. storage format, column types, etc alterTableOperations.add(new AlterTableOperation(tableAndMore.getTable(), oldTable, tableAndMore.getPrincipalPrivileges())); updateStatisticsOperations.add(new UpdateStatisticsOperation( table.getSchemaTableName(), Optional.empty(), tableAndMore.getStatisticsUpdate(), false)); } private void prepareAddTable(HdfsContext context, String queryId, TableAndMore tableAndMore) { deleteOnly = false; cleanExtraOutputFiles(context, queryId, tableAndMore); Table table = tableAndMore.getTable(); if (table.getTableType().equals(MANAGED_TABLE.name())) { Optional targetLocation = table.getStorage().getOptionalLocation(); if (targetLocation.isPresent()) { checkArgument(!targetLocation.get().isEmpty(), "target location is empty"); Optional currentPath = tableAndMore.getCurrentLocation(); Path targetPath = new Path(targetLocation.get()); if (table.getPartitionColumns().isEmpty() && currentPath.isPresent()) { // CREATE TABLE AS SELECT unpartitioned table if (targetPath.equals(currentPath.get())) { // Target path and current path are the same. Therefore, directory move is not needed. } else { renameDirectory( context, hdfsEnvironment, currentPath.get(), targetPath, () -> cleanUpTasksForAbort.add(new DirectoryCleanUpTask(context, targetPath, true))); } } else { // CREATE TABLE AS SELECT partitioned table, or // CREATE TABLE partitioned/unpartitioned table (without data) if (pathExists(context, hdfsEnvironment, targetPath)) { if (currentPath.isPresent() && currentPath.get().equals(targetPath)) { // It is okay to skip directory creation when currentPath is equal to targetPath // because the directory may have been created when creating partition directories. // However, it is important to note that the two being equal does not guarantee // a directory had been created. } else { throw new TrinoException( HIVE_PATH_ALREADY_EXISTS, format("Unable to create directory %s: target directory already exists", targetPath)); } } else { cleanUpTasksForAbort.add(new DirectoryCleanUpTask(context, targetPath, true)); createDirectory(context, hdfsEnvironment, targetPath); } } } // if targetLocation is not set in table we assume table directory is created by HMS } addTableOperations.add(new CreateTableOperation(table, tableAndMore.getPrincipalPrivileges(), tableAndMore.isIgnoreExisting(), tableAndMore.getStatisticsUpdate())); } private void prepareInsertExistingTable(HdfsContext context, String queryId, TableAndMore tableAndMore) { deleteOnly = false; Table table = tableAndMore.getTable(); Path targetPath = new Path(table.getStorage().getLocation()); tablesToInvalidate.add(table); Path currentPath = tableAndMore.getCurrentLocation().orElseThrow(); cleanUpTasksForAbort.add(new DirectoryCleanUpTask(context, targetPath, false)); if (!targetPath.equals(currentPath)) { // if staging directory is used we cherry-pick files to be moved asyncRename(hdfsEnvironment, fileSystemExecutor, fileSystemOperationsCancelled, fileSystemOperationFutures, context, currentPath, targetPath, tableAndMore.getFileNames().orElseThrow()); } else { // if we inserted directly into table directory we need to remove extra output files which should not be part of the table cleanExtraOutputFiles(context, queryId, tableAndMore); } updateStatisticsOperations.add(new UpdateStatisticsOperation( table.getSchemaTableName(), Optional.empty(), tableAndMore.getStatisticsUpdate(), true)); if (isAcidTransactionRunning()) { AcidTransaction transaction = getCurrentAcidTransaction(); updateTableWriteId(table.getDatabaseName(), table.getTableName(), transaction.getAcidTransactionId(), transaction.getWriteId(), OptionalLong.empty()); } } private void prepareMergeExistingTable(HdfsContext context, TableAndMore tableAndMore) { checkArgument(currentHiveTransaction.isPresent(), "currentHiveTransaction isn't present"); AcidTransaction transaction = currentHiveTransaction.get().getTransaction(); checkArgument(transaction.isMerge(), "transaction should be merge, but is %s", transaction); deleteOnly = false; Table table = tableAndMore.getTable(); Path targetPath = new Path(table.getStorage().getLocation()); Path currentPath = tableAndMore.getCurrentLocation().get(); cleanUpTasksForAbort.add(new DirectoryCleanUpTask(context, targetPath, false)); if (!targetPath.equals(currentPath)) { asyncRename(hdfsEnvironment, fileSystemExecutor, fileSystemOperationsCancelled, fileSystemOperationFutures, context, currentPath, targetPath, tableAndMore.getFileNames().get()); } updateStatisticsOperations.add(new UpdateStatisticsOperation( table.getSchemaTableName(), Optional.empty(), tableAndMore.getStatisticsUpdate(), true)); updateTableWriteId(table.getDatabaseName(), table.getTableName(), transaction.getAcidTransactionId(), transaction.getWriteId(), OptionalLong.empty()); } private void prepareDropPartition(SchemaTableName schemaTableName, List partitionValues, boolean deleteData) { metastoreDeleteOperations.add(new IrreversibleMetastoreOperation( format("drop partition %s.%s %s", schemaTableName.getSchemaName(), schemaTableName.getTableName(), partitionValues), () -> { Optional droppedPartition = delegate.getPartition(schemaTableName.getSchemaName(), schemaTableName.getTableName(), partitionValues); try { delegate.dropPartition(schemaTableName.getSchemaName(), schemaTableName.getTableName(), partitionValues, deleteData); } finally { // perform explicit invalidation for the partition in irreversible metastore operation droppedPartition.ifPresent(tableInvalidationCallback::invalidate); } })); } private void prepareAlterPartition(HdfsContext hdfsContext, String queryId, PartitionAndMore partitionAndMore) { deleteOnly = false; Partition partition = partitionAndMore.getPartition(); partitionsToInvalidate.add(partition); String targetLocation = partition.getStorage().getLocation(); Partition oldPartition = delegate.getPartition(partition.getDatabaseName(), partition.getTableName(), partition.getValues()) .orElseThrow(() -> new TrinoException( TRANSACTION_CONFLICT, format("The partition that this transaction modified was deleted in another transaction. %s %s", partition.getTableName(), partition.getValues()))); String partitionName = getPartitionName(partition.getDatabaseName(), partition.getTableName(), partition.getValues()); PartitionStatistics oldPartitionStatistics = getExistingPartitionStatistics(partition, partitionName); String oldPartitionLocation = oldPartition.getStorage().getLocation(); Path oldPartitionPath = new Path(oldPartitionLocation); cleanExtraOutputFiles(hdfsContext, queryId, partitionAndMore); // Location of the old partition and the new partition can be different because we allow arbitrary directories through LocationService. // If the location of the old partition is the same as the location of the new partition: // * Rename the old data directory to a temporary path with a special suffix // * Remember we will need to delete that directory at the end if transaction successfully commits // * Remember we will need to undo the rename if transaction aborts // Otherwise, // * Remember we will need to delete the location of the old partition at the end if transaction successfully commits if (targetLocation.equals(oldPartitionLocation)) { Path oldPartitionStagingPath = new Path(oldPartitionPath.getParent(), "_temp_" + oldPartitionPath.getName() + "_" + queryId); renameDirectory( hdfsContext, hdfsEnvironment, oldPartitionPath, oldPartitionStagingPath, () -> renameTasksForAbort.add(new DirectoryRenameTask(hdfsContext, oldPartitionStagingPath, oldPartitionPath))); if (!skipDeletionForAlter) { deletionTasksForFinish.add(new DirectoryDeletionTask(hdfsContext, oldPartitionStagingPath)); } } else { if (!skipDeletionForAlter) { deletionTasksForFinish.add(new DirectoryDeletionTask(hdfsContext, oldPartitionPath)); } } Path currentPath = partitionAndMore.getCurrentLocation(); Path targetPath = new Path(targetLocation); if (!targetPath.equals(currentPath)) { renameDirectory( hdfsContext, hdfsEnvironment, currentPath, targetPath, () -> cleanUpTasksForAbort.add(new DirectoryCleanUpTask(hdfsContext, targetPath, true))); } // Partition alter must happen regardless of whether original and current location is the same // because metadata might change: e.g. storage format, column types, etc alterPartitionOperations.add(new AlterPartitionOperation( new PartitionWithStatistics(partition, partitionName, partitionAndMore.getStatisticsUpdate()), new PartitionWithStatistics(oldPartition, partitionName, oldPartitionStatistics))); } private void cleanExtraOutputFiles(HdfsContext hdfsContext, String queryId, PartitionAndMore partitionAndMore) { if (!partitionAndMore.isCleanExtraOutputFilesOnCommit()) { return; } verify(partitionAndMore.hasFileNames(), "fileNames expected to be set if isCleanExtraOutputFilesOnCommit is true"); SemiTransactionalHiveMetastore.cleanExtraOutputFiles(hdfsEnvironment, hdfsContext, queryId, partitionAndMore.getCurrentLocation(), ImmutableSet.copyOf(partitionAndMore.getFileNames())); } private void cleanExtraOutputFiles(HdfsContext hdfsContext, String queryId, TableAndMore tableAndMore) { if (!tableAndMore.isCleanExtraOutputFilesOnCommit()) { return; } Path tableLocation = tableAndMore.getCurrentLocation().orElseThrow(() -> new IllegalArgumentException("currentLocation expected to be set if isCleanExtraOutputFilesOnCommit is true")); List files = tableAndMore.getFileNames().orElseThrow(() -> new IllegalArgumentException("fileNames expected to be set if isCleanExtraOutputFilesOnCommit is true")); SemiTransactionalHiveMetastore.cleanExtraOutputFiles(hdfsEnvironment, hdfsContext, queryId, tableLocation, ImmutableSet.copyOf(files)); } private PartitionStatistics getExistingPartitionStatistics(Partition partition, String partitionName) { try { PartitionStatistics statistics = delegate.getPartitionStatistics(partition.getDatabaseName(), partition.getTableName(), ImmutableSet.of(partitionName)) .get(partitionName); if (statistics == null) { throw new TrinoException( TRANSACTION_CONFLICT, format("The partition that this transaction modified was deleted in another transaction. %s %s", partition.getTableName(), partition.getValues())); } return statistics; } catch (TrinoException e) { if (e.getErrorCode().equals(HIVE_CORRUPTED_COLUMN_STATISTICS.toErrorCode())) { log.warn( e, "Corrupted statistics found when altering partition. Table: %s.%s. Partition: %s", partition.getDatabaseName(), partition.getTableName(), partition.getValues()); return PartitionStatistics.empty(); } throw e; } } private void prepareAddPartition(HdfsContext hdfsContext, String queryId, PartitionAndMore partitionAndMore) { deleteOnly = false; Partition partition = partitionAndMore.getPartition(); String targetLocation = partition.getStorage().getLocation(); Path currentPath = partitionAndMore.getCurrentLocation(); Path targetPath = new Path(targetLocation); cleanExtraOutputFiles(hdfsContext, queryId, partitionAndMore); PartitionAdder partitionAdder = partitionAdders.computeIfAbsent( partition.getSchemaTableName(), ignored -> new PartitionAdder(partition.getDatabaseName(), partition.getTableName(), delegate, PARTITION_COMMIT_BATCH_SIZE)); fileSystemOperationFutures.add(CompletableFuture.runAsync(() -> { if (fileSystemOperationsCancelled.get()) { return; } if (pathExists(hdfsContext, hdfsEnvironment, currentPath)) { if (!targetPath.equals(currentPath)) { renameDirectory( hdfsContext, hdfsEnvironment, currentPath, targetPath, () -> cleanUpTasksForAbort.add(new DirectoryCleanUpTask(hdfsContext, targetPath, true))); } } else { cleanUpTasksForAbort.add(new DirectoryCleanUpTask(hdfsContext, targetPath, true)); createDirectory(hdfsContext, hdfsEnvironment, targetPath); } }, fileSystemExecutor)); String partitionName = getPartitionName(partition.getDatabaseName(), partition.getTableName(), partition.getValues()); partitionAdder.addPartition(new PartitionWithStatistics(partition, partitionName, partitionAndMore.getStatisticsUpdate())); } private void prepareInsertExistingPartition(HdfsContext hdfsContext, String queryId, PartitionAndMore partitionAndMore) { deleteOnly = false; Partition partition = partitionAndMore.getPartition(); partitionsToInvalidate.add(partition); Path targetPath = new Path(partition.getStorage().getLocation()); Path currentPath = partitionAndMore.getCurrentLocation(); cleanUpTasksForAbort.add(new DirectoryCleanUpTask(hdfsContext, targetPath, false)); if (!targetPath.equals(currentPath)) { // if staging directory is used we cherry-pick files to be moved asyncRename(hdfsEnvironment, fileSystemExecutor, fileSystemOperationsCancelled, fileSystemOperationFutures, hdfsContext, currentPath, targetPath, partitionAndMore.getFileNames()); } else { // if we inserted directly into partition directory we need to remove extra output files which should not be part of the table cleanExtraOutputFiles(hdfsContext, queryId, partitionAndMore); } updateStatisticsOperations.add(new UpdateStatisticsOperation( partition.getSchemaTableName(), Optional.of(getPartitionName(partition.getDatabaseName(), partition.getTableName(), partition.getValues())), partitionAndMore.getStatisticsUpdate(), true)); } private void executeCleanupTasksForAbort(Collection declaredIntentionsToWrite) { Set queryIds = declaredIntentionsToWrite.stream() .map(DeclaredIntentionToWrite::getQueryId) .collect(toImmutableSet()); for (DirectoryCleanUpTask cleanUpTask : cleanUpTasksForAbort) { recursiveDeleteFilesAndLog(cleanUpTask.getContext(), cleanUpTask.getPath(), queryIds, cleanUpTask.isDeleteEmptyDirectory(), "temporary directory commit abort"); } } private void executeDeletionTasksForFinish() { for (DirectoryDeletionTask deletionTask : deletionTasksForFinish) { if (!deleteRecursivelyIfExists(deletionTask.getContext(), hdfsEnvironment, deletionTask.getPath())) { logCleanupFailure("Error deleting directory %s", deletionTask.getPath()); } } } private void executeRenameTasksForAbort() { for (DirectoryRenameTask directoryRenameTask : renameTasksForAbort) { try { // Ignore the task if the source directory doesn't exist. // This is probably because the original rename that we are trying to undo here never succeeded. if (pathExists(directoryRenameTask.getContext(), hdfsEnvironment, directoryRenameTask.getRenameFrom())) { renameDirectory(directoryRenameTask.getContext(), hdfsEnvironment, directoryRenameTask.getRenameFrom(), directoryRenameTask.getRenameTo(), () -> {}); } } catch (Throwable throwable) { logCleanupFailure(throwable, "failed to undo rename of partition directory: %s to %s", directoryRenameTask.getRenameFrom(), directoryRenameTask.getRenameTo()); } } } private void pruneAndDeleteStagingDirectories(List declaredIntentionsToWrite) { for (DeclaredIntentionToWrite declaredIntentionToWrite : declaredIntentionsToWrite) { if (declaredIntentionToWrite.getMode() != WriteMode.STAGE_AND_MOVE_TO_TARGET_DIRECTORY) { continue; } Set queryIds = declaredIntentionsToWrite.stream() .map(DeclaredIntentionToWrite::getQueryId) .collect(toImmutableSet()); Path path = declaredIntentionToWrite.getRootPath(); recursiveDeleteFilesAndLog(declaredIntentionToWrite.getHdfsContext(), path, queryIds, true, "staging directory cleanup"); } } private void waitForAsyncFileSystemOperations() { for (CompletableFuture future : fileSystemOperationFutures) { getFutureValue(future, TrinoException.class); } } private void waitForAsyncFileSystemOperationSuppressThrowable() { for (CompletableFuture future : fileSystemOperationFutures) { try { future.get(); } catch (InterruptedException e) { Thread.currentThread().interrupt(); } catch (Throwable t) { // ignore } } } private void cancelUnstartedAsyncFileSystemOperations() { fileSystemOperationsCancelled.set(true); } private void executeAddTableOperations(AcidTransaction transaction) { for (CreateTableOperation addTableOperation : addTableOperations) { addTableOperation.run(delegate, transaction); } } private void executeAlterTableOperations() { for (AlterTableOperation alterTableOperation : alterTableOperations) { alterTableOperation.run(delegate, transaction); } } private void executeAlterPartitionOperations() { for (AlterPartitionOperation alterPartitionOperation : alterPartitionOperations) { alterPartitionOperation.run(delegate); } } private void executeAddPartitionOperations(AcidTransaction transaction) { for (PartitionAdder partitionAdder : partitionAdders.values()) { partitionAdder.execute(transaction); } } private void executeUpdateStatisticsOperations(AcidTransaction transaction) { ImmutableList.Builder> executeUpdateFutures = ImmutableList.builder(); List failedUpdateStatisticsOperationDescriptions = new ArrayList<>(); List suppressedExceptions = new ArrayList<>(); for (UpdateStatisticsOperation operation : updateStatisticsOperations) { executeUpdateFutures.add(CompletableFuture.runAsync(() -> { try { operation.run(delegate, transaction); } catch (Throwable t) { synchronized (failedUpdateStatisticsOperationDescriptions) { addSuppressedExceptions(suppressedExceptions, t, failedUpdateStatisticsOperationDescriptions, operation.getDescription()); } } }, updateExecutor)); } for (CompletableFuture executeUpdateFuture : executeUpdateFutures.build()) { getFutureValue(executeUpdateFuture); } if (!suppressedExceptions.isEmpty()) { StringBuilder message = new StringBuilder(); message.append("All operations other than the following update operations were completed: "); Joiner.on("; ").appendTo(message, failedUpdateStatisticsOperationDescriptions); TrinoException trinoException = new TrinoException(HIVE_METASTORE_ERROR, message.toString()); suppressedExceptions.forEach(trinoException::addSuppressed); throw trinoException; } } private void executeTableInvalidationCallback() { tablesToInvalidate.forEach(tableInvalidationCallback::invalidate); partitionsToInvalidate.forEach(tableInvalidationCallback::invalidate); } private void undoAddPartitionOperations() { for (PartitionAdder partitionAdder : partitionAdders.values()) { List> partitionsFailedToRollback = partitionAdder.rollback(); if (!partitionsFailedToRollback.isEmpty()) { logCleanupFailure("Failed to rollback: add_partition for partitions %s.%s %s", partitionAdder.getSchemaName(), partitionAdder.getTableName(), partitionsFailedToRollback); } } } private void undoAddTableOperations() { for (CreateTableOperation addTableOperation : addTableOperations) { try { addTableOperation.undo(delegate); } catch (Throwable throwable) { logCleanupFailure(throwable, "failed to rollback: %s", addTableOperation.getDescription()); } } } private void undoAlterTableOperations() { for (AlterTableOperation alterTableOperation : alterTableOperations) { try { alterTableOperation.undo(delegate, transaction); } catch (Throwable throwable) { logCleanupFailure(throwable, "failed to rollback: %s", alterTableOperation.getDescription()); } } } private void undoAlterPartitionOperations() { for (AlterPartitionOperation alterPartitionOperation : alterPartitionOperations) { try { alterPartitionOperation.undo(delegate); } catch (Throwable throwable) { logCleanupFailure(throwable, "failed to rollback: %s", alterPartitionOperation.getDescription()); } } } private void undoUpdateStatisticsOperations(AcidTransaction transaction) { ImmutableList.Builder> undoUpdateFutures = ImmutableList.builder(); for (UpdateStatisticsOperation operation : updateStatisticsOperations) { undoUpdateFutures.add(CompletableFuture.runAsync(() -> { try { operation.undo(delegate, transaction); } catch (Throwable throwable) { logCleanupFailure(throwable, "failed to rollback: %s", operation.getDescription()); } }, updateExecutor)); } for (CompletableFuture undoUpdateFuture : undoUpdateFutures.build()) { getFutureValue(undoUpdateFuture); } } private void executeIrreversibleMetastoreOperations() { List failedIrreversibleOperationDescriptions = new ArrayList<>(); List suppressedExceptions = new ArrayList<>(); AtomicBoolean anySucceeded = new AtomicBoolean(false); ImmutableList.Builder> dropFutures = ImmutableList.builder(); for (IrreversibleMetastoreOperation irreversibleMetastoreOperation : metastoreDeleteOperations) { dropFutures.add(CompletableFuture.runAsync(() -> { try { irreversibleMetastoreOperation.run(); anySucceeded.set(true); } catch (Throwable t) { synchronized (failedIrreversibleOperationDescriptions) { addSuppressedExceptions(suppressedExceptions, t, failedIrreversibleOperationDescriptions, irreversibleMetastoreOperation.getDescription()); } } }, dropExecutor)); } for (CompletableFuture dropFuture : dropFutures.build()) { // none of the futures should fail because all exceptions are being handled explicitly getFutureValue(dropFuture); } if (!suppressedExceptions.isEmpty()) { StringBuilder message = new StringBuilder(); if (deleteOnly && !anySucceeded.get()) { message.append("The following metastore delete operations failed: "); } else { message.append("The transaction didn't commit cleanly. All operations other than the following delete operations were completed: "); } Joiner.on("; ").appendTo(message, failedIrreversibleOperationDescriptions); TrinoException trinoException = new TrinoException(HIVE_METASTORE_ERROR, message.toString()); suppressedExceptions.forEach(trinoException::addSuppressed); throw trinoException; } } } @GuardedBy("this") private void rollbackShared() { checkHoldsLock(); for (DeclaredIntentionToWrite declaredIntentionToWrite : declaredIntentionsToWrite) { switch (declaredIntentionToWrite.getMode()) { case STAGE_AND_MOVE_TO_TARGET_DIRECTORY: case DIRECT_TO_TARGET_NEW_DIRECTORY: // For STAGE_AND_MOVE_TO_TARGET_DIRECTORY, there is no need to cleanup the target directory as // it will only be written to during the commit call and the commit call cleans up after failures. if ((declaredIntentionToWrite.getMode() == DIRECT_TO_TARGET_NEW_DIRECTORY) && skipTargetCleanupOnRollback) { break; } Path rootPath = declaredIntentionToWrite.getRootPath(); // In the case of DIRECT_TO_TARGET_NEW_DIRECTORY, if the directory is not guaranteed to be unique // for the query, it is possible that another query or compute engine may see the directory, wrote // data to it, and exported it through metastore. Therefore it may be argued that cleanup of staging // directories must be carried out conservatively. To be safe, we only delete files that start or // end with the query IDs in this transaction. recursiveDeleteFilesAndLog( declaredIntentionToWrite.getHdfsContext(), rootPath, ImmutableSet.of(declaredIntentionToWrite.getQueryId()), true, format("staging/target_new directory rollback for table %s", declaredIntentionToWrite.getSchemaTableName())); break; case DIRECT_TO_TARGET_EXISTING_DIRECTORY: Set pathsToClean = new HashSet<>(); // Check the base directory of the declared intention // * existing partition may also be in this directory // * this is where new partitions are created Path baseDirectory = declaredIntentionToWrite.getRootPath(); pathsToClean.add(baseDirectory); SchemaTableName schemaTableName = declaredIntentionToWrite.getSchemaTableName(); Optional
table = delegate.getTable(schemaTableName.getSchemaName(), schemaTableName.getTableName()); if (table.isPresent()) { // check every existing partition that is outside for the base directory List partitionColumns = table.get().getPartitionColumns(); if (!partitionColumns.isEmpty()) { List partitionColumnNames = partitionColumns.stream() .map(Column::getName) .collect(toImmutableList()); List partitionNames = delegate.getPartitionNamesByFilter( schemaTableName.getSchemaName(), schemaTableName.getTableName(), partitionColumnNames, TupleDomain.all()) .orElse(ImmutableList.of()); for (List partitionNameBatch : Iterables.partition(partitionNames, 10)) { Collection> partitions = delegate.getPartitionsByNames(schemaTableName.getSchemaName(), schemaTableName.getTableName(), partitionNameBatch).values(); partitions.stream() .filter(Optional::isPresent) .map(Optional::get) .map(partition -> partition.getStorage().getLocation()) .map(Path::new) .filter(path -> !isSameOrParent(baseDirectory, path)) .forEach(pathsToClean::add); } } } else { logCleanupFailure( "Error rolling back write to table %s.%s. Data directory may contain temporary data. Table was dropped in another transaction.", schemaTableName.getSchemaName(), schemaTableName.getTableName()); } // delete any file that starts or ends with the query ID for (Path path : pathsToClean) { // TODO: It is a known deficiency that some empty directory does not get cleaned up in S3. // We cannot delete any of the directories here since we do not know who created them. recursiveDeleteFilesAndLog( declaredIntentionToWrite.getHdfsContext(), path, ImmutableSet.of(declaredIntentionToWrite.getQueryId()), false, format("target_existing directory rollback for table %s", schemaTableName)); } break; default: throw new UnsupportedOperationException("Unknown write mode"); } } } @VisibleForTesting public synchronized void testOnlyCheckIsReadOnly() { if (state != State.EMPTY) { throw new AssertionError("Test did not commit or rollback"); } } @VisibleForTesting public void testOnlyThrowOnCleanupFailures() { throwOnCleanupFailure = true; } @GuardedBy("this") private void checkReadable() { checkHoldsLock(); switch (state) { case EMPTY: case SHARED_OPERATION_BUFFERED: return; case EXCLUSIVE_OPERATION_BUFFERED: throw new TrinoException(NOT_SUPPORTED, "Unsupported combination of operations in a single transaction"); case FINISHED: throw new IllegalStateException("Tried to access metastore after transaction has been committed/aborted"); } } @GuardedBy("this") private void setShared() { checkHoldsLock(); checkReadable(); state = State.SHARED_OPERATION_BUFFERED; } @GuardedBy("this") private void setExclusive(ExclusiveOperation exclusiveOperation) { checkHoldsLock(); if (state != State.EMPTY) { throw new TrinoException(NOT_SUPPORTED, "Unsupported combination of operations in a single transaction"); } state = State.EXCLUSIVE_OPERATION_BUFFERED; bufferedExclusiveOperation = exclusiveOperation; } @GuardedBy("this") private void checkNoPartitionAction(String databaseName, String tableName) { checkHoldsLock(); Map, Action> partitionActionsOfTable = partitionActions.get(new SchemaTableName(databaseName, tableName)); if (partitionActionsOfTable != null && !partitionActionsOfTable.isEmpty()) { throw new TrinoException(NOT_SUPPORTED, "Cannot make schema changes to a table/view with modified partitions in the same transaction"); } } private static boolean isSameOrParent(Path parent, Path child) { int parentDepth = parent.depth(); int childDepth = child.depth(); if (parentDepth > childDepth) { return false; } for (int i = childDepth; i > parentDepth; i--) { child = child.getParent(); } return parent.equals(child); } @FormatMethod private void logCleanupFailure(String format, Object... args) { if (throwOnCleanupFailure) { throw new RuntimeException(format(format, args)); } log.warn(format, args); } @FormatMethod private void logCleanupFailure(Throwable t, String format, Object... args) { if (throwOnCleanupFailure) { throw new RuntimeException(format(format, args), t); } log.warn(t, format, args); } private static void addSuppressedExceptions(List suppressedExceptions, Throwable t, List descriptions, String description) { descriptions.add(description); // A limit is needed to avoid having a huge exception object. 5 was chosen arbitrarily. if (suppressedExceptions.size() < 5) { suppressedExceptions.add(t); } } private static void asyncRename( HdfsEnvironment hdfsEnvironment, Executor executor, AtomicBoolean cancelled, List> fileRenameFutures, HdfsContext context, Path currentPath, Path targetPath, List fileNames) { FileSystem fileSystem; try { fileSystem = hdfsEnvironment.getFileSystem(context, currentPath); } catch (IOException e) { throw new TrinoException(HIVE_FILESYSTEM_ERROR, format("Error moving data files to final location. Error listing directory %s", currentPath), e); } for (String fileName : fileNames) { Path source = new Path(currentPath, fileName); Path target = new Path(targetPath, fileName); fileRenameFutures.add(CompletableFuture.runAsync(() -> { if (cancelled.get()) { return; } try { if (fileSystem.exists(target)) { throw new TrinoException(HIVE_FILESYSTEM_ERROR, format("Error moving data files from %s to final location %s: target location already exists", source, target)); } if (!fileSystem.rename(source, target)) { throw new TrinoException(HIVE_FILESYSTEM_ERROR, format("Error moving data files from %s to final location %s: rename not successful", source, target)); } } catch (IOException e) { throw new TrinoException(HIVE_FILESYSTEM_ERROR, format("Error moving data files from %s to final location %s", source, target), e); } }, executor)); } } private void recursiveDeleteFilesAndLog(HdfsContext context, Path directory, Set queryIds, boolean deleteEmptyDirectories, String reason) { RecursiveDeleteResult recursiveDeleteResult = recursiveDeleteFiles( hdfsEnvironment, context, directory, queryIds, deleteEmptyDirectories); if (!recursiveDeleteResult.getNotDeletedEligibleItems().isEmpty()) { logCleanupFailure( "Error deleting directory %s for %s. Some eligible items cannot be deleted: %s.", directory.toString(), reason, recursiveDeleteResult.getNotDeletedEligibleItems()); } else if (deleteEmptyDirectories && !recursiveDeleteResult.isDirectoryNoLongerExists()) { logCleanupFailure( "Error deleting directory %s for %s. Cannot delete the directory.", directory.toString(), reason); } } /** * Attempt to recursively remove eligible files and/or directories in {@code directory}. *

* When {@code queryIds} is not present, all files (but not necessarily directories) will be * ineligible. If all files shall be deleted, you can use an empty string as {@code queryIds}. *

* When {@code deleteEmptySubDirectory} is true, any empty directory (including directories that * were originally empty, and directories that become empty after files prefixed or suffixed with * {@code queryIds} are deleted) will be eligible. *

* This method will not delete anything that's neither a directory nor a file. * * @param queryIds prefix or suffix of files that should be deleted * @param deleteEmptyDirectories whether empty directories should be deleted */ private static RecursiveDeleteResult recursiveDeleteFiles(HdfsEnvironment hdfsEnvironment, HdfsContext context, Path directory, Set queryIds, boolean deleteEmptyDirectories) { FileSystem fileSystem; try { fileSystem = hdfsEnvironment.getFileSystem(context, directory); if (!fileSystem.exists(directory)) { return new RecursiveDeleteResult(true, ImmutableList.of()); } } catch (IOException e) { ImmutableList.Builder notDeletedItems = ImmutableList.builder(); notDeletedItems.add(directory.toString() + "/**"); return new RecursiveDeleteResult(false, notDeletedItems.build()); } return doRecursiveDeleteFiles(fileSystem, directory, queryIds, deleteEmptyDirectories); } private static RecursiveDeleteResult doRecursiveDeleteFiles(FileSystem fileSystem, Path directory, Set queryIds, boolean deleteEmptyDirectories) { // don't delete hidden Trino directories use by FileHiveMetastore if (directory.getName().startsWith(".trino")) { return new RecursiveDeleteResult(false, ImmutableList.of()); } FileStatus[] allFiles; try { allFiles = fileSystem.listStatus(directory); } catch (IOException e) { ImmutableList.Builder notDeletedItems = ImmutableList.builder(); notDeletedItems.add(directory + "/**"); return new RecursiveDeleteResult(false, notDeletedItems.build()); } boolean allDescendentsDeleted = true; ImmutableList.Builder notDeletedEligibleItems = ImmutableList.builder(); for (FileStatus fileStatus : allFiles) { if (fileStatus.isFile()) { Path filePath = fileStatus.getPath(); String fileName = filePath.getName(); boolean eligible = false; // don't delete hidden Trino directories use by FileHiveMetastore if (!fileName.startsWith(".trino")) { eligible = queryIds.stream().anyMatch(id -> isFileCreatedByQuery(fileName, id)); } if (eligible) { if (!deleteIfExists(fileSystem, filePath, false)) { allDescendentsDeleted = false; notDeletedEligibleItems.add(filePath.toString()); } } else { allDescendentsDeleted = false; } } else if (fileStatus.isDirectory()) { RecursiveDeleteResult subResult = doRecursiveDeleteFiles(fileSystem, fileStatus.getPath(), queryIds, deleteEmptyDirectories); if (!subResult.isDirectoryNoLongerExists()) { allDescendentsDeleted = false; } if (!subResult.getNotDeletedEligibleItems().isEmpty()) { notDeletedEligibleItems.addAll(subResult.getNotDeletedEligibleItems()); } } else { allDescendentsDeleted = false; notDeletedEligibleItems.add(fileStatus.getPath().toString()); } } // Unconditionally delete empty delta_ and delete_delta_ directories, because that's // what Hive does, and leaving them in place confuses delta file readers. if (allDescendentsDeleted && (deleteEmptyDirectories || DELTA_DIRECTORY_MATCHER.matcher(directory.getName()).matches())) { verify(notDeletedEligibleItems.build().isEmpty()); if (!deleteIfExists(fileSystem, directory, false)) { return new RecursiveDeleteResult(false, ImmutableList.of(directory + "/")); } return new RecursiveDeleteResult(true, ImmutableList.of()); } return new RecursiveDeleteResult(false, notDeletedEligibleItems.build()); } /** * Attempts to remove the file or empty directory. * * @return true if the location no longer exists */ private static boolean deleteIfExists(FileSystem fileSystem, Path path, boolean recursive) { try { // attempt to delete the path if (fileSystem.delete(path, recursive)) { return true; } // delete failed // check if path still exists return !fileSystem.exists(path); } catch (FileNotFoundException ignored) { // path was already removed or never existed return true; } catch (IOException ignored) { } return false; } /** * Attempts to remove the file or empty directory. * * @return true if the location no longer exists */ private static boolean deleteRecursivelyIfExists(HdfsContext context, HdfsEnvironment hdfsEnvironment, Path path) { FileSystem fileSystem; try { fileSystem = hdfsEnvironment.getFileSystem(context, path); } catch (IOException ignored) { return false; } return deleteIfExists(fileSystem, path, true); } private static void renameDirectory(HdfsContext context, HdfsEnvironment hdfsEnvironment, Path source, Path target, Runnable runWhenPathDoesntExist) { if (pathExists(context, hdfsEnvironment, target)) { throw new TrinoException(HIVE_PATH_ALREADY_EXISTS, format("Unable to rename from %s to %s: target directory already exists", source, target)); } if (!pathExists(context, hdfsEnvironment, target.getParent())) { createDirectory(context, hdfsEnvironment, target.getParent()); } // The runnable will assume that if rename fails, it will be okay to delete the directory (if the directory is empty). // This is not technically true because a race condition still exists. runWhenPathDoesntExist.run(); try { if (!hdfsEnvironment.getFileSystem(context, source).rename(source, target)) { throw new TrinoException(HIVE_FILESYSTEM_ERROR, format("Failed to rename %s to %s: rename returned false", source, target)); } } catch (IOException e) { throw new TrinoException(HIVE_FILESYSTEM_ERROR, format("Failed to rename %s to %s", source, target), e); } } private static Optional getQueryId(Database database) { return Optional.ofNullable(database.getParameters().get(PRESTO_QUERY_ID_NAME)); } private static Optional getQueryId(Table table) { return Optional.ofNullable(table.getParameters().get(PRESTO_QUERY_ID_NAME)); } private static Optional getQueryId(Partition partition) { return Optional.ofNullable(partition.getParameters().get(PRESTO_QUERY_ID_NAME)); } private void checkHoldsLock() { // This method serves a similar purpose at runtime as GuardedBy on method serves during static analysis. // This method should not have significant performance impact. If it does, it may be reasonably to remove this method. // This intentionally does not use checkState. if (!Thread.holdsLock(this)) { throw new IllegalStateException(format("Thread must hold a lock on the %s", getClass().getSimpleName())); } } private enum State { EMPTY, SHARED_OPERATION_BUFFERED, EXCLUSIVE_OPERATION_BUFFERED, FINISHED, } private enum ActionType { DROP, DROP_PRESERVE_DATA, ADD, ALTER, INSERT_EXISTING, MERGE, } private enum TableSource { CREATED_IN_THIS_TRANSACTION, PRE_EXISTING_TABLE, // RECREATED_IN_THIS_TRANSACTION is a possible case, but it is not supported with the current implementation } public static class Action { private final ActionType type; private final T data; private final HdfsContext hdfsContext; private final String queryId; public Action(ActionType type, T data, HdfsContext hdfsContext, String queryId) { this.type = requireNonNull(type, "type is null"); if (type == ActionType.DROP || type == ActionType.DROP_PRESERVE_DATA) { checkArgument(data == null, "data is not null"); } else { requireNonNull(data, "data is null"); } this.data = data; this.hdfsContext = requireNonNull(hdfsContext, "hdfsContext is null"); this.queryId = requireNonNull(queryId, "queryId is null"); } public ActionType getType() { return type; } public T getData() { checkState(type != ActionType.DROP); return data; } public HdfsContext getHdfsContext() { return hdfsContext; } public String getQueryId() { return queryId; } @Override public String toString() { return toStringHelper(this) .add("type", type) .add("queryId", queryId) .add("data", data) .toString(); } } private static class TableAndMore { private final Table table; private final Optional principalPrivileges; private final Optional currentLocation; // unpartitioned table only private final Optional> fileNames; private final boolean ignoreExisting; private final PartitionStatistics statistics; private final PartitionStatistics statisticsUpdate; private final boolean cleanExtraOutputFilesOnCommit; public TableAndMore( Table table, Optional principalPrivileges, Optional currentLocation, Optional> fileNames, boolean ignoreExisting, PartitionStatistics statistics, PartitionStatistics statisticsUpdate, boolean cleanExtraOutputFilesOnCommit) { this.table = requireNonNull(table, "table is null"); this.principalPrivileges = requireNonNull(principalPrivileges, "principalPrivileges is null"); this.currentLocation = requireNonNull(currentLocation, "currentLocation is null"); this.fileNames = requireNonNull(fileNames, "fileNames is null"); this.ignoreExisting = ignoreExisting; this.statistics = requireNonNull(statistics, "statistics is null"); this.statisticsUpdate = requireNonNull(statisticsUpdate, "statisticsUpdate is null"); this.cleanExtraOutputFilesOnCommit = cleanExtraOutputFilesOnCommit; checkArgument(!table.getStorage().getOptionalLocation().orElse("").isEmpty() || currentLocation.isEmpty(), "currentLocation cannot be supplied for table without location"); checkArgument(fileNames.isEmpty() || currentLocation.isPresent(), "fileNames can be supplied only when currentLocation is supplied"); } public boolean isIgnoreExisting() { return ignoreExisting; } public Table getTable() { return table; } public PrincipalPrivileges getPrincipalPrivileges() { checkState(principalPrivileges.isPresent()); return principalPrivileges.get(); } public Optional getCurrentLocation() { return currentLocation; } public Optional> getFileNames() { return fileNames; } public PartitionStatistics getStatistics() { return statistics; } public PartitionStatistics getStatisticsUpdate() { return statisticsUpdate; } public boolean isCleanExtraOutputFilesOnCommit() { return cleanExtraOutputFilesOnCommit; } @Override public String toString() { return toStringHelper(this) .add("table", table) .add("principalPrivileges", principalPrivileges) .add("currentLocation", currentLocation) .add("fileNames", fileNames) .add("ignoreExisting", ignoreExisting) .add("statistics", statistics) .add("statisticsUpdate", statisticsUpdate) .add("cleanExtraOutputFilesOnCommit", cleanExtraOutputFilesOnCommit) .toString(); } } private static class TableAndMergeResults extends TableAndMore { private final List partitionMergeResults; private final List partitions; public TableAndMergeResults(Table table, Optional principalPrivileges, Optional currentLocation, List partitionMergeResults, List partitions) { super(table, principalPrivileges, currentLocation, Optional.empty(), false, PartitionStatistics.empty(), PartitionStatistics.empty(), false); // retries are not supported for transactional tables this.partitionMergeResults = requireNonNull(partitionMergeResults, "partitionMergeResults is null"); this.partitions = requireNonNull(partitions, "partitions is nul"); } public List getPartitions() { return partitions; } @Override public String toString() { return toStringHelper(this) .add("table", getTable()) .add("partitionMergeResults", partitionMergeResults) .add("partitions", partitions) .add("principalPrivileges", getPrincipalPrivileges()) .add("currentLocation", getCurrentLocation()) .toString(); } } private static class PartitionAndMore { private final Partition partition; private final Path currentLocation; private final Optional> fileNames; private final PartitionStatistics statistics; private final PartitionStatistics statisticsUpdate; private final boolean cleanExtraOutputFilesOnCommit; public PartitionAndMore(Partition partition, Path currentLocation, Optional> fileNames, PartitionStatistics statistics, PartitionStatistics statisticsUpdate, boolean cleanExtraOutputFilesOnCommit) { this.partition = requireNonNull(partition, "partition is null"); this.currentLocation = requireNonNull(currentLocation, "currentLocation is null"); this.fileNames = requireNonNull(fileNames, "fileNames is null"); this.statistics = requireNonNull(statistics, "statistics is null"); this.statisticsUpdate = requireNonNull(statisticsUpdate, "statisticsUpdate is null"); this.cleanExtraOutputFilesOnCommit = cleanExtraOutputFilesOnCommit; } public Partition getPartition() { return partition; } public Path getCurrentLocation() { return currentLocation; } public List getFileNames() { checkState(fileNames.isPresent()); return fileNames.get(); } public boolean hasFileNames() { return fileNames.isPresent(); } public PartitionStatistics getStatistics() { return statistics; } public PartitionStatistics getStatisticsUpdate() { return statisticsUpdate; } public boolean isCleanExtraOutputFilesOnCommit() { return cleanExtraOutputFilesOnCommit; } public Partition getAugmentedPartitionForInTransactionRead() { // This method augments the location field of the partition to the staging location. // This way, if the partition is accessed in an ongoing transaction, staged data // can be found and accessed. Partition partition = this.partition; String currentLocation = this.currentLocation.toString(); if (!currentLocation.equals(partition.getStorage().getLocation())) { partition = Partition.builder(partition) .withStorage(storage -> storage.setLocation(currentLocation)) .build(); } return partition; } @Override public String toString() { return toStringHelper(this) .add("partition", partition) .add("currentLocation", currentLocation) .add("fileNames", fileNames) .add("cleanExtraOutputFilesOnCommit", cleanExtraOutputFilesOnCommit) .toString(); } } private static class DeclaredIntentionToWrite { private final String declarationId; private final WriteMode mode; private final HdfsContext hdfsContext; private final String queryId; private final Path rootPath; private final SchemaTableName schemaTableName; public DeclaredIntentionToWrite(String declarationId, WriteMode mode, HdfsContext hdfsContext, String queryId, Path stagingPathRoot, SchemaTableName schemaTableName) { this.declarationId = requireNonNull(declarationId, "declarationId is null"); this.mode = requireNonNull(mode, "mode is null"); this.hdfsContext = requireNonNull(hdfsContext, "hdfsContext is null"); this.queryId = requireNonNull(queryId, "queryId is null"); this.rootPath = requireNonNull(stagingPathRoot, "stagingPathRoot is null"); this.schemaTableName = requireNonNull(schemaTableName, "schemaTableName is null"); } public String getDeclarationId() { return declarationId; } public WriteMode getMode() { return mode; } public HdfsContext getHdfsContext() { return hdfsContext; } public String getQueryId() { return queryId; } public Path getRootPath() { return rootPath; } public SchemaTableName getSchemaTableName() { return schemaTableName; } @Override public String toString() { return toStringHelper(this) .add("mode", mode) .add("hdfsContext", hdfsContext) .add("queryId", queryId) .add("rootPath", rootPath) .add("schemaTableName", schemaTableName) .toString(); } } private static class DirectoryCleanUpTask { private final HdfsContext context; private final Path path; private final boolean deleteEmptyDirectory; public DirectoryCleanUpTask(HdfsContext context, Path path, boolean deleteEmptyDirectory) { this.context = context; this.path = path; this.deleteEmptyDirectory = deleteEmptyDirectory; } public HdfsContext getContext() { return context; } public Path getPath() { return path; } public boolean isDeleteEmptyDirectory() { return deleteEmptyDirectory; } @Override public String toString() { return toStringHelper(this) .add("context", context) .add("path", path) .add("deleteEmptyDirectory", deleteEmptyDirectory) .toString(); } } private static class DirectoryDeletionTask { private final HdfsContext context; private final Path path; public DirectoryDeletionTask(HdfsContext context, Path path) { this.context = context; this.path = path; } public HdfsContext getContext() { return context; } public Path getPath() { return path; } @Override public String toString() { return toStringHelper(this) .add("context", context) .add("path", path) .toString(); } } private static class DirectoryRenameTask { private final HdfsContext context; private final Path renameFrom; private final Path renameTo; public DirectoryRenameTask(HdfsContext context, Path renameFrom, Path renameTo) { this.context = requireNonNull(context, "context is null"); this.renameFrom = requireNonNull(renameFrom, "renameFrom is null"); this.renameTo = requireNonNull(renameTo, "renameTo is null"); } public HdfsContext getContext() { return context; } public Path getRenameFrom() { return renameFrom; } public Path getRenameTo() { return renameTo; } @Override public String toString() { return toStringHelper(this) .add("context", context) .add("renameFrom", renameFrom) .add("renameTo", renameTo) .toString(); } } private static class IrreversibleMetastoreOperation { private final String description; private final Runnable action; public IrreversibleMetastoreOperation(String description, Runnable action) { this.description = requireNonNull(description, "description is null"); this.action = requireNonNull(action, "action is null"); } public String getDescription() { return description; } public void run() { action.run(); } } private static class CreateTableOperation { private final Table newTable; private final PrincipalPrivileges privileges; private boolean tableCreated; private final boolean ignoreExisting; private final PartitionStatistics statistics; private final String queryId; public CreateTableOperation(Table newTable, PrincipalPrivileges privileges, boolean ignoreExisting, PartitionStatistics statistics) { requireNonNull(newTable, "newTable is null"); this.newTable = newTable; this.privileges = requireNonNull(privileges, "privileges is null"); this.ignoreExisting = ignoreExisting; this.statistics = requireNonNull(statistics, "statistics is null"); this.queryId = getQueryId(newTable).orElseThrow(() -> new IllegalArgumentException("Query id is not present")); } public String getDescription() { return format("add table %s.%s", newTable.getDatabaseName(), newTable.getTableName()); } public void run(HiveMetastoreClosure metastore, AcidTransaction transaction) { boolean created = false; try { metastore.createTable(newTable, privileges); created = true; } catch (RuntimeException e) { boolean done = false; try { Optional

existingTable = metastore.getTable(newTable.getDatabaseName(), newTable.getTableName()); if (existingTable.isPresent()) { Table table = existingTable.get(); Optional existingTableQueryId = getQueryId(table); if (existingTableQueryId.isPresent() && existingTableQueryId.get().equals(queryId)) { // ignore table if it was already created by the same query during retries done = true; created = true; } else { // If the table definition in the metastore is different than what this tx wants to create // then there is a conflict (e.g., current tx wants to create T(a: bigint), // but another tx already created T(a: varchar)). // This may be a problem if there is an insert after this step. if (!hasTheSameSchema(newTable, table)) { e = new TrinoException(TRANSACTION_CONFLICT, format("Table already exists with a different schema: '%s'", newTable.getTableName())); } else { done = ignoreExisting; } } } } catch (RuntimeException ignored) { // When table could not be fetched from metastore, it is not known whether the table was added. // Deleting the table when aborting commit has the risk of deleting table not added in this transaction. // Not deleting the table may leave garbage behind. The former is much more dangerous than the latter. // Therefore, the table is not considered added. } if (!done) { throw e; } } tableCreated = true; if (created && !isPrestoView(newTable)) { metastore.updateTableStatistics(newTable.getDatabaseName(), newTable.getTableName(), transaction, ignored -> statistics); } } private static boolean hasTheSameSchema(Table newTable, Table existingTable) { List newTableColumns = newTable.getDataColumns(); List existingTableColumns = existingTable.getDataColumns(); if (newTableColumns.size() != existingTableColumns.size()) { return false; } for (Column existingColumn : existingTableColumns) { if (newTableColumns.stream() .noneMatch(newColumn -> newColumn.getName().equals(existingColumn.getName()) && newColumn.getType().equals(existingColumn.getType()))) { return false; } } return true; } public void undo(HiveMetastoreClosure metastore) { if (!tableCreated) { return; } metastore.dropTable(newTable.getDatabaseName(), newTable.getTableName(), false); } } private static class AlterTableOperation { private final Table newTable; private final Table oldTable; private final PrincipalPrivileges principalPrivileges; private boolean undo; public AlterTableOperation(Table newTable, Table oldTable, PrincipalPrivileges principalPrivileges) { this.newTable = requireNonNull(newTable, "newTable is null"); this.oldTable = requireNonNull(oldTable, "oldTable is null"); this.principalPrivileges = requireNonNull(principalPrivileges, "principalPrivileges is null"); checkArgument(newTable.getDatabaseName().equals(oldTable.getDatabaseName())); checkArgument(newTable.getTableName().equals(oldTable.getTableName())); } public String getDescription() { return format( "alter table %s.%s", newTable.getDatabaseName(), newTable.getTableName()); } public void run(HiveMetastoreClosure metastore, AcidTransaction transaction) { undo = true; if (transaction.isTransactional()) { metastore.alterTransactionalTable(newTable, transaction.getAcidTransactionId(), transaction.getWriteId(), principalPrivileges); } else { metastore.replaceTable(newTable.getDatabaseName(), newTable.getTableName(), newTable, principalPrivileges); } } public void undo(HiveMetastoreClosure metastore, AcidTransaction transaction) { if (!undo) { return; } if (transaction.isTransactional()) { metastore.alterTransactionalTable(oldTable, transaction.getAcidTransactionId(), transaction.getWriteId(), principalPrivileges); } else { metastore.replaceTable(oldTable.getDatabaseName(), oldTable.getTableName(), oldTable, principalPrivileges); } } } private static class AlterPartitionOperation { private final PartitionWithStatistics newPartition; private final PartitionWithStatistics oldPartition; private boolean undo; public AlterPartitionOperation(PartitionWithStatistics newPartition, PartitionWithStatistics oldPartition) { this.newPartition = requireNonNull(newPartition, "newPartition is null"); this.oldPartition = requireNonNull(oldPartition, "oldPartition is null"); checkArgument(newPartition.getPartition().getDatabaseName().equals(oldPartition.getPartition().getDatabaseName())); checkArgument(newPartition.getPartition().getTableName().equals(oldPartition.getPartition().getTableName())); checkArgument(newPartition.getPartition().getValues().equals(oldPartition.getPartition().getValues())); } public String getDescription() { return format( "alter partition %s.%s %s", newPartition.getPartition().getDatabaseName(), newPartition.getPartition().getTableName(), newPartition.getPartition().getValues()); } public void run(HiveMetastoreClosure metastore) { undo = true; metastore.alterPartition(newPartition.getPartition().getDatabaseName(), newPartition.getPartition().getTableName(), newPartition); } public void undo(HiveMetastoreClosure metastore) { if (!undo) { return; } metastore.alterPartition(oldPartition.getPartition().getDatabaseName(), oldPartition.getPartition().getTableName(), oldPartition); } } private static class UpdateStatisticsOperation { private final SchemaTableName tableName; private final Optional partitionName; private final PartitionStatistics statistics; private final boolean merge; private boolean done; public UpdateStatisticsOperation(SchemaTableName tableName, Optional partitionName, PartitionStatistics statistics, boolean merge) { this.tableName = requireNonNull(tableName, "tableName is null"); this.partitionName = requireNonNull(partitionName, "partitionName is null"); this.statistics = requireNonNull(statistics, "statistics is null"); this.merge = merge; } public void run(HiveMetastoreClosure metastore, AcidTransaction transaction) { if (partitionName.isPresent()) { metastore.updatePartitionStatistics(tableName.getSchemaName(), tableName.getTableName(), partitionName.get(), this::updateStatistics); } else { metastore.updateTableStatistics(tableName.getSchemaName(), tableName.getTableName(), transaction, this::updateStatistics); } done = true; } public void undo(HiveMetastoreClosure metastore, AcidTransaction transaction) { if (!done) { return; } if (partitionName.isPresent()) { metastore.updatePartitionStatistics(tableName.getSchemaName(), tableName.getTableName(), partitionName.get(), this::resetStatistics); } else { metastore.updateTableStatistics(tableName.getSchemaName(), tableName.getTableName(), transaction, this::resetStatistics); } } public String getDescription() { if (partitionName.isPresent()) { return format("replace partition parameters %s %s", tableName, partitionName.get()); } return format("replace table parameters %s", tableName); } private PartitionStatistics updateStatistics(PartitionStatistics currentStatistics) { return merge ? merge(currentStatistics, statistics) : statistics; } private PartitionStatistics resetStatistics(PartitionStatistics currentStatistics) { return new PartitionStatistics(reduce(currentStatistics.getBasicStatistics(), statistics.getBasicStatistics(), SUBTRACT), ImmutableMap.of()); } } private static class PartitionAdder { private final String schemaName; private final String tableName; private final HiveMetastoreClosure metastore; private final int batchSize; private final List partitions; private List> createdPartitionValues = new ArrayList<>(); public PartitionAdder(String schemaName, String tableName, HiveMetastoreClosure metastore, int batchSize) { this.schemaName = schemaName; this.tableName = tableName; this.metastore = metastore; this.batchSize = batchSize; this.partitions = new ArrayList<>(batchSize); } public String getSchemaName() { return schemaName; } public String getTableName() { return tableName; } public void addPartition(PartitionWithStatistics partition) { checkArgument(getQueryId(partition.getPartition()).isPresent()); partitions.add(partition); } public void execute(AcidTransaction transaction) { List> batchedPartitions = Lists.partition(partitions, batchSize); for (List batch : batchedPartitions) { try { metastore.addPartitions(schemaName, tableName, batch); for (PartitionWithStatistics partition : batch) { createdPartitionValues.add(partition.getPartition().getValues()); } } catch (Throwable t) { // Add partition to the created list conservatively. // Some metastore implementations are known to violate the "all or none" guarantee for add_partitions call. boolean batchCompletelyAdded = true; for (PartitionWithStatistics partition : batch) { try { Optional remotePartition = metastore.getPartition(schemaName, tableName, partition.getPartition().getValues()); // getQueryId(partition) is guaranteed to be non-empty. It is asserted in PartitionAdder.addPartition. if (remotePartition.isPresent() && getQueryId(remotePartition.get()).equals(getQueryId(partition.getPartition()))) { createdPartitionValues.add(partition.getPartition().getValues()); } else { batchCompletelyAdded = false; } } catch (Throwable ignored) { // When partition could not be fetched from metastore, it is not known whether the partition was added. // Deleting the partition when aborting commit has the risk of deleting partition not added in this transaction. // Not deleting the partition may leave garbage behind. The former is much more dangerous than the latter. // Therefore, the partition is not added to the createdPartitionValues list here. batchCompletelyAdded = false; } } // If all the partitions were added successfully, the add_partition operation was actually successful. // For some reason, it threw an exception (communication failure, retry failure after communication failure, etc). // But we would consider it successful anyways. if (!batchCompletelyAdded) { if (t instanceof TableNotFoundException) { throw new TrinoException(HIVE_TABLE_DROPPED_DURING_QUERY, t); } throw t; } } } if (transaction.isAcidTransactionRunning()) { List partitionNames = partitions.stream().map(PartitionWithStatistics::getPartitionName).collect(Collectors.toUnmodifiableList()); metastore.addDynamicPartitions(schemaName, tableName, partitionNames, transaction.getAcidTransactionId(), transaction.getWriteId(), transaction.getOperation()); } partitions.clear(); } public List> rollback() { // drop created partitions List> partitionsFailedToRollback = new ArrayList<>(); for (List createdPartitionValue : createdPartitionValues) { try { metastore.dropPartition(schemaName, tableName, createdPartitionValue, false); } catch (PartitionNotFoundException e) { // Maybe some one deleted the partition we added. // Anyways, we are good because the partition is not there anymore. } catch (Throwable t) { partitionsFailedToRollback.add(createdPartitionValue); } } createdPartitionValues = partitionsFailedToRollback; return partitionsFailedToRollback; } } private static class RecursiveDeleteResult { private final boolean directoryNoLongerExists; private final List notDeletedEligibleItems; public RecursiveDeleteResult(boolean directoryNoLongerExists, List notDeletedEligibleItems) { this.directoryNoLongerExists = directoryNoLongerExists; this.notDeletedEligibleItems = notDeletedEligibleItems; } public boolean isDirectoryNoLongerExists() { return directoryNoLongerExists; } public List getNotDeletedEligibleItems() { return notDeletedEligibleItems; } } private interface ExclusiveOperation { void execute(HiveMetastoreClosure delegate, HdfsEnvironment hdfsEnvironment); } private long allocateWriteId(String dbName, String tableName, long transactionId) { return delegate.allocateWriteId(dbName, tableName, transactionId); } private void acquireTableWriteLock( AcidTransactionOwner transactionOwner, String queryId, long transactionId, String dbName, String tableName, DataOperationType operation, boolean isPartitioned) { delegate.acquireTableWriteLock(transactionOwner, queryId, transactionId, dbName, tableName, operation, isPartitioned); } public void updateTableWriteId(String dbName, String tableName, long transactionId, long writeId, OptionalLong rowCountChange) { delegate.updateTableWriteId(dbName, tableName, transactionId, writeId, rowCountChange); } public void alterPartitions(String dbName, String tableName, List partitions, long writeId) { delegate.alterPartitions(dbName, tableName, partitions, writeId); } public void addDynamicPartitions(String dbName, String tableName, List partitionNames, long transactionId, long writeId, AcidOperation operation) { delegate.addDynamicPartitions(dbName, tableName, partitionNames, transactionId, writeId, operation); } public void commitTransaction(long transactionId) { delegate.commitTransaction(transactionId); } public static void cleanExtraOutputFiles(HdfsEnvironment hdfsEnvironment, HdfsContext hdfsContext, String queryId, Path path, Set filesToKeep) { List filesToDelete = new LinkedList<>(); try { log.debug("Deleting failed attempt files from %s for query %s", path, queryId); FileSystem fileSystem = hdfsEnvironment.getFileSystem(hdfsContext, path); if (!fileSystem.exists(path)) { // directory may nat exit if no files were actually written return; } // files are written flat in a single directory so we do not need to list recursively RemoteIterator iterator = fileSystem.listFiles(path, false); while (iterator.hasNext()) { Path file = iterator.next().getPath(); if (isFileCreatedByQuery(file.getName(), queryId) && !filesToKeep.contains(file.getName())) { filesToDelete.add(file.getName()); } } ImmutableList.Builder deletedFilesBuilder = ImmutableList.builder(); Iterator filesToDeleteIterator = filesToDelete.iterator(); while (filesToDeleteIterator.hasNext()) { String fileName = filesToDeleteIterator.next(); Path filePath = new Path(path, fileName); log.debug("Deleting failed attempt file %s for query %s", filePath, queryId); DELETE_RETRY.run("delete " + filePath, () -> { checkedDelete(fileSystem, filePath, false); return null; }); deletedFilesBuilder.add(fileName); filesToDeleteIterator.remove(); } List deletedFiles = deletedFilesBuilder.build(); if (!deletedFiles.isEmpty()) { log.info("Deleted failed attempt files %s from %s for query %s", deletedFiles, path, queryId); } } catch (Exception e) { if (e instanceof InterruptedException) { Thread.currentThread().interrupt(); } // If we fail here query will be rolled back. The optimal outcome would be for rollback to complete successfully and clean up everything for query. // Yet if we have problem here, probably rollback will also fail. // // Thrown exception is listing files which we could not delete. So those can be cleaned up later by user manually. // Note it is not a bullet-proof solution. // The rollback routine will still fire and try to cleanup the changes query made. It will cleanup some, leave some behind probably. // It is not obvious that if at this point user cleans up the failed attempt files the table would be in the expected state. // // Still we cannot do much better for non-transactional Hive tables. throw new TrinoException( HIVE_FILESYSTEM_ERROR, format("Error deleting failed retry attempt files from %s; remaining files %s; manual cleanup may be required", path, filesToDelete), e); } } public record PartitionUpdateInfo(List partitionValues, Path currentLocation, List fileNames, PartitionStatistics statisticsUpdate) { public PartitionUpdateInfo(List partitionValues, Path currentLocation, List fileNames, PartitionStatistics statisticsUpdate) { this.partitionValues = requireNonNull(partitionValues, "partitionValues is null"); this.currentLocation = requireNonNull(currentLocation, "currentLocation is null"); this.fileNames = requireNonNull(fileNames, "fileNames is null"); this.statisticsUpdate = requireNonNull(statisticsUpdate, "statisticsUpdate is null"); } } }