resources.report.rules.pmd.SuspiciousConstantFieldName.html Maven / Gradle / Ivy

Go to download



SuspiciousConstantFieldName

SuspiciousConstantFieldName

Field names using all uppercase characters - Sun’s Java naming conventions indicating constants - should be declared as final.



//ClassOrInterfaceDeclaration[@Interface='false']
 /ClassOrInterfaceBody/ClassOrInterfaceBodyDeclaration/FieldDeclaration
  [@Final='false']
  [VariableDeclarator/VariableDeclaratorId[upper-case(@Image)=@Image]]
 

Example(s):


    
public class Foo {
 // this is bad, since someone could accidentally
 // do PI = 2.71828; which is actually e
 // final double PI = 3.16; is ok
  double PI = 3.16;
}