resources.report.rules.pmd.UseAssertTrueInsteadOfAssertEquals.html Maven / Gradle / Ivy

Go to download


UseAssertTrueInsteadOfAssertEquals

UseAssertTrueInsteadOfAssertEquals

When asserting a value is the same as a literal or Boxed boolean, use assertTrue/assertFalse, instead of assertEquals.



//PrimaryExpression[PrimaryPrefix/Name[@Image = 'assertEquals']]
[
  PrimarySuffix/Arguments/ArgumentList/Expression/PrimaryExpression/PrimaryPrefix/Literal/BooleanLiteral
  or
  PrimarySuffix/Arguments/ArgumentList/Expression/PrimaryExpression/PrimaryPrefix
  /Name[(@Image = 'Boolean.TRUE' or @Image = 'Boolean.FALSE')]
]

			
Example(s):



public class MyTestCase extends TestCase {
	public void testMyCase() {
		boolean myVar = true;
		// Ok
		assertTrue("myVar is true", myVar);
		// Bad
		assertEquals("myVar is true", true, myVar);
		// Bad
		assertEquals("myVar is false", false, myVar);
		// Bad
		assertEquals("myVar is true", Boolean.TRUE, myVar);
		// Bad
		assertEquals("myVar is false", Boolean.FALSE, myVar);
	}
}