• Home
• com.github.sbaudoin
• sonar-shellcheck-plugin
• 2.5.0
• source code
• SC2056.html

×

Project download

Many resources are needed to download a project. Please understand that we have to compensate our server costs. Thank you in advance.
Project price only 1 $

You can buy this project and download/modify it how often you want.

org.sonar.l10n.shellcheck.rules.shellcheck.SC2056.html Maven / Gradle / Ivy

You probably wanted && here
Problematic code
if  (( $1 != 0 || $1 != 3 ))
then
  echo "$1 is not 0 or 3"
fi

Correct code
if  (( $1 != 0 && $1 != 3 ))
then
  echo "$1 is not 0 or 3"
fi

Rationale
This is not a bash issue, but a simple, common logical mistake applicable to all languages.
(( $1 != 0 || $1 != 3 )) is always true:

If $1 = 0 then $1 != 3 is true, so the statement is true.
If $1 = 3 then $1 != 0 is true, so the statement is true.
If $1 = 42 then $1 != 0 is true, so the statement is true.

(( $1 != 0 && $1 != 3 )) is true only when $1 is not 0 and not 3:

If $1 = 0, then $1 != 3 is false, so the statement is false.
If $1 = 3, then $1 != 0 is false, so the statement is false.
If $1 = 42, then both $1 != 0 and $1  != 3 is true, so the statement is true.

This statement is identical to ! (( $1 == 0 || $1 == 3 )), which also works correctly.
Exceptions
None.