All Downloads are FREE. Search and download functionalities are using the official Maven repository.

com.google.errorprone.bugpatterns.NonAtomicVolatileUpdate Maven / Gradle / Ivy

There is a newer version: 2.28.0
Show newest version
/*
 * Copyright 2014 The Error Prone Authors.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

package com.google.errorprone.bugpatterns;

import static com.google.errorprone.BugPattern.SeverityLevel.WARNING;
import static com.google.errorprone.matchers.Matchers.allOf;
import static com.google.errorprone.matchers.Matchers.anyOf;
import static com.google.errorprone.matchers.Matchers.assignment;
import static com.google.errorprone.matchers.Matchers.binaryTree;
import static com.google.errorprone.matchers.Matchers.inSynchronized;
import static com.google.errorprone.matchers.Matchers.kindIs;
import static com.google.errorprone.matchers.Matchers.not;
import static com.google.errorprone.matchers.Matchers.sameVariable;
import static com.google.errorprone.matchers.Matchers.toType;

import com.google.errorprone.BugPattern;
import com.google.errorprone.BugPattern.StandardTags;
import com.google.errorprone.VisitorState;
import com.google.errorprone.bugpatterns.BugChecker.AssignmentTreeMatcher;
import com.google.errorprone.bugpatterns.BugChecker.CompoundAssignmentTreeMatcher;
import com.google.errorprone.bugpatterns.BugChecker.UnaryTreeMatcher;
import com.google.errorprone.matchers.Description;
import com.google.errorprone.matchers.Matcher;
import com.google.errorprone.matchers.Matchers;
import com.sun.source.tree.AssignmentTree;
import com.sun.source.tree.BinaryTree;
import com.sun.source.tree.CompoundAssignmentTree;
import com.sun.source.tree.ExpressionTree;
import com.sun.source.tree.Tree.Kind;
import com.sun.source.tree.UnaryTree;
import javax.lang.model.element.Modifier;

/** Detects non-atomic updates to volatile variables. */
@BugPattern(
    name = "NonAtomicVolatileUpdate",
    summary = "This update of a volatile variable is non-atomic",
    severity = WARNING,
    tags = StandardTags.FRAGILE_CODE)
public class NonAtomicVolatileUpdate extends BugChecker
    implements UnaryTreeMatcher, CompoundAssignmentTreeMatcher, AssignmentTreeMatcher {

  /** Extracts the expression from a UnaryTree and applies a matcher to it. */
  private static Matcher expressionFromUnaryTree(
      final Matcher exprMatcher) {
    return new Matcher() {
      @Override
      public boolean matches(UnaryTree tree, VisitorState state) {
        return exprMatcher.matches(tree.getExpression(), state);
      }
    };
  }

  /** Extracts the variable from a CompoundAssignmentTree and applies a matcher to it. */
  private static Matcher variableFromCompoundAssignmentTree(
      final Matcher exprMatcher) {
    return new Matcher() {
      @Override
      public boolean matches(CompoundAssignmentTree tree, VisitorState state) {
        return exprMatcher.matches(tree.getVariable(), state);
      }
    };
  }

  /** Extracts the variable from an AssignmentTree and applies a matcher to it. */
  private static Matcher variableFromAssignmentTree(
      final Matcher exprMatcher) {
    return new Matcher() {
      @Override
      public boolean matches(AssignmentTree tree, VisitorState state) {
        return exprMatcher.matches(tree.getVariable(), state);
      }
    };
  }

  /**
   * Matches patterns like i++ and i-- in which i is volatile, and the pattern is not enclosed by a
   * synchronized block.
   */
  private static final Matcher unaryIncrementDecrementMatcher =
      allOf(
          expressionFromUnaryTree(Matchers.hasModifier(Modifier.VOLATILE)),
          not(inSynchronized()),
          anyOf(
              kindIs(Kind.POSTFIX_INCREMENT),
              kindIs(Kind.PREFIX_INCREMENT),
              kindIs(Kind.POSTFIX_DECREMENT),
              kindIs(Kind.PREFIX_DECREMENT)));

  @Override
  public Description matchUnary(UnaryTree tree, VisitorState state) {
    if (unaryIncrementDecrementMatcher.matches(tree, state)) {
      return describeMatch(tree);
    }
    return Description.NO_MATCH;
  }

  /**
   * Matches patterns like i += 1 and i -= 1 in which i is volatile, and the pattern is not enclosed
   * by a synchronized block.
   */
  private static final Matcher compoundAssignmentIncrementDecrementMatcher =
      allOf(
          variableFromCompoundAssignmentTree(
              Matchers.hasModifier(Modifier.VOLATILE)),
          not(inSynchronized()),
          anyOf(kindIs(Kind.PLUS_ASSIGNMENT), kindIs(Kind.MINUS_ASSIGNMENT)));

  @Override
  public Description matchCompoundAssignment(CompoundAssignmentTree tree, VisitorState state) {
    if (compoundAssignmentIncrementDecrementMatcher.matches(tree, state)) {
      return describeMatch(tree);
    }
    return Description.NO_MATCH;
  }

  /**
   * Matches patterns like i = i + 1 and i = i - 1 in which i is volatile, and the pattern is not
   * enclosed by a synchronized block.
   */
  private static Matcher assignmentIncrementDecrementMatcher(
      ExpressionTree variable) {
    return allOf(
        variableFromAssignmentTree(Matchers.hasModifier(Modifier.VOLATILE)),
        not(inSynchronized()),
        assignment(
            Matchers.anything(),
            toType(
                BinaryTree.class,
                Matchers.allOf(
                    Matchers.anyOf(kindIs(Kind.PLUS), kindIs(Kind.MINUS)),
                    binaryTree(sameVariable(variable), Matchers.anything())))));
  }

  @Override
  public Description matchAssignment(AssignmentTree tree, VisitorState state) {
    if (assignmentIncrementDecrementMatcher(tree.getVariable()).matches(tree, state)) {
      return describeMatch(tree);
    }
    return Description.NO_MATCH;
  }
}




© 2015 - 2024 Weber Informatics LLC | Privacy Policy