com.google.errorprone.bugpatterns.threadsafety.AbstractLockMethodChecker Maven / Gradle / Ivy
/*
* Copyright 2014 The Error Prone Authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.google.errorprone.bugpatterns.threadsafety;
import com.google.common.base.Functions;
import com.google.common.base.Joiner;
import com.google.common.collect.FluentIterable;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableSet;
import com.google.common.collect.Sets;
import com.google.common.collect.Sets.SetView;
import com.google.errorprone.VisitorState;
import com.google.errorprone.bugpatterns.BugChecker;
import com.google.errorprone.matchers.Description;
import com.sun.source.tree.MethodTree;
import com.sun.source.tree.Tree;
import java.util.Comparator;
import java.util.List;
import java.util.Optional;
import java.util.Set;
/**
* Abstract implementation of checkers for {@code @LockMethod} and{@code @UnlockMethod}.
*
* @author [email protected] (Liam Miller-Cushon)
*/
public abstract class AbstractLockMethodChecker extends BugChecker
implements BugChecker.MethodTreeMatcher {
/**
* Returns the lock expressions in the {@code @LockMethod}/{@code @UnlockMethod} annotation, if
* any.
*/
protected abstract ImmutableList getLockExpressions(MethodTree tree);
/** Searches the method body for locks that are acquired/released. */
protected abstract Set getActual(MethodTree tree, VisitorState state);
/**
* Searches the method body for the incorrect lock operation (e.g. releasing a lock in
* {@code @LockMethod}, or acquiring a lock in {@code @UnlockMethod}).
*/
protected abstract Set getUnwanted(MethodTree tree, VisitorState state);
/** Builds the error message, given the list of locks that were not handled. */
protected abstract String buildMessage(String unhandled);
@Override
public Description matchMethod(MethodTree tree, final VisitorState state) {
ImmutableList lockExpressions = getLockExpressions(tree);
if (lockExpressions.isEmpty()) {
return Description.NO_MATCH;
}
Optional> expected =
parseLockExpressions(lockExpressions, tree, state);
if (!expected.isPresent()) {
return buildDescription(tree).setMessage("Could not resolve lock expression.").build();
}
Set unwanted = getUnwanted(tree, state);
SetView mishandled = Sets.intersection(expected.get(), unwanted);
if (!mishandled.isEmpty()) {
String message = buildMessage(formatLockString(mishandled));
return buildDescription(tree).setMessage(message).build();
}
Set actual = getActual(tree, state);
SetView unhandled = Sets.difference(expected.get(), actual);
if (!unhandled.isEmpty()) {
String message = buildMessage(formatLockString(unhandled));
return buildDescription(tree).setMessage(message).build();
}
return Description.NO_MATCH;
}
private static String formatLockString(Set locks) {
ImmutableList sortedUnhandled =
FluentIterable.from(locks)
.transform(Functions.toStringFunction())
.toSortedList(Comparator.naturalOrder());
return Joiner.on(", ").join(sortedUnhandled);
}
private static Optional> parseLockExpressions(
List lockExpressions, Tree tree, VisitorState state) {
ImmutableSet.Builder builder = ImmutableSet.builder();
for (String lockExpression : lockExpressions) {
Optional guard =
GuardedByBinder.bindString(
lockExpression, GuardedBySymbolResolver.from(tree, state), GuardedByFlags.allOn());
if (!guard.isPresent()) {
return Optional.empty();
}
builder.add(guard.get());
}
return Optional.of(builder.build());
}
}