com.google.errorprone.bugpatterns.time.JavaInstantGetSecondsGetNano Maven / Gradle / Ivy
/*
* Copyright 2018 The Error Prone Authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.google.errorprone.bugpatterns.time;
import static com.google.errorprone.BugPattern.SeverityLevel.WARNING;
import static com.google.errorprone.bugpatterns.time.NearbyCallers.containsCallToSameReceiverNearby;
import static com.google.errorprone.matchers.Matchers.allOf;
import static com.google.errorprone.matchers.method.MethodMatchers.instanceMethod;
import com.google.errorprone.BugPattern;
import com.google.errorprone.VisitorState;
import com.google.errorprone.bugpatterns.BugChecker;
import com.google.errorprone.bugpatterns.BugChecker.MethodInvocationTreeMatcher;
import com.google.errorprone.matchers.Description;
import com.google.errorprone.matchers.Matcher;
import com.google.errorprone.matchers.Matchers;
import com.sun.source.tree.ExpressionTree;
import com.sun.source.tree.MethodInvocationTree;
/**
* This checker warns about calls to {@code instant.getNano()} without a corresponding "nearby" call
* to {@code instant.getEpochSecond()}.
*
* @author [email protected] (Kurt Alfred Kluever)
*/
@BugPattern(
name = "JavaInstantGetSecondsGetNano",
summary =
"instant.getNano() only accesses the underlying nanosecond adjustment from the whole "
+ "second.",
explanation =
"If you call instant.getNano(), you must also call instant.getEpochSecond() in 'nearby' "
+ "code. If you are trying to convert this instant to nanoseconds, you probably meant "
+ "to use Instants.toEpochNanos(instant) instead.",
severity = WARNING)
public final class JavaInstantGetSecondsGetNano extends BugChecker
implements MethodInvocationTreeMatcher {
private static final Matcher GET_EPOCH_SECOND =
instanceMethod().onExactClass("java.time.Instant").named("getEpochSecond");
private static final Matcher GET_NANO =
allOf(
instanceMethod().onExactClass("java.time.Instant").named("getNano"),
Matchers.not(Matchers.packageStartsWith("java.")));
@Override
public Description matchMethodInvocation(MethodInvocationTree tree, VisitorState state) {
if (GET_NANO.matches(tree, state)) {
if (!containsCallToSameReceiverNearby(
tree, GET_EPOCH_SECOND, state, /*checkProtoChains=*/ false)) {
return describeMatch(tree);
}
}
return Description.NO_MATCH;
}
}