All Downloads are FREE. Search and download functionalities are using the official Maven repository.

com.google.errorprone.bugpatterns.inlineme.Validator Maven / Gradle / Ivy

There is a newer version: 2.27.1
Show newest version
/*
 * Copyright 2021 The Error Prone Authors.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

package com.google.errorprone.bugpatterns.inlineme;

import static com.google.errorprone.BugPattern.SeverityLevel.ERROR;
import static com.google.errorprone.util.ASTHelpers.findSuperMethods;
import static com.google.errorprone.util.ASTHelpers.getSymbol;
import static com.google.errorprone.util.ASTHelpers.hasAnnotation;
import static com.google.errorprone.util.ASTHelpers.hasDirectAnnotationWithSimpleName;

import com.google.common.base.CharMatcher;
import com.google.common.collect.ImmutableList;
import com.google.errorprone.BugPattern;
import com.google.errorprone.ErrorProneFlags;
import com.google.errorprone.VisitorState;
import com.google.errorprone.annotations.InlineMeValidationDisabled;
import com.google.errorprone.bugpatterns.BugChecker;
import com.google.errorprone.bugpatterns.BugChecker.MethodTreeMatcher;
import com.google.errorprone.fixes.SuggestedFix;
import com.google.errorprone.fixes.SuggestedFixes;
import com.google.errorprone.matchers.Description;
import com.google.errorprone.util.ASTHelpers;
import com.google.errorprone.util.ErrorProneToken;
import com.google.errorprone.util.ErrorProneTokens;
import com.sun.source.tree.AnnotationTree;
import com.sun.source.tree.MethodTree;
import com.sun.tools.javac.code.Symbol.MethodSymbol;
import com.sun.tools.javac.util.Context;
import java.util.EnumSet;
import java.util.Set;
import java.util.function.Function;
import java.util.function.Predicate;

/** Checker that ensures the {@code @InlineMe} annotation is used correctly. */
@BugPattern(
    name = "InlineMeValidator",
    summary = "Ensures that the @InlineMe annotation is used correctly.",
    suppressionAnnotations = InlineMeValidationDisabled.class,
    documentSuppression = false,
    severity = ERROR)
public final class Validator extends BugChecker implements MethodTreeMatcher {
  static final String CLEANUP_INLINE_ME_FLAG = "InlineMe:CleanupInlineMes";

  private final boolean cleanupInlineMes;

  public Validator(ErrorProneFlags flags) {
    this.cleanupInlineMes = flags.getBoolean(CLEANUP_INLINE_ME_FLAG).orElse(false);
  }

  @Override
  public Description matchMethod(MethodTree tree, VisitorState state) {
    MethodSymbol symbol = getSymbol(tree);
    if (cleanupInlineMes) {
      return shouldDelete(symbol, state)
          // TODO(b/216312289): maybe use SuggestedFixes.delete(tree)?
          ? describeMatch(tree, SuggestedFixes.replaceIncludingComments(state.getPath(), "", state))
          : Description.NO_MATCH;
    } else {
      return InlineMeData.createFromSymbol(symbol)
          .map(data -> match(data, tree, state))
          .orElse(Description.NO_MATCH);
    }
  }

  /** Whether or not the API should be deleted when run in cleanup mode. */
  private static boolean shouldDelete(MethodSymbol symbol, VisitorState state) {
    // Clean up (delete) the API if
    //   * it's @InlineMe'd
    //   * it isn't @InlineMeValidationDisabled (this prevents us from deleting default methods)
    //   * it isn't an @Override (since the code would likely no longer compile, or it would start
    //     inheriting behavior from the supertype).

    // TODO(kak): it would be nice if we could query to see if there are still any existing
    // usages of the API before unilaterally deleting it.
    return hasDirectAnnotationWithSimpleName(symbol, "InlineMe")
        && !hasAnnotation(symbol, "java.lang.Override", state)
        && findSuperMethods(symbol, state.getTypes()).isEmpty();
  }

  private Description match(InlineMeData existingAnnotation, MethodTree tree, VisitorState state) {
    InlinabilityResult result = InlinabilityResult.forMethod(tree, state);
    if (!result.isValidForValidator()) {
      return buildDescription(tree)
          .setMessage(result.errorMessage())
          // This method is un-inlineable, so let's remove the annotation (since we can't fix it)
          .addFix(SuggestedFix.delete(getInlineMeAnnotationTree(tree)))
          .build();
    }

    InlineMeData inferredFromMethodBody =
        InlineMeData.buildExpectedInlineMeAnnotation(state, result.body());
    Set mismatches =
        compatibleWithAnnotation(inferredFromMethodBody, existingAnnotation, state.context);
    if (mismatches.isEmpty()) {
      return Description.NO_MATCH;
    }

    // There's some mismatch, render an error.
    return buildDescription(tree)
        .setMessage(renderInlineMeMismatch(inferredFromMethodBody, existingAnnotation, mismatches))
        .addFix(
            SuggestedFix.replace(
                getInlineMeAnnotationTree(tree), inferredFromMethodBody.buildAnnotation()))
        .build();
  }

  private static AnnotationTree getInlineMeAnnotationTree(MethodTree tree) {
    return ASTHelpers.getAnnotationWithSimpleName(tree.getModifiers().getAnnotations(), "InlineMe");
  }

  private static String renderInlineMeMismatch(
      InlineMeData inferredFromMethodBody,
      InlineMeData existingAnnotation,
      Set mismatches) {
    StringBuilder message =
        new StringBuilder(
            "There is a mismatch between the implementation of the method and the replacement"
                + " suggested in the annotation.");

    if (mismatches.contains(MismatchedInlineMeComponents.REPLACEMENT_STRING)) {
      message.append(
          String.format(
              "\nReplacement text: \n  InferredFromBody: %s\n  FromAnnotation: %s",
              inferredFromMethodBody.replacement(), existingAnnotation.replacement()));
    }
    if (mismatches.contains(MismatchedInlineMeComponents.IMPORTS)) {
      message.append(
          String.format(
              "\nImports: \n  InferredFromBody: %s\n  FromAnnotation: %s",
              inferredFromMethodBody.imports(), existingAnnotation.imports()));
    }
    if (mismatches.contains(MismatchedInlineMeComponents.STATIC_IMPORTS)) {
      message.append(
          String.format(
              "\nStatic imports: \n  InferredFromBody: %s\n  FromAnnotation: %s",
              inferredFromMethodBody.staticImports(), existingAnnotation.staticImports()));
    }
    return message.toString();
  }

  private enum MismatchedInlineMeComponents {
    REPLACEMENT_STRING,
    IMPORTS,
    STATIC_IMPORTS
  }

  private static Set compatibleWithAnnotation(
      InlineMeData inferredFromMethodBody, InlineMeData anno, Context context) {
    EnumSet mismatches =
        EnumSet.noneOf(MismatchedInlineMeComponents.class);

    // Developers can customize the @InlineMe implementation a bit, so we have some leniency in
    // determining if an annotation properly represents the implementation of a method.
    if (!parseAndCheckForTokenEquivalence(
        anno.replacement(), inferredFromMethodBody.replacement(), context)) {
      mismatches.add(MismatchedInlineMeComponents.REPLACEMENT_STRING);
    }
    if (!inferredFromMethodBody.imports().equals(anno.imports())) {
      mismatches.add(MismatchedInlineMeComponents.IMPORTS);
    }
    if (!inferredFromMethodBody.staticImports().equals(anno.staticImports())) {
      mismatches.add(MismatchedInlineMeComponents.STATIC_IMPORTS);
    }
    return mismatches;
  }

  private static final CharMatcher SEMICOLON = CharMatcher.is(';');

  /** Determines if the first and second token strings are equivalent. */
  private static boolean parseAndCheckForTokenEquivalence(
      String first, String second, Context context) {
    ImmutableList tokens1 =
        ErrorProneTokens.getTokens(SEMICOLON.trimTrailingFrom(first), context);
    ImmutableList tokens2 =
        ErrorProneTokens.getTokens(SEMICOLON.trimTrailingFrom(second), context);

    if (tokens1.size() != tokens2.size()) {
      return false;
    }

    for (int i = 0; i < tokens1.size(); i++) {
      ErrorProneToken token1 = tokens1.get(i);
      ErrorProneToken token2 = tokens2.get(i);

      if (!token1.kind().equals(token2.kind())) {
        return false;
      }

      // note we specifically avoid checking ErrorProneToken::comments
      if (mismatch(token1, token2, ErrorProneToken::hasName, ErrorProneToken::name)
          || mismatch(token1, token2, ErrorProneToken::hasStringVal, ErrorProneToken::stringVal)
          || mismatch(token1, token2, ErrorProneToken::hasRadix, ErrorProneToken::radix)) {
        return false;
      }
    }

    return true;
  }

  private static  boolean mismatch(
      ErrorProneToken first,
      ErrorProneToken second,
      Predicate guard,
      Function extractor) {
    return guard.test(first) && !extractor.apply(first).equals(extractor.apply(second));
  }
}




© 2015 - 2024 Weber Informatics LLC | Privacy Policy