com.google.errorprone.bugpatterns.GetClassOnClass Maven / Gradle / Ivy
/*
* Copyright 2015 The Error Prone Authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.google.errorprone.bugpatterns;
import static com.google.errorprone.BugPattern.SeverityLevel.ERROR;
import static com.google.errorprone.matchers.Matchers.instanceMethod;
import com.google.errorprone.BugPattern;
import com.google.errorprone.VisitorState;
import com.google.errorprone.bugpatterns.BugChecker.MethodInvocationTreeMatcher;
import com.google.errorprone.fixes.Fix;
import com.google.errorprone.fixes.SuggestedFix;
import com.google.errorprone.matchers.Description;
import com.google.errorprone.matchers.Matcher;
import com.google.errorprone.util.ASTHelpers;
import com.sun.source.tree.ExpressionTree;
import com.sun.source.tree.MethodInvocationTree;
/**
* @author [email protected] (Christine Yang)
* @author [email protected] (Katy Muhlrad)
*/
@BugPattern(
summary =
"Calling getClass() on an object of type Class returns the Class object for "
+ "java.lang.Class; you probably meant to operate on the object directly",
severity = ERROR)
public class GetClassOnClass extends BugChecker implements MethodInvocationTreeMatcher {
private static final Matcher getClassMethodMatcher =
instanceMethod().onExactClass("java.lang.Class").named("getClass");
/** Suggests removing getClass() or changing to Class.class. */
@Override
public Description matchMethodInvocation(MethodInvocationTree tree, VisitorState state) {
if (getClassMethodMatcher.matches(tree, state)) {
String methodInvoker = state.getSourceForNode(ASTHelpers.getReceiver(tree));
Fix removeGetClass = SuggestedFix.replace(tree, methodInvoker);
Fix changeToClassDotClass = SuggestedFix.replace(tree, "Class.class");
return buildDescription(tree).addFix(removeGetClass).addFix(changeToClassDotClass).build();
}
return Description.NO_MATCH;
}
}