com.h3xstream.findsecbugs.xss.XssServletDetector Maven / Gradle / Ivy

Go to download
Show more of this group Show more artifacts with this name
Show all versions of findsecbugs-plugin Show documentation
Core module of the project. It include all the SpotBugs detectors. The resulting jar is the published plugin.
The newest version!
/**
 * Find Security Bugs
 * Copyright (c) Philippe Arteau, All rights reserved.
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 3.0 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library.
 */
package com.h3xstream.findsecbugs.xss;

import com.h3xstream.findsecbugs.FindSecBugsGlobalConfig;
import com.h3xstream.findsecbugs.common.InterfaceUtils;
import com.h3xstream.findsecbugs.injection.BasicInjectionDetector;
import com.h3xstream.findsecbugs.taintanalysis.Taint;
import edu.umd.cs.findbugs.BugReporter;
import edu.umd.cs.findbugs.Priorities;
import edu.umd.cs.findbugs.ba.ClassContext;
import org.apache.bcel.generic.ConstantPoolGen;

public class XssServletDetector extends BasicInjectionDetector {

    private static final String XSS_SERVLET_TYPE = "XSS_SERVLET";
    private static final String[] REQUIRED_CLASSES = {
        "Ljavax/servlet/http/ServletResponse;",
        "Ljavax/servlet/http/ServletResponseWrapper;",
        "Ljavax/servlet/http/HttpServletResponse;",
        "Ljavax/servlet/http/HttpServletResponseWrapper;",
        "Lorg/apache/jetspeed/portlet/PortletResponse;",
        "Lorg/apache/jetspeed/portlet/PortletResponseWrapper;",
        "Ljavax/portlet/RenderResponse;",
        "Ljavax/portlet/MimeResponse;",
        "Ljavax/portlet/filter/RenderResponseWrapper;",
        "Ljavax/portlet/PortletResponse;",
        "Ljavax/portlet/ActionResponseWrapper;",
        "Ljavax/portlet/EventResponseWrapper;",
        "Ljavax/portlet/PortletResponseWrapper;",
        "Ljavax/portlet/RenderResponseWrapper;",
        "Ljavax/portlet/ResourceResponseWrapper;",
    };

    public XssServletDetector(BugReporter bugReporter) {
        super(bugReporter);
        loadConfiguredSinks("xss-servlet.txt", XSS_SERVLET_TYPE);
    }

    @Override
    protected int getPriority(Taint taint) {
        if (!taint.isSafe() && taint.hasTag(Taint.Tag.XSS_SAFE)) {
            if(FindSecBugsGlobalConfig.getInstance().isReportPotentialXssWrongContext()) {
                return Priorities.LOW_PRIORITY;
            } else {
                return Priorities.IGNORE_PRIORITY;
            }
        } else if (!taint.isSafe()
                && (taint.hasOneTag(Taint.Tag.QUOTE_ENCODED, Taint.Tag.APOSTROPHE_ENCODED))
                && taint.hasTag(Taint.Tag.LT_ENCODED)) {
            return Priorities.LOW_PRIORITY;
        } else {
            return super.getPriority(taint);
        }
    }
    
    @Override
    public boolean shouldAnalyzeClass(ClassContext classContext) {
        ConstantPoolGen constantPoolGen = classContext.getConstantPoolGen();
        for (String requiredClass : REQUIRED_CLASSES) {
            if (constantPoolGen.lookupUtf8(requiredClass) != -1) {
                String className = classContext.getClassDescriptor().getDottedClassName();
                return !InterfaceUtils.isSubtype(className, XssJspDetector.JSP_PARENT_CLASSES);
            }
        }
        return false;
    }
}