com.h3xstream.findsecbugs.crypto.EcbModeDetector Maven / Gradle / Ivy

Go to download

Show more of this group Show more artifacts with this name
Show all versions of plugin Show documentation

Core module of the project. It include all the FindBugs detectors. The resulting jar is the published plugin.

The newest version!

/**
 * Find Security Bugs
 * Copyright (c) 2013, Philippe Arteau, All rights reserved.
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 3.0 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library.
 */
package com.h3xstream.findsecbugs.crypto;

import com.h3xstream.findsecbugs.common.StringTracer;

import edu.umd.cs.findbugs.BugInstance;
import edu.umd.cs.findbugs.BugReporter;
import edu.umd.cs.findbugs.OpcodeStack;
import edu.umd.cs.findbugs.Priorities;
import edu.umd.cs.findbugs.bcel.OpcodeStackDetector;
import org.apache.bcel.Constants;

/**
 * Identify ECB mode for certain cipher. (AES for the moment).
 * DES ciphers are target by {@link com.h3xstream.findsecbugs.crypto.DesUsageDetector}.
 */
public class EcbModeDetector extends OpcodeStackDetector {

	private static final String ECB_MODE_TYPE = "ECB_MODE";
    private static final boolean DEBUG = false;

    private BugReporter bugReporter;

    public EcbModeDetector(BugReporter bugReporter) {
        this.bugReporter = bugReporter;
    }

	@Override
	public void sawOpcode( int seen ) {
//		printOpCode( seen );

		if (seen == Constants.INVOKESTATIC && getClassConstantOperand().equals("javax/crypto/Cipher") &&
		                getNameConstantOperand().equals("getInstance")) {
			OpcodeStack.Item item = stack.getStackItem( stack.getStackDepth()-1 ); //The first argument is last
			if ( StringTracer.isConstantString(item)) {
				String cipherValue = (String) item.getConstant();
				if(DEBUG) System.out.println(cipherValue);

				if(cipherValue.contains("AES/ECB/") || cipherValue.contains("DES/ECB/") || cipherValue.contains("DESede/ECB/")) {
					bugReporter.reportBug(new BugInstance(this, ECB_MODE_TYPE, Priorities.NORMAL_PRIORITY) //
						.addClass( this ).addMethod( this ).addSourceLine(this));
				}
			}
		}
	}
}