com.liferay.source.formatter.check.JavaUpgradeClassCheck Maven / Gradle / Ivy
/**
* SPDX-FileCopyrightText: (c) 2000 Liferay, Inc. https://liferay.com
* SPDX-License-Identifier: LGPL-2.1-or-later OR LicenseRef-Liferay-DXP-EULA-2.0.0-2023-06
*/
package com.liferay.source.formatter.check;
import com.liferay.portal.tools.ToolsUtil;
import com.liferay.source.formatter.check.util.JavaSourceUtil;
import java.util.List;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
/**
* @author Hugo Huijser
*/
public class JavaUpgradeClassCheck extends BaseFileCheck {
@Override
public boolean isLiferaySourceCheck() {
return true;
}
@Override
protected String doProcess(
String fileName, String absolutePath, String content) {
if (!fileName.contains("/upgrade/")) {
return content;
}
_checkLocaleUtil(fileName, content);
_checkServiceUtil(fileName, absolutePath, content);
_checkTimestamp(fileName, content);
if (!fileName.endsWith("Upgrade.java") &&
!fileName.endsWith("UpgradeStepRegistrator.java")) {
return content;
}
_checkAnnotation(fileName, content);
_checkRegistryVersion(fileName, content);
return content;
}
private void _checkAnnotation(String fileName, String content) {
// LPS-59828
if (!content.contains("implements UpgradeStepRegistrator")) {
return;
}
Matcher matcher = _componentAnnotationPattern.matcher(content);
if (!matcher.find()) {
return;
}
String componentAnnotation = matcher.group();
if (!componentAnnotation.contains("service =")) {
addMessage(fileName, "@Component requires \"service\" parameter");
}
}
private void _checkLocaleUtil(String fileName, String content) {
int pos = content.indexOf("LocaleUtil.getDefault()");
if (pos != -1) {
addMessage(
fileName,
"Use UpgradeProcessUtil.getDefaultLanguageId(companyId) " +
"instead of LocaleUtil.getDefault()",
getLineNumber(content, pos));
}
}
private void _checkRegistryVersion(String fileName, String content) {
Matcher matcher1 = _registryRegisterPattern.matcher(content);
while (matcher1.find()) {
if (ToolsUtil.isInsideQuotes(content, matcher1.start())) {
continue;
}
List parameterList = JavaSourceUtil.getParameterList(
content.substring(matcher1.start()));
if (parameterList.size() <= 4) {
continue;
}
String previousUpgradeClassName = null;
for (int i = 3; i < parameterList.size(); i++) {
String parameter = parameterList.get(i);
Matcher matcher2 = _upgradeClassNamePattern.matcher(parameter);
if (!matcher2.find()) {
break;
}
String upgradeClassName = matcher2.group(1);
if ((previousUpgradeClassName != null) &&
(previousUpgradeClassName.compareTo(upgradeClassName) >
0)) {
addMessage(
fileName,
"Break up Upgrade classes with a minor version " +
"increment or order alphabetically",
getLineNumber(content, matcher1.start()));
break;
}
previousUpgradeClassName = upgradeClassName;
}
}
}
private void _checkServiceUtil(
String fileName, String absolutePath, String content) {
if (!isExcludedPath(_UPGRADE_SERVICE_UTIL_EXCLUDES, absolutePath) &&
fileName.contains("/portal/upgrade/") &&
!fileName.contains("/test/") &&
!fileName.contains("/testIntegration/")) {
int pos = content.indexOf("ServiceUtil.");
if (pos != -1) {
addMessage(
fileName,
"Do not use *ServiceUtil classes in upgrade classes",
getLineNumber(content, pos));
}
}
}
private void _checkTimestamp(String fileName, String content) {
int pos = content.indexOf("rs.getDate(");
if (pos != -1) {
addMessage(
fileName, "Use rs.getTimestamp instead of rs.getDate",
getLineNumber(content, pos));
}
}
private static final String _UPGRADE_SERVICE_UTIL_EXCLUDES =
"upgrade.service.util.excludes";
private static final Pattern _componentAnnotationPattern = Pattern.compile(
"@Component(\n|\\([\\s\\S]*?\\)\n)");
private static final Pattern _registryRegisterPattern = Pattern.compile(
"registry\\.register\\((.*?)\\);\n", Pattern.DOTALL);
private static final Pattern _upgradeClassNamePattern = Pattern.compile(
"new .*?(\\w+)\\(", Pattern.DOTALL);
}
© 2015 - 2024 Weber Informatics LLC | Privacy Policy