com.vanniktech.lintrules.rxjava2.RxJava2DisposableAddAllCallDetector.kt Maven / Gradle / Ivy

Go to download

Show more of this group Show more artifacts with this name
Show all versions of lint-rules-rxjava2-lint Show documentation

Very opinionated Lint Checks

There is a newer version: 0.25.0

Show newest version

@file:Suppress("UnstableApiUsage") // We know that Lint API's aren't final.

package com.vanniktech.lintrules.rxjava2

import com.android.tools.lint.detector.api.Category.Companion.CORRECTNESS
import com.android.tools.lint.detector.api.Detector
import com.android.tools.lint.detector.api.Implementation
import com.android.tools.lint.detector.api.Issue
import com.android.tools.lint.detector.api.JavaContext
import com.android.tools.lint.detector.api.Scope.JAVA_FILE
import com.android.tools.lint.detector.api.Severity.WARNING
import com.intellij.psi.PsiMethod
import org.jetbrains.uast.UCallExpression
import java.util.EnumSet

val ISSUE_DISPOSABLE_ADD_ALL_CALL = Issue.create(
  "RxJava2DisposableAddAllCall",
  "Marks usage of addAll() on CompositeDisposable.",
  "Instead of using addAll(), add() should be used separately for each Disposable.",
  CORRECTNESS, PRIORITY, WARNING,
  Implementation(RxJava2DisposableAddAllCallDetector::class.java, EnumSet.of(JAVA_FILE))
)

class RxJava2DisposableAddAllCallDetector : Detector(), Detector.UastScanner {
  override fun getApplicableMethodNames() = listOf("addAll")

  override fun visitMethodCall(context: JavaContext, node: UCallExpression, method: PsiMethod) {
    if (context.evaluator.isMemberInClass(method, "io.reactivex.disposables.CompositeDisposable")) {
      context.report(ISSUE_DISPOSABLE_ADD_ALL_CALL, node, context.getNameLocation(node), "Calling `addAll` instead of add separately")
    }
  }
}