io.codemodder.codemods.UseEmptyForToArrayCodemod Maven / Gradle / Ivy

Go to download

Show more of this group Show more artifacts with this name
Show all versions of core-codemods Show documentation

Codemods for fixing common errors across many Java projects

The newest version!

package io.codemodder.codemods;

import com.contrastsecurity.sarif.Result;
import com.github.javaparser.ast.ArrayCreationLevel;
import com.github.javaparser.ast.CompilationUnit;
import com.github.javaparser.ast.NodeList;
import com.github.javaparser.ast.expr.*;
import com.github.javaparser.ast.type.Type;
import io.codemodder.*;
import io.codemodder.javaparser.ChangesResult;
import io.codemodder.providers.sarif.pmd.PmdScan;
import javax.inject.Inject;

/**
 * A codemod that forces a zero-sized array to pass to {@link
 * java.util.Collection#toArray(Object[])} since that is preferable for performance.
 */
@Codemod(
    id = "pixee:java/use-empty-for-toarray",
    importance = Importance.LOW,
    reviewGuidance = ReviewGuidance.MERGE_WITHOUT_REVIEW)
public final class UseEmptyForToArrayCodemod extends SarifPluginJavaParserChanger {

  @Inject
  public UseEmptyForToArrayCodemod(
      @PmdScan(ruleId = "category/java/performance.xml/OptimizableToArrayCall")
          final RuleSarif ruleSarif) {
    super(ruleSarif, MethodCallExpr.class, RegionNodeMatcher.MATCHES_START);
  }

  @Override
  public ChangesResult onResultFound(
      final CodemodInvocationContext context,
      final CompilationUnit cu,
      final MethodCallExpr toArrayCall,
      final Result result) {
    ArrayCreationExpr toArrayArg = toArrayCall.getArgument(0).asArrayCreationExpr();
    Type elementType = toArrayArg.getElementType();
    ArrayCreationLevel arrayCreationLevel = new ArrayCreationLevel(0);
    ArrayCreationExpr newEmptyArray =
        new ArrayCreationExpr(elementType, NodeList.nodeList(arrayCreationLevel), null);
    toArrayCall.setArgument(0, newEmptyArray);
    return ChangesResult.changesApplied;
  }
}