All Downloads are FREE. Search and download functionalities are using the official Maven repository.

com.github._1c_syntax.bsl.languageserver.diagnostics.UsingFindElementByStringDiagnostic Maven / Gradle / Ivy

/*
 * This file is a part of BSL Language Server.
 *
 * Copyright (c) 2018-2022
 * Alexey Sosnoviy , Nikita Fedkin  and contributors
 *
 * SPDX-License-Identifier: LGPL-3.0-or-later
 *
 * BSL Language Server is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 3.0 of the License, or (at your option) any later version.
 *
 * BSL Language Server is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with BSL Language Server.
 */
package com.github._1c_syntax.bsl.languageserver.diagnostics;

import com.github._1c_syntax.bsl.languageserver.diagnostics.metadata.DiagnosticMetadata;
import com.github._1c_syntax.bsl.languageserver.diagnostics.metadata.DiagnosticScope;
import com.github._1c_syntax.bsl.languageserver.diagnostics.metadata.DiagnosticSeverity;
import com.github._1c_syntax.bsl.languageserver.diagnostics.metadata.DiagnosticTag;
import com.github._1c_syntax.bsl.languageserver.diagnostics.metadata.DiagnosticType;
import com.github._1c_syntax.bsl.parser.BSLParser;
import com.github._1c_syntax.utils.CaseInsensitivePattern;
import org.antlr.v4.runtime.tree.ParseTree;

import java.util.regex.Matcher;
import java.util.regex.Pattern;

@DiagnosticMetadata(
  type = DiagnosticType.CODE_SMELL,
  severity = DiagnosticSeverity.MAJOR,
  scope = DiagnosticScope.BSL,
  minutesToFix = 2,
  tags = {
    DiagnosticTag.STANDARD,
    DiagnosticTag.BADPRACTICE,
    DiagnosticTag.PERFORMANCE
  }
)

public class UsingFindElementByStringDiagnostic extends AbstractVisitorDiagnostic {

  private final Pattern pattern = CaseInsensitivePattern.compile(
    "(НайтиПоНаименованию|FindByDescription|НайтиПоКоду|FindByCode)"
  );

  @Override
  public ParseTree visitMethodCall(BSLParser.MethodCallContext ctx) {
    Matcher matcher = pattern.matcher(ctx.methodName().getText());
    if (matcher.find()) {
      BSLParser.CallParamContext param = ctx.doCall().callParamList().callParam().get(0);
      if (param.children == null ||
        param.getStart().getType() == BSLParser.STRING ||
        param.getStart().getType() == BSLParser.DECIMAL) {
        diagnosticStorage.addDiagnostic(ctx, info.getMessage(matcher.group(0)));
      }
    }
    return super.visitMethodCall(ctx);
  }

}




© 2015 - 2024 Weber Informatics LLC | Privacy Policy