resources.report.rules.pmd.ConfusingTernary.html Maven / Gradle / Ivy

Go to download

Show more of this group Show more artifacts with this name
Show all versions of sanity4j Show documentation

Sanity4J was created to simplify running multiple static code analysis tools on the Java projects. It provides a single entry point to run all the selected tools and produce a consolidated report, which presents all findings in an easily accessible manner.

There is a newer version: 1.1.1

Show newest version



ConfusingTernary


ConfusingTernary
In an "if" expression with an "else" clause, avoid negation in
the test.  For example, rephrase:
if (x != y) diff(); else same();
as:
if (x == y) same(); else diff();
Most "if (x != y)" cases without an "else" are often return
cases, so consistent use of this rule makes the code easier
to read.  Also, this resolves trivial ordering problems, such
as "does the error case go first?" or "does the common case
go first?".
        
		
		
		    
		    
    		    
    		    
    		    

    		    This rule is defined by the following Java class:
    		    net.sourceforge.pmd.rules.design.ConfusingTernary
    		    
		    
	    
	    
        
        
        Example:
            
                    
          
public class Foo {
 boolean bar(int x, int y) {
  return (x != y) ? diff : same;
 }
}