resources.report.rules.pmd.UseEqualsToCompareStrings.html Maven / Gradle / Ivy

Go to download

Show more of this group Show more artifacts with this name
Show all versions of sanity4j Show documentation

Sanity4J was created to simplify running multiple static code analysis tools on the Java projects. It provides a single entry point to run all the selected tools and produce a consolidated report, which presents all findings in an easily accessible manner.

The newest version!



UseEqualsToCompareStrings


UseEqualsToCompareStrings
Using '==' or '!=' to compare strings only works if intern version is used on both sides
    
		
		
		    
    			This rule is defined by the following XPath expression:
    			
    			
    
//EqualityExpression/PrimaryExpression
[(PrimaryPrefix/Literal
   [starts-with(@Image, '"')]
   [ends-with(@Image, '"')]
and count(PrimarySuffix) = 0)]

            
  
		    
		    
	    
	    
        
        
        Example:
            
                    

class Foo {
  boolean test(String s) {
    if (s == "one") return true; //Bad
    if ("two".equals(s)) return true; //Better
    return false;
  }
}