framework.src.org.checkerframework.common.aliasing.AliasingVisitor Maven / Gradle / Ivy
Show all versions of checker Show documentation
package org.checkerframework.common.aliasing;
/*>>>
import org.checkerframework.checker.compilermsgs.qual.CompilerMessageKey;
*/
import org.checkerframework.common.aliasing.qual.LeakedToResult;
import org.checkerframework.common.aliasing.qual.NonLeaked;
import org.checkerframework.common.aliasing.qual.Unique;
import org.checkerframework.common.basetype.BaseTypeChecker;
import org.checkerframework.common.basetype.BaseTypeVisitor;
import org.checkerframework.dataflow.cfg.node.MethodInvocationNode;
import org.checkerframework.framework.source.Result;
import org.checkerframework.framework.type.AnnotatedTypeMirror;
import org.checkerframework.framework.type.AnnotatedTypeMirror.AnnotatedArrayType;
import org.checkerframework.framework.type.AnnotatedTypeMirror.AnnotatedDeclaredType;
import org.checkerframework.framework.type.AnnotatedTypeMirror.AnnotatedExecutableType;
import org.checkerframework.javacutil.TreeUtils;
import java.util.List;
import javax.lang.model.element.ExecutableElement;
import javax.lang.model.element.VariableElement;
import com.sun.source.tree.ExpressionTree;
import com.sun.source.tree.MethodInvocationTree;
import com.sun.source.tree.MethodTree;
import com.sun.source.tree.NewArrayTree;
import com.sun.source.tree.ThrowTree;
import com.sun.source.tree.Tree;
import com.sun.source.tree.Tree.Kind;
import com.sun.source.tree.VariableTree;
/**
* This visitor ensures that every constructor whose result is annotated as
* {@literal @}Unique does not leak aliases.
*
*
* TODO: Implement {@literal @}NonLeaked and {@literal @}LeakedToResult verifications:
*
* {@literal @}NonLeaked: When a method declaration has a parameter annotated as
* {@literal @}NonLeaked, the method body must not leak a reference to that parameter.
*
*
* {@literal @}LeakedToResult: When a method declaration has a parameter annotated as
* {@literal @}LeakedToResult, the method body must not leak a reference to that parameter,
* except at the method return statements.
*
*
* Both of the checks above are similar to the @Unique check that is
* implemented in this visitor.
*/
public class AliasingVisitor extends
BaseTypeVisitor {
public AliasingVisitor(BaseTypeChecker checker) {
super(checker);
}
/**
* Checks that if a method call is being invoked inside a constructor with
* result type {@literal @}Unique, it must not leak the "this" reference.
* There are 3 ways to make sure that this is not happening:
*
* 1. "this" is not an argument of the method call.
*
* 2. "this" is an argument of the method call, but the respective parameter
* is annotated as {@literal @}NonLeaked.
*
* 3. "this" is an argument of the method call, but the respective parameter
* is annotated as {@literal @}LeakedToResult AND the result of the method
* call is not being stored (the method call is a statement).
*
* The private method isUniqueCheck handles cases 2 and 3.
*/
@Override
public Void visitMethodInvocation(MethodInvocationTree node, Void p) {
// The check only needs to be done for constructors with result type
// @Unique. We also want to avoid visiting the method.
if (isInUniqueConstructor(node)) {
if (TreeUtils.isSuperCall(node)) {
// Check if a call to super() might create an alias: that
// happens when the parent's respective constructor is not @Unique.
AnnotatedTypeMirror superResult = atypeFactory.
getAnnotatedType(node);
if (!superResult.hasAnnotation(Unique.class)) {
checker.report(Result.failure("unique.leaked"), node);
}
} else {
// TODO: Currently the type of "this" doesn't always return
// the type of the constructor result, therefore we need
// this "else" block. Once constructors are implemented
// correctly we could remove that code below, since the type
// of "this" in a @Unique constructor will be @Unique.
MethodInvocationNode n = (MethodInvocationNode) atypeFactory.
getNodeForTree(node);
Tree parent = n.getTreePath().getParentPath().getLeaf();
boolean parentIsStatement = parent.getKind() == Kind.
EXPRESSION_STATEMENT;
ExecutableElement methodElement = TreeUtils.elementFromUse(node);
List params = methodElement.
getParameters();
List args = node.getArguments();
assert (args.size() == params.size()) : "Number of arguments in"
+ " the method call " + n.toString() + " is different from the "
+ "number of parameters for the method declaration: "
+ methodElement.getSimpleName().toString();
for (int i = 0; i < args.size(); i++) {
// Here we are traversing the arguments of the method call.
// For every argument we check if it is a reference to "this".
if (TreeUtils.isExplicitThisDereference(args.get(i))) {
// If it is a reference to "this", there is still hope that
// it is not being leaked (2. and 3. from the javadoc).
VariableElement param = params.get(i);
boolean hasNonLeaked = atypeFactory.getAnnotatedType(
param).
hasAnnotation(NonLeaked.class);
boolean hasLeakedToResult = atypeFactory.
getAnnotatedType(param).
hasAnnotation(LeakedToResult.class);
isUniqueCheck(node, parentIsStatement, hasNonLeaked,
hasLeakedToResult);
} else {
// Not possible to leak reference here (case 1. from the javadoc).
}
}
// Now, doing the same as above for the receiver parameter
AnnotatedExecutableType annotatedType = atypeFactory.
getAnnotatedType(methodElement);
AnnotatedDeclaredType receiverType = annotatedType.
getReceiverType();
if (receiverType != null) {
boolean hasNonLeaked = receiverType.hasAnnotation(
NonLeaked.class);
boolean hasLeakedToResult = receiverType.hasAnnotation(
LeakedToResult.class);
isUniqueCheck(node, parentIsStatement, hasNonLeaked,
hasLeakedToResult);
}
}
}
return super.visitMethodInvocation(node, p);
}
private void isUniqueCheck(MethodInvocationTree node, boolean parentIsStatement,
boolean hasNonLeaked, boolean hasLeakedToResult) {
if (hasNonLeaked || (hasLeakedToResult && parentIsStatement)) {
// Not leaked according to cases 2. and 3. from the javadoc of
// visitMethodInvocation.
} else {
// May be leaked, raise warning.
checker.report(Result.failure("unique.leaked"), node);
}
}
// TODO: Merge that code in
// commonAssignmentCheck(AnnotatedTypeMirror varType, ExpressionTree
// valueExp, String errorKey, boolean isLocalVariableAssignement), because
// the method below isn't called for pseudo-assignments, but the mentioned
// one is. The issue of copy-pasting the code from this method to the other
// one is that a declaration such as: List<@Unique Object> will raise a
// unique.leaked warning, as there is a pseudo-assignment from @Unique to a
// @MaybeAliased object, if the @Unique annotation is not in the stubfile.
// TODO: Change the documentation in BaseTypeVisitor to point out that
// this isn't called for pseudo-assignments.
@Override
protected void commonAssignmentCheck(Tree varTree, ExpressionTree valueExp,
/*@CompilerMessageKey*/ String errorKey) {
super.commonAssignmentCheck(varTree, valueExp, errorKey);
if (isInUniqueConstructor(valueExp) && TreeUtils.
isExplicitThisDereference(valueExp)) {
// If an assignment occurs inside a constructor with
// result type @Unique, it will invalidate the @Unique property
// by using the "this" reference.
checker.report(Result.failure("unique.leaked"), valueExp);
} else if (canBeLeaked(valueExp)) {
checker.report(Result.failure("unique.leaked"), valueExp);
}
}
@Override
protected void commonAssignmentCheck(AnnotatedTypeMirror varType,
AnnotatedTypeMirror valueType, Tree valueTree, /*@CompilerMessageKey*/ String errorKey) {
super.commonAssignmentCheck(varType, valueType, valueTree, errorKey);
// If we are visiting a pseudo-assignment, visitorLeafKind is either
// Kind.NEW_CLASS or Kind.METHOD_INVOCATION.
Kind visitorLeafKind = visitorState.getPath().getLeaf().getKind();
Kind parentKind = visitorState.getPath().getParentPath().getLeaf().
getKind();
if (visitorLeafKind == Kind.NEW_CLASS ||
visitorLeafKind == Kind.METHOD_INVOCATION) {
// Handling pseudo-assignments
if (canBeLeaked(valueTree)) {
if (!varType.hasAnnotation(NonLeaked.class) &&
!(varType.hasAnnotation(LeakedToResult.class) &&
parentKind == Kind.EXPRESSION_STATEMENT)) {
checker.report(Result.failure("unique.leaked"), valueTree);
}
}
}
}
@Override
public Void visitThrow(ThrowTree node, Void p) {
// throw is also an escape mechanism. If an expression of type
// @Unique is thrown, it is not @Unique anymore.
ExpressionTree exp = node.getExpression();
if (canBeLeaked(exp)) {
checker.report(Result.failure("unique.leaked"), exp);
}
return super.visitThrow(node, p);
}
@Override
public Void visitVariable(VariableTree node, Void p) {
// Component types are not allowed to have the @Unique annotation.
AnnotatedTypeMirror varType = atypeFactory.getAnnotatedType(node);
VariableElement elt = TreeUtils.elementFromDeclaration(node);
if (elt.getKind().isField() && varType.hasExplicitAnnotation(Unique.class)) {
checker.report(Result.failure("unique.location.forbidden"), node);
} else if (node.getType().getKind() == Kind.ARRAY_TYPE) {
AnnotatedArrayType arrayType = (AnnotatedArrayType) varType;
if (arrayType.getComponentType().hasAnnotation(Unique.class)) {
checker.report(Result.failure("unique.location.forbidden"),
node);
}
} else if (node.getType().getKind() == Kind.PARAMETERIZED_TYPE) {
AnnotatedDeclaredType declaredType = (AnnotatedDeclaredType) varType;
for (AnnotatedTypeMirror atm : declaredType.getTypeArguments()) {
if (atm.hasAnnotation(Unique.class)) {
checker.report(Result.failure("unique.location.forbidden"),
node);
}
}
}
return super.visitVariable(node, p);
}
@Override
public Void visitNewArray(NewArrayTree node, Void p) {
List initializers = node.getInitializers();
if (initializers != null && !initializers.isEmpty()) {
for (ExpressionTree exp : initializers) {
if (canBeLeaked(exp)) {
checker.report(Result.failure("unique.leaked"), exp);
}
}
}
return super.visitNewArray(node, p);
}
/**
* Returns true if {@code exp} has type {@code @Unique} and is not a
* method invocation nor a new class expression.
* @param exp the Tree to check
*/
private boolean canBeLeaked(Tree exp) {
AnnotatedTypeMirror type = atypeFactory.getAnnotatedType(exp);
boolean isMethodInvocation = exp.getKind() == Kind.METHOD_INVOCATION;
boolean isNewClass = exp.getKind() == Kind.NEW_CLASS;
return type.hasExplicitAnnotation(Unique.class) && !isMethodInvocation &&
!isNewClass;
}
private boolean isInUniqueConstructor(Tree tree) {
MethodTree enclosingMethod = TreeUtils
.enclosingMethod(getCurrentPath());
if (enclosingMethod == null) {
return false; // No enclosing method.
}
return TreeUtils.isConstructor(enclosingMethod)
&& atypeFactory.getAnnotatedType(enclosingMethod)
.getReturnType().hasAnnotation(Unique.class);
}
}