org.sonar.javascript.checks.CollapsibleIfStatementsCheck Maven / Gradle / Ivy
/*
* SonarQube JavaScript Plugin
* Copyright (C) 2011 SonarSource and Eriks Nukis
* [email protected]
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 3 of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
*/
package org.sonar.javascript.checks;
import com.sonar.sslr.api.AstNode;
import com.sonar.sslr.squid.checks.SquidCheck;
import org.sonar.check.BelongsToProfile;
import org.sonar.check.Priority;
import org.sonar.check.Rule;
import org.sonar.javascript.parser.EcmaScriptGrammar;
import org.sonar.sslr.parser.LexerlessGrammar;
@Rule(
key = "CollapsibleIfStatements",
priority = Priority.MAJOR)
@BelongsToProfile(title = CheckList.SONAR_WAY_PROFILE, priority = Priority.MAJOR)
public class CollapsibleIfStatementsCheck extends SquidCheck {
@Override
public void init() {
subscribeTo(EcmaScriptGrammar.IF_STATEMENT);
}
@Override
public void visitNode(AstNode node) {
if (isIfStatementWithoutElse(node)) {
AstNode innerStatement = node.getFirstChild(EcmaScriptGrammar.STATEMENT).getFirstChild();
if (isBlockAndContainsOnlyOneIfStatement(innerStatement) || isIfStatementWithoutElse(innerStatement)) {
getContext().createLineViolation(this, "Those two 'if' statements can be consolidated.", node);
}
}
}
private boolean isBlockAndContainsOnlyOneIfStatement(AstNode statement) {
if (!statement.is(EcmaScriptGrammar.BLOCK)) {
return false;
}
AstNode statementList = statement.getFirstChild(EcmaScriptGrammar.STATEMENT_LIST);
if (statementList == null || statementList.getNumberOfChildren() != 1 || statementList.getFirstChild().isNot(EcmaScriptGrammar.STATEMENT)) {
return false;
}
return isIfStatementWithoutElse(statementList.getFirstChild().getFirstChild());
}
private boolean isIfStatementWithoutElse(AstNode statement) {
if (statement.isNot(EcmaScriptGrammar.IF_STATEMENT) || statement.hasDirectChildren(EcmaScriptGrammar.ELSE_CLAUSE)) {
return false;
}
return true;
}
}