org.codenarc.rule.groovyism.ExplicitHashSetInstantiationRule.groovy Maven / Gradle / Ivy

Go to download

Show more of this group Show more artifacts with this name
Show all versions of CodeNarc Show documentation

The CodeNarc project provides a static analysis tool for Groovy code.

There is a newer version: 3.5.0-groovy-4.0

/*
 * Copyright 2011 the original author or authors.
 * 
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 * 
 *      http://www.apache.org/licenses/LICENSE-2.0
 * 
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package org.codenarc.rule.groovyism

import org.codenarc.rule.AbstractAstVisitorRule
import org.codenarc.rule.AstVisitor

/**
 * This rule checks for the explicit instantiation of a HashSet using the no-arg constructor.
 * In Groovy, it is best to write "new HashSet()" as "[] as Set", which creates the same object.
 *
 * @author Hamlet D'Arcy
 * @author Chris Mair
 */
class ExplicitHashSetInstantiationRule extends AbstractAstVisitorRule {
    String name = 'ExplicitHashSetInstantiation'
    int priority = 2

        @Override
        AstVisitor getAstVisitor() {
            new ExplicitTypeInstantiationAstVisitor('HashSet')  {
            @Override
            protected String createErrorMessage() {
                'HashSet objects are better instantiated using the form "[] as Set"'
            }
        }
        }
}