org.codenarc.rule.unnecessary.UnnecessaryInstanceOfCheckRule.groovy Maven / Gradle / Ivy

Go to download

Show more of this group Show more artifacts with this name
Show all versions of CodeNarc Show documentation

The CodeNarc project provides a static analysis tool for Groovy code.

There is a newer version: 3.5.0-groovy-4.0

/*
 * Copyright 2011 the original author or authors.
 * 
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 * 
 *      http://www.apache.org/licenses/LICENSE-2.0
 * 
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package org.codenarc.rule.unnecessary

import org.codehaus.groovy.ast.expr.BinaryExpression
import org.codehaus.groovy.ast.expr.NotExpression
import org.codenarc.rule.AbstractAstVisitor
import org.codenarc.rule.AbstractAstVisitorRule
import org.codenarc.util.AstUtil

/**
 * This rule finds instanceof checks that cannot possibly evaluate to true. For instance, checking that (!variable instanceof String) will never be true because the result of a not expression is always a boolean. 
 *
 * @author Hamlet D'Arcy
  */
class UnnecessaryInstanceOfCheckRule extends AbstractAstVisitorRule {
    String name = 'UnnecessaryInstanceOfCheck'
    int priority = 3
    Class astVisitorClass = UnnecessaryInstanceOfCheckAstVisitor
}

class UnnecessaryInstanceOfCheckAstVisitor extends AbstractAstVisitor {
    @Override
    void visitBinaryExpression(BinaryExpression expression) {

        if (isFirstVisit(expression)) {

            if (AstUtil.isBinaryExpressionType(expression, 'instanceof') && expression.leftExpression instanceof NotExpression) {
                if (expression.rightExpression.text == 'Boolean') {
                    addViolation(expression, "The result of '!($expression.leftExpression.text)' will always be a Boolean")
                } else {
                    addViolation(expression, "The result of '!($expression.leftExpression.text)' will never be a $expression.rightExpression.text")
                }
            }
            super.visitBinaryExpression(expression)
        }
    }
}