org.codenarc.rule.junit.JUnitAssertAlwaysSucceedsRule.groovy Maven / Gradle / Ivy

Go to download
/*
 * Copyright 2009 the original author or authors.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package org.codenarc.rule.junit

import org.codehaus.groovy.ast.expr.MethodCallExpression
import org.codenarc.rule.AbstractAstVisitorRule
import org.codenarc.rule.AbstractMethodCallExpressionVisitor

/**
 * Rule that checks for JUnit assert() method calls with constant arguments
 * such that the assertion always succeeds. This includes:
 * 
 *   assertTrue(true).
 *   assertTrue('abc').
 *   assertTrue(99).
 *   assertTrue([123]).
 *   assertTrue([a:123]).
 *   assertFalse(false).
 *   assertFalse(0).
 *   assertFalse('').
 *   assertFalse([]).
 *   assertFalse([:]).
 *   assertNull(null).
 * 
 * This rule sets the default value of applyToFilesMatching to only match source code file
 * paths ending in 'Test.groovy' or 'Tests.groovy'.
 *
 * @author Chris Mair
  */
class JUnitAssertAlwaysSucceedsRule extends AbstractAstVisitorRule {
    String name = 'JUnitAssertAlwaysSucceeds'
    int priority = 2
    Class astVisitorClass = JUnitAssertAlwaysSucceedsAstVisitor
    String applyToClassNames = DEFAULT_TEST_CLASS_NAMES
}

class JUnitAssertAlwaysSucceedsAstVisitor extends AbstractMethodCallExpressionVisitor {

    @Override
    void visitMethodCallExpression(MethodCallExpression methodCall) {
        def isMatch =
            JUnitUtil.isAssertCallWithLiteralValue(methodCall, 'assertTrue', true) ||
            JUnitUtil.isAssertCallWithLiteralValue(methodCall, 'assertFalse', false) ||
            JUnitUtil.isAssertCallWithConstantValue(methodCall, 'assertNull', null) ||
            JUnitUtil.isAssertCallWithNonNullConstantValue(methodCall, 'assertNotNull') ||
            JUnitUtil.isAssertCallWithLiteralValue(methodCall, 'assertNotNull', true) ||
            JUnitUtil.isAssertCallWithLiteralValue(methodCall, 'assertNotNull', false)
        if (isMatch) {
            addViolation(methodCall, "The assertion $methodCall.text will always pass and is therefore pointless")
        }
    }
}