org.codenarc.rule.unnecessary.UnnecessaryCollectionCallRule.groovy Maven / Gradle / Ivy

Go to download

Show more of this group Show more artifacts with this name
Show all versions of CodeNarc Show documentation

The CodeNarc project provides a static analysis tool for Groovy code.

There is a newer version: 3.5.0-groovy-4.0

/*
 * Copyright 2009 the original author or authors.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package org.codenarc.rule.unnecessary

import org.codehaus.groovy.ast.expr.MethodCallExpression
import org.codehaus.groovy.ast.expr.TupleExpression
import org.codenarc.rule.AbstractAstVisitorRule
import org.codenarc.rule.AbstractMethodCallExpressionVisitor

/**
 * Useless call to collections. This call doesn't make sense. For any collection c, calling c.containsAll(c) should
 * always be true, and c.retainAll(c) should have no effect.
 *
 * @author Hamlet D'Arcy
  */
class UnnecessaryCollectionCallRule extends AbstractAstVisitorRule {
    String name = 'UnnecessaryCollectionCall'
    int priority = 3
    Class astVisitorClass = UnnecessaryCollectionCallAstVisitor
}

class UnnecessaryCollectionCallAstVisitor extends AbstractMethodCallExpressionVisitor {

    private static final List USELESS_METHOD_NAMES = ['retainAll', 'containsAll']

    @Override
    void visitMethodCallExpression(MethodCallExpression call) {
        if (USELESS_METHOD_NAMES.contains(call.method.text)) {
            String variableName = call.objectExpression.text
            if (call.arguments instanceof TupleExpression && call.arguments.expressions.size() == 1) {
                def argName = call.arguments.expressions[0].text
                if (argName == variableName) {
                    addViolation call, "The call to $call.method.text has no effect"
                }
            }
        }
    }
}