org.openrewrite.java.cleanup.IndexOfShouldNotCompareGreaterThanZeroTest.kt Maven / Gradle / Ivy
/*
* Copyright 2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.openrewrite.java.cleanup
import org.junit.jupiter.api.Test
import org.openrewrite.Recipe
import org.openrewrite.java.JavaParser
import org.openrewrite.java.JavaRecipeTest
@Suppress("ConstantConditions", "StatementWithEmptyBody")
interface IndexOfShouldNotCompareGreaterThanZeroTest : JavaRecipeTest {
override val recipe: Recipe
get() = IndexOfShouldNotCompareGreaterThanZero()
@Test
fun indexOfOnList(jp: JavaParser) = assertChanged(
jp,
before = """
import java.util.List;
class Test {
static boolean hasIndex(List strList, String str) {
if (strList.indexOf(str) > 0) {
}
return strList.indexOf(str) > 0;
}
}
""",
after = """
import java.util.List;
class Test {
static boolean hasIndex(List strList, String str) {
if (strList.indexOf(str) >= 1) {
}
return strList.indexOf(str) >= 1;
}
}
"""
)
@Test
fun indexOfOnString(jp: JavaParser) = assertChanged(
jp,
before = """
class Test {
static boolean hasIndex(String str) {
if (str.indexOf("str") > 0) {
}
return str.indexOf("str") > 0;
}
}
""",
after = """
class Test {
static boolean hasIndex(String str) {
if (str.indexOf("str") >= 1) {
}
return str.indexOf("str") >= 1;
}
}
"""
)
@Test
fun doNotChangeGreaterThanOrEqualToZero(jp: JavaParser) = assertUnchanged(
jp,
before = """
import java.util.List;
class Test {
static void hasIndex(List strList, String str) {
if (strList.indexOf(str) >= 0) {
}
if (str.indexOf("str") >= 0) {
}
}
}
"""
)
}