org.sonar.plugins.csharp.S2198.html Maven / Gradle / Ivy

Go to download

Show more of this group Show more artifacts with this name
Show all versions of sonar-csharp-plugin Show documentation

Code Analyzer for C#

There is a newer version: 10.2.0.105762

Why is this an issue?
Certain mathematical comparisons
will always return the same value, and should not be performed.
Specifically, the following comparisons will return either always true or always false depending on the kind of
comparison:

   comparing a char with a numeric constant that is outside of the range of char 
   comparing a float with a numeric constant that is outside of the range of float 
   comparing a long with a numeric constant that is outside of the range of long 
   comparing a ulong with a numeric constant that is outside of the range of ulong 
   etc. 

Noncompliant code example
float f = 42.0f;
if (f <= double.MaxValue) { } // Noncompliant: always true
if (f > double.MaxValue) { }  // Noncompliant: always false

Resources
Documentation

   Microsoft Learn: Comparison
  operators (C# reference) 
   Microsoft Learn: Ranges for integral numeric types (C# reference) 
   Microsoft Learn: Range for char (C#
  reference)