org.sonar.plugins.csharp.S6507.html Maven / Gradle / Ivy

Go to download

Show more of this group Show more artifacts with this name
Show all versions of sonar-csharp-plugin Show documentation

Code Analyzer for C#

There is a newer version: 10.2.0.105762

Why is this an issue?
Locking on a local variable can undermine synchronization because two different threads running the same method in parallel will potentially lock
on different instances of the same object, allowing them to access the synchronized block at the same time.
Noncompliant code example
private void DoSomething()
{
  object local = new object();
  // Code potentially modifying the local variable ...

  lock (local) // Noncompliant
  {
    // ...
  }
}

Compliant solution
private readonly object lockObj = new object();

private void DoSomething()
{
  lock (lockObj)
  {
    //...
  }
}

Resources

   Lock Statement - lock statement - ensure
  exclusive access to a shared resource 
   CWE - CWE-412 - Unrestricted Externally Accessible Lock 
   CWE - CWE-413 - Improper Resource Locking