org.sonar.plugins.csharp.S1764.html Maven / Gradle / Ivy

Go to download

Show more of this group Show more artifacts with this name
Show all versions of sonar-csharp-plugin Show documentation

Code Analyzer for C#

There is a newer version: 10.2.0.105762

Why is this an issue?
Using the same value on both sides of certain operators is a code defect. In the case of logical operators, it is either a copy/paste error and,
therefore, a bug, or it is simply duplicated code and should be simplified. For bitwise operators and most binary mathematical operators, having the
same value on both sides of an operator yields predictable results and should be simplified as well to avoid further code defects.
This rule raises for the following operators.

   Equality operators
  (== and !=) 
   Comparison operators
  (< =, <, >, >=) 
   The following Logical
  Operators:
    
       Logical OR (| ) 
       Conditional logical OR (||) 
       Logical AND (&) 
       Conditional logical AND (&&) 
       Logical exclusive OR (^) 
    
  
   The following arithmetic
  operators:
    
       Subtraction (-) 
       Division (\) 
       Remainder operator (%) 
       Subtraction assignment operator (-=) 
       Divide assignment operator (\=) 
    
  

Exceptions
This rule ignores the following operators:

   Multiplication (*) 
   Addition (+) 
   Assignment (=) 
   Left-shift
  (<<) 
   Right-shift
  (>>) 

Code examples
Noncompliant code example
if ( a == a ) // always true
{
  doZ();
}
if ( a != a ) // always false
{
  doY();
}
if ( a == b && a == b ) // if the first one is true, the second one is too
{
  doX();
}
if ( a == b || a == b ) // if the first one is true, the second one is too
{
  doW();
}

int j = 5 / 5; // always 1
int k = 5 - 5; // always 0

c.Equals(c);    // always true
Object.Equals(c, c); // always true

Resources
Documentation

   Arithmetic Operators 
   Boolean logical operators
  
   Bitwise and shift
  operators 
   Equality operators - test if two
  objects are equal or not 
   Comparison operators 
   Assignment operators