• Home
• org.sonarsource.dotnet
• sonar-csharp-plugin
• 9.32.0.97167
• source code
• S2197.html

×

Project download

Many resources are needed to download a project. Please understand that we have to compensate our server costs. Thank you in advance.
Project price only 1 $

You can buy this project and download/modify it how often you want.

org.sonar.plugins.csharp.S2197.html Maven / Gradle / Ivy

Why is this an issue?
When the modulus of a negative number is calculated, the result will either be negative or zero. Thus, comparing the modulus of a variable for
equality with a positive number (or a negative one) could result in unexpected results.
Noncompliant code example
public bool IsOdd(int x)
{
  return x % 2 == 1;  // Noncompliant; if x is an odd negative, x % 2 == -1
}

Compliant solution
public bool IsOdd(int x)
{
  return x % 2 != 0;
}

or
public bool IsOdd(uint x)
{
  return x % 2 == 1;
}