org.sonar.java.checks.MissingDeprecatedCheck Maven / Gradle / Ivy
/*
* SonarQube Java
* Copyright (C) 2012-2016 SonarSource SA
* mailto:contact AT sonarsource DOT com
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 3 of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/
package org.sonar.java.checks;
import org.sonar.api.server.rule.RulesDefinition;
import org.sonar.check.Priority;
import org.sonar.check.Rule;
import org.sonar.java.ast.visitors.PublicApiChecker;
import org.sonar.java.tag.Tag;
import org.sonar.plugins.java.api.tree.Tree;
import org.sonar.plugins.java.api.tree.Tree.Kind;
import org.sonar.squidbridge.annotations.ActivatedByDefault;
import org.sonar.squidbridge.annotations.SqaleConstantRemediation;
import org.sonar.squidbridge.annotations.SqaleSubCharacteristic;
import java.util.Deque;
import java.util.LinkedList;
@Rule(
key = "MissingDeprecatedCheck",
name = "Deprecated elements should have both the annotation and the Javadoc tag",
priority = Priority.MAJOR,
tags = {Tag.BAD_PRACTICE, Tag.OBSOLETE})
@ActivatedByDefault
@SqaleSubCharacteristic(RulesDefinition.SubCharacteristics.UNDERSTANDABILITY)
@SqaleConstantRemediation("5min")
public class MissingDeprecatedCheck extends AbstractDeprecatedChecker {
private static final Kind[] CLASS_KINDS = PublicApiChecker.classKinds();
private static final Kind[] METHOD_KINDS = PublicApiChecker.methodKinds();
private final Deque currentParent = new LinkedList<>();
private final Deque classOrInterfaceIsDeprecated = new LinkedList<>();
@Override
public void visitNode(Tree tree) {
boolean isLocalVar = false;
if (tree.is(Tree.Kind.VARIABLE)) {
isLocalVar = currentParent.peek().is(METHOD_KINDS);
} else {
currentParent.push(tree);
}
boolean hasDeprecatedAnnotation = hasDeprecatedAnnotation(tree);
boolean hasJavadocDeprecatedTag = hasJavadocDeprecatedTag(tree);
if (currentClassNotDeprecated() && !isLocalVar) {
if (hasDeprecatedAnnotation && !hasJavadocDeprecatedTag) {
reportIssue(getReportTree(tree), "Add the missing @deprecated Javadoc tag.");
} else if (hasJavadocDeprecatedTag && !hasDeprecatedAnnotation) {
reportIssue(getReportTree(tree), "Add the missing @Deprecated annotation.");
}
}
if (tree.is(CLASS_KINDS)) {
classOrInterfaceIsDeprecated.push(hasDeprecatedAnnotation || hasJavadocDeprecatedTag);
}
}
private boolean currentClassNotDeprecated() {
return classOrInterfaceIsDeprecated.isEmpty() || !classOrInterfaceIsDeprecated.peek();
}
@Override
public void leaveNode(Tree tree) {
if (!tree.is(Tree.Kind.VARIABLE)) {
currentParent.pop();
}
if (tree.is(CLASS_KINDS)) {
classOrInterfaceIsDeprecated.pop();
}
}
}
© 2015 - 2025 Weber Informatics LLC | Privacy Policy