org.sonar.l10n.java.rules.squid.S1132.html Maven / Gradle / Ivy

Go to download

Show more of this group Show more artifacts with this name
Show all versions of java-checks Show documentation

There is a newer version: 8.6.0.37351


It is preferable to place string literals on the left-hand side of an equals() or equalsIgnoreCase() method call.
This prevents null pointer exceptions from being raised, as a string literal can never be null by definition.


The following code:

String myString = null;

System.out.println("Equal? " + myString.equals("foo"));                        // Noncompliant - will raise a NPE
System.out.println("Equal? " + (myString != null && myString.equals("foo")));  // Noncompliant - null check could be removed


should be refactored into:

System.out.println("Equal?" + "foo".equals(myString));                         // Compliant - properly deals with the null case