org.sonar.l10n.java.rules.squid.S1697.html Maven / Gradle / Ivy

Go to download

Show more of this group Show more artifacts with this name
Show all versions of java-checks Show documentation

There is a newer version: 8.9.0.37768


  When either the equality operator in a null test or the logical operator that follows it is reversed,
  the code has the appearance of safely null-testing the object before dereferencing it.
  Unfortunately the effect is just the opposite - the object is null-tested and then dereferenced
  only if it is null, leading to a guaranteed null pointer dereference.


Noncompliant Code Example
if (str == null && str.length() == 0) {
  System.out.println("String is empty");
}

if (str != null || str.length() > 0) {
  System.out.println("String is not empty");
}


Compliant Solution
if (str == null || str.length() == 0) {
  System.out.println("String is empty");
}

if (str != null && str.length() > 0) {
  System.out.println("String is not empty");
}