org.sonar.l10n.java.rules.squid.S1151.html Maven / Gradle / Ivy

Go to download

  The switch statement should be used only to clearly define some new branches in the control flow.
  As soon as a case clause contains too many statements this highly decreases the readability
  of the overall control flow statement. In such case, the content of case clause should
  be extracted in a dedicated method.


Noncompliant Code Example
With the default threshold of 5:
switch (myVariable) {
  case 0: // 6 lines till next case
    methodCall1("");
    methodCall2("");
    methodCall3("");
    methodCall4("");
    break;
  case 1:
  ...
}
 

Compliant Solution
switch (myVariable) {
  case 0:                  
    doSomething()
    break;
  case 1:
  ...
}
...
private void doSomething(){
    methodCall1("");
    methodCall2("");
    methodCall3("");
    methodCall4("");
}