org.sonar.l10n.java.rules.squid.S1165.html Maven / Gradle / Ivy

Go to download

Show more of this group Show more artifacts with this name
Show all versions of java-checks Show documentation

There is a newer version: 8.6.0.37351

Exceptions are meant to represent the application's state at which an error occurred.
Making all fields final ensures that this state:

 Will be fully defined at the same time the exception is instantiated.
 Won't be updated or corrupted by some bogus error handler.

This will enable developers to quickly understand what went wrong.
The following code:
public class MyException extends Exception {

  private int status;                               // Noncompliant

  public MyException(String message) {
    super(message);
  }

  public int getStatus() {
    return status;
  }

  public void setStatus(int status) {
    this.status = status;
  }

}

should be refactored into:
public class MyException extends Exception {

  private final int status;                         // Compliant

  public MyException(String message, int status) {
    super(message);
    this.status = status;
  }

  public int getStatus() {
    return status;
  }

}