org.sonar.java.checks.CatchNPECheck Maven / Gradle / Ivy
/*
* SonarQube Java
* Copyright (C) 2012-2018 SonarSource SA
* mailto:info AT sonarsource DOT com
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 3 of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/
package org.sonar.java.checks;
import org.sonar.check.Rule;
import org.sonar.plugins.java.api.JavaFileScanner;
import org.sonar.plugins.java.api.JavaFileScannerContext;
import org.sonar.plugins.java.api.tree.BaseTreeVisitor;
import org.sonar.plugins.java.api.tree.CatchTree;
import org.sonar.plugins.java.api.tree.ExpressionTree;
import org.sonar.plugins.java.api.tree.IdentifierTree;
import org.sonar.plugins.java.api.tree.MemberSelectExpressionTree;
import org.sonar.plugins.java.api.tree.Tree;
import org.sonar.plugins.java.api.tree.Tree.Kind;
import org.sonar.plugins.java.api.tree.UnionTypeTree;
@Rule(key = "S1696")
public class CatchNPECheck extends BaseTreeVisitor implements JavaFileScanner {
private JavaFileScannerContext context;
@Override
public void scanFile(JavaFileScannerContext context) {
this.context = context;
scan(context.getTree());
}
@Override
public void visitCatch(CatchTree tree) {
super.visitCatch(tree);
Tree typeTree = tree.parameter().type();
if (typeTree.is(Kind.UNION_TYPE)) {
((UnionTypeTree) typeTree).typeAlternatives().forEach(this::checkType);
} else {
checkType(typeTree);
}
}
private void checkType(Tree tree) {
if (tree.is(Kind.IDENTIFIER)) {
IdentifierTree identifier = (IdentifierTree) tree;
if (isNPE(identifier.name())) {
addIssue(identifier);
}
} else if (tree.is(Kind.MEMBER_SELECT)) {
MemberSelectExpressionTree memberSelectTree = (MemberSelectExpressionTree) tree;
if (isNPE(memberSelectTree.identifier().name())) {
checkJavaLangNPE(memberSelectTree);
}
}
}
private void checkJavaLangNPE(MemberSelectExpressionTree memberSelectTree) {
ExpressionTree expression = memberSelectTree.expression();
if (expression.is(Kind.MEMBER_SELECT)) {
MemberSelectExpressionTree mse = (MemberSelectExpressionTree) expression;
if ("lang".equals(mse.identifier().name()) && mse.expression().is(Kind.IDENTIFIER) && "java".equals(((IdentifierTree) mse.expression()).name())) {
addIssue(memberSelectTree.identifier());
}
}
}
private static boolean isNPE(String name) {
return "NullPointerException".equals(name);
}
private void addIssue(IdentifierTree tree) {
context.reportIssue(this, tree, "Avoid catching NullPointerException.");
}
}
© 2015 - 2025 Weber Informatics LLC | Privacy Policy