• Home
• org.sonarsource.java
• sonar-java-plugin
• 8.8.0.37665
• source code
• S5329.html

×

Project download

Many resources are needed to download a project. Please understand that we have to compensate our server costs. Thank you in advance.
Project price only 1 $

You can buy this project and download/modify it how often you want.

org.sonar.l10n.java.rules.java.S5329.html Maven / Gradle / Ivy

Why is this an issue?
It is very common to pass a collection constructor reference as an argument, for example Collectors.toCollection(ArrayList::new) takes
the ArrayList::new constructor. When the method expects a java.util.function.Supplier it is perfectly fine. However when the
method argument type is java.util.function.Function it means that an argument will be passed to the constructor.
The first argument of Collections constructors is usually an integer representing its "initial capacity". This is generally not what the developer
expects, but the memory allocation is not visible at first glance.
This rule raises an issue when a collection constructor is passed by reference as a java.util.function.Function argument.
Noncompliant code example
Arrays.asList(1, 2, 54000).stream().collect(Collectors.toMap(Function.identity(), ArrayList::new)); // Noncompliant, "ArrayList::new" unintentionally refers to "ArrayList(int initialCapacity)" instead of "ArrayList()"

Compliant solution
Arrays.asList(1, 2, 54000).stream().collect(Collectors.toMap(Function.identity(), id -> new ArrayList<>())); // Compliant, explicitly show the usage of "id -> new ArrayList<>()" or "id -> new ArrayList<>(id)"