org.sonar.l10n.py.rules.python.S3699.html Maven / Gradle / Ivy

Go to download

Show more of this group Show more artifacts with this name
Show all versions of python-checks Show documentation

There is a newer version: 4.23.0.17664

This rule raises an issue when a function call result is used, even though the function does not return anything.
Why is this an issue?
If a function does not return anything, it makes no sense to use its output. Specifically, passing it to another function, or assigning its
"result" to a variable is probably a bug because such functions return nothing, which is probably not what was intended.
Code examples
Noncompliant code example
def foo():
  l = [1, 2, 3]
  result = l.append(42) # Noncompliant, `append` mutates list l
  return result

Compliant solution
def foo():
  l = [1, 2, 3]
  l.append(42)
  return l

Resources
Documentation

   Python documentation - Defining Functions