org.sonar.l10n.py.rules.python.S5915.html Maven / Gradle / Ivy

Go to download

Show more of this group Show more artifacts with this name
Show all versions of python-checks Show documentation

There is a newer version: 4.23.0.17664

Why is this an issue?
Using pytest.raises or unittest.TestCase.assertRaises will assert that an exception is raised in the following block.
Ending such block in an assertion means that the test can succeed with that last assertion never being executed.
Noncompliant code example
import pytest
def foo(): return 1 / 0
def bar(): return 42
def test_something():
  with pytest.raises(ZeroDivisionError):
    foo()
    assert bar() == 42  # Noncompliant

Compliant solution
import pytest
def foo(): return 1 / 0
def bar(): return 42
def test_something():
  with pytest.raises(ZeroDivisionError):
    foo()
  assert bar() == 42

Resources

   Unittest: assertRaises 
   Pytest: assertions about expected exceptions