org.sonar.l10n.py.rules.python.S6265.html Maven / Gradle / Ivy
Predefined permissions, also known as canned ACLs,
are an easy way to grant large privileges to predefined groups or users.
The following canned ACLs are security-sensitive:
-
PUBLIC_READ, PUBLIC_READ_WRITE grant respectively "read" and "read and write" privileges to everyone in the world
(AllUsers group).
-
AUTHENTICATED_READ grants "read" privilege to all authenticated users (AuthenticatedUsers group).
Ask Yourself Whether
- The S3 bucket stores sensitive data.
- The S3 bucket is not used to store static resources of websites (images, css …).
There is a risk if you answered yes to any of those questions.
Recommended Secure Coding Practices
It’s recommended to implement the least privilege policy, i.e., to grant necessary permissions only to users for their required tasks. In the
context of canned ACL, set it to PRIVATE (the default one), and if needed more granularity then use an appropriate S3 policy.
Sensitive Code Example
All users (ie: anyone in the world authenticated or not) have read and write permissions with the PUBLIC_READ_WRITE access
control:
bucket = s3.Bucket(self, "bucket",
access_control=s3.BucketAccessControl.PUBLIC_READ_WRITE # Sensitive
)
s3deploy.BucketDeployment(self, "DeployWebsite",
access_control=s3.BucketAccessControl.PUBLIC_READ_WRITE # Sensitive
)
Compliant Solution
With the PRIVATE access control (default), only the bucket owner has the read/write permissions on the buckets and its ACL.
bucket = s3.Bucket(self, "bucket",
access_control=s3.BucketAccessControl.PRIVATE # Compliant
)
# Another example
s3deploy.BucketDeployment(self, "DeployWebsite",
access_control=s3.BucketAccessControl.PRIVATE # Compliant
)
See
- AWS Documentation - Access control list (ACL)
overview (canned ACLs)
- AWS Documentation - Controlling access to a bucket with
user policies
- CWE - CWE-732 - Incorrect Permission Assignment for Critical Resource
- CWE - CWE-284 - Improper Access Control
- AWS CDK version 2 - Class Bucket (construct)