org.sonar.plugins.csharp.S1656.html Maven / Gradle / Ivy

Go to download

Show more of this group Show more artifacts with this name
Show all versions of sonarlint-omnisharp-plugin Show documentation

Code Analyzer based on Omnisharp

There is a newer version: 1.26.0.100277

Show newest version

Why is this an issue?
Re-assigning a variable to itself is a defect as it has no actual effect and indicates meaning to do something else. It usually means that:

   The statement is redundant and should be removed 
   The re-assignment is a mistake, and another value or variable was intended for the assignment instead 

Code examples
Noncompliant code example
public class Choice {
    private bool selected;

    public void MakeChoice(bool selected)
    {
        selected = selected; // Noncompliant
    }
}

Compliant solution
public class Choice {
    private bool selected;

    public void MakeChoice(bool selected)
    {
        this.selected = selected; // Compliant
    }
}

Resources
Documentation

   Microsoft Learn - Compiler Warning (level 3) CS1717