org.sonar.plugins.csharp.S3267.html Maven / Gradle / Ivy

Go to download

Show more of this group Show more artifacts with this name
Show all versions of sonarlint-omnisharp-plugin Show documentation

Code Analyzer based on Omnisharp

There is a newer version: 1.26.0.100277

Show newest version

Why is this an issue?
When a loop is filtering, selecting or aggregating, those functions can be handled with a clearer, more concise LINQ expression instead.
Noncompliant code example
var result = new List<string>();
foreach (var element in collection)  // Noncompliant
{
  if (condition(element))
  {
    result.Add(element);
  }
}

foreach (var element in collection2) // Noncompliant
{
  var someValue = element.Property;
  if (someValue != null)
  {
    result.Add(someValue);
  }
}

Compliant solution
var result = new List<string>();

foreach (var element in collection.Where(x => condition(x)))
{
  result.Add(element);
}

foreach (var someValue in collection2.Select(x => x.Property).Where(y => y != null))
{
  result.Add(someValue);
}