org.sonar.plugins.csharp.S3973.html Maven / Gradle / Ivy

Go to download

Show more of this group Show more artifacts with this name
Show all versions of sonarlint-omnisharp-plugin Show documentation

Code Analyzer based on Omnisharp

There is a newer version: 1.26.0.100277

Show newest version

Why is this an issue?
When the line immediately after conditional statements has neither curly braces nor indentation, the intent of the code is unclear and perhaps not
executed as expected. Additionally, such code is confusing to maintainers.
The rule will check the line indentation after the following conditional statements:

   if and if-else
  statements 
   for
  statement 
   foreach
  statement 
   do statement
  
   while
  statement 

if (condition)  // Noncompliant
DoTheThing();
DoTheOtherThing(); // Was the intent to call this function unconditionally?

It becomes even more confusing and bug-prone if lines get commented out.
if (condition)  // Noncompliant
//   DoTheThing();
DoTheOtherThing(); // Was the intent to call this function conditionally?

Indentation alone or together with curly braces makes the intent clear.
if (condition)
  DoTheThing();
DoTheOtherThing(); // Clear intent to call this function unconditionally

// or

if (condition)
{
  DoTheThing();
}
DoTheOtherThing(); // Clear intent to call this function unconditionally