org.jboss.as.domain.management.access.RbacSanityCheckOperation Maven / Gradle / Ivy
/*
* JBoss, Home of Professional Open Source.
* Copyright 2013, Red Hat, Inc., and individual contributors
* as indicated by the @author tags. See the copyright.txt file in the
* distribution for a full listing of individual contributors.
*
* This is free software; you can redistribute it and/or modify it
* under the terms of the GNU Lesser General Public License as
* published by the Free Software Foundation; either version 2.1 of
* the License, or (at your option) any later version.
*
* This software is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this software; if not, write to the Free
* Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
* 02110-1301 USA, or see the FSF site: http://www.fsf.org.
*/
package org.jboss.as.domain.management.access;
import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.ACCESS;
import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.AUTHORIZATION;
import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.INCLUDE;
import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.MANAGEMENT_INTERFACE;
import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.NATIVE_REMOTING_INTERFACE;
import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.ROLE_MAPPING;
import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.SECURITY_REALM;
import static org.jboss.as.domain.management.DomainManagementMessages.MESSAGES;
import java.security.AccessController;
import java.security.PrivilegedActionException;
import java.security.PrivilegedExceptionAction;
import java.util.ArrayList;
import java.util.HashSet;
import java.util.List;
import java.util.Locale;
import java.util.Set;
import org.jboss.as.controller.OperationContext;
import org.jboss.as.controller.OperationContext.AttachmentKey;
import org.jboss.as.controller.OperationContext.Stage;
import org.jboss.as.controller.OperationFailedException;
import org.jboss.as.controller.OperationStepHandler;
import org.jboss.as.controller.PathAddress;
import org.jboss.as.controller.PathElement;
import org.jboss.as.controller.operations.common.Util;
import org.jboss.as.controller.registry.Resource;
import org.jboss.as.controller.registry.Resource.ResourceEntry;
import org.jboss.as.domain.management.CoreManagementResourceDefinition;
import org.jboss.as.domain.management.access.AccessAuthorizationResourceDefinition.Provider;
import org.jboss.as.domain.management.security.SecurityRealmResourceDefinition;
import org.jboss.dmr.ModelNode;
import org.jboss.dmr.Property;
/**
* An {@link OperationStepHandler} to be executed at the end of stage MODEL to identify SOME situations where configuration
* would lock out all remote access.
*
* Due to role mapping using information from remote stores it is not possible to exhaustively verify that users will still be
* assigned roles after a configuration change, however there are some configuration permutations where it is guaranteed no
* roles can be assigned regardless of the user stores and we can detect and reject those configurations.
*
* @author Darran Lofthouse
*/
public class RbacSanityCheckOperation implements OperationStepHandler {
private static final AttachmentKey KEY = AttachmentKey.create(RbacSanityCheckOperation.class);
private static final RbacSanityCheckOperation INSTANCE = new RbacSanityCheckOperation();
private RbacSanityCheckOperation() {
}
@Override
public void execute(final OperationContext context, final ModelNode operation) throws OperationFailedException {
/*
* This operation should complete successfully as soon as it is detected that there is potentially configuration that
* will allow operations to be executed by remote users, that could mean that RBAC is disabled or at least one config
* path is identified that potentially allows for role assignment.
*
* Checks to perform: - 1 - Provider if not RBAC no further checking required. 2 - If use-realm-roles is set, identify
* realms associated with mgmt interfaces and verify at least one maps groups to roles. 3 - Else iterate role
* definitions and verify at least one contains an include.
*
* Note: This operation if validating different parts of the model, although the user had access to modify one part they
* may not have access to the remaining parts - this Operation uses a PrivilegedAction to run as an in-vm client.
*/
try {
AccessController.doPrivileged(new PrivilegedExceptionAction() {
@Override
public Void run() throws OperationFailedException {
final ModelChecker checker = new ModelChecker(context, context.readResource(PathAddress.EMPTY_ADDRESS));
if (checker.isRbacEnabled() && (checker.canRealmRolesBeUsed() == false)
&& (checker.doRoleMappingsExist() == false)) {
throw MESSAGES.inconsistentRbacConfiguration();
}
context.stepCompleted();
return null;
}
});
} catch (PrivilegedActionException e) {
Exception cause = e.getException();
if (cause instanceof OperationFailedException) {
throw (OperationFailedException) cause;
} else {
throw new OperationFailedException(cause);
}
}
}
/**
* Register the operation at the end of Stage MODEL if this operation has not already been registered.
*
* This operation should be registered if any of the following occur: -
* - map-group-to-roles is set to false on an existing security realm.
* - A security realm is removed.
* - The authorization configuration is removed from a security realm.
* - The rbac provider is changed to rbac.
* - The attribute use-realm-roles is set to false.
* - A role is removed.
* - An include is removed from a role.
* - A management interface is removed.
*
* Note: This list only includes actions that could invalidate the configuration, actions that would not invalidate the
* configuration do not need this operation registering. e.g. Adding a role, if the configuration was already valid this
* could not invalidate it.
*
* @param context - The OperationContext to use to register the step.
*/
public static void registerOperation(final OperationContext context) {
RbacSanityCheckOperation registered = context.getAttachment(KEY);
if (registered == null) {
// TODO support managed domain
if (!context.isNormalServer()) return;
context.addStep(createOperation(), INSTANCE, Stage.MODEL);
context.attach(KEY, INSTANCE);
}
}
private static ModelNode createOperation() {
ModelNode operation = Util.createEmptyOperation("rbac-sanity-check", PathAddress.pathAddress(CoreManagementResourceDefinition.PATH_ELEMENT));
return operation;
}
/**
* A class to handle the checks on the management model.
*
* Performing all of the checks will require some paths through the model to be accessed multiple times, this class allows
* for those to be reused.
*/
private static class ModelChecker {
private final OperationContext context;
private final Resource managementResource;
private ModelNode accessAuthorization;
private ModelNode managementInterface;
private ModelNode securityRealm;
private ModelChecker(final OperationContext context, final Resource managementResource) {
this.context = context;
this.managementResource = managementResource;
}
boolean isRbacEnabled() throws OperationFailedException {
ModelNode accessAuthorization = getAccessAuthorization();
String value = AccessAuthorizationResourceDefinition.PROVIDER.resolveModelAttribute(context, accessAuthorization)
.asString().toUpperCase(Locale.ENGLISH);
return Provider.valueOf(value) == Provider.RBAC;
}
boolean canRealmRolesBeUsed() throws OperationFailedException {
ModelNode accessAuthorization = getAccessAuthorization();
if (AccessAuthorizationResourceDefinition.USE_REALM_ROLES.resolveModelAttribute(context, accessAuthorization)
.asBoolean()) {
return canRealmsProvideRoles();
}
return false;
}
boolean doRoleMappingsExist() throws OperationFailedException {
Resource authorizationResource = managementResource.getChild(PathElement.pathElement(ACCESS, AUTHORIZATION));
Set roleNames = authorizationResource.getChildrenNames(ROLE_MAPPING);
for (String current : roleNames) {
Resource roleResource = authorizationResource.getChild(PathElement.pathElement(ROLE_MAPPING, current));
if (roleResource.getChildren(INCLUDE).size() > 0) {
return true;
}
}
return false;
}
private boolean canRealmsProvideRoles() throws OperationFailedException {
String[] possibleRealms = getRealmsInUse();
for (String current : possibleRealms) {
if (realmProvidesRoles(current)) {
return true;
}
}
return false;
}
private boolean realmProvidesRoles(final String realmName) throws OperationFailedException {
ModelNode realm = getSecurityRealm(realmName);
if (realm.isDefined()) {
if (SecurityRealmResourceDefinition.MAP_GROUPS_TO_ROLES.resolveModelAttribute(context, realm).asBoolean()) {
Resource realmResource = managementResource.getChild(PathElement.pathElement(SECURITY_REALM, realmName));
return realmResource.hasChild(PathElement.pathElement(AUTHORIZATION));
}
}
return false;
}
private ModelNode getSecurityRealm(final String realmName) {
ModelNode securityRealm = getSecurityRealm();
if (securityRealm.isDefined()) {
for (Property current : securityRealm.asPropertyList()) {
if (current.getName().equals(realmName)) {
return current.getValue();
}
}
}
return new ModelNode();
}
private String[] getRealmsInUse() throws OperationFailedException {
HashSet realms = new HashSet();
ModelNode managementInterface = getManagementInterface();
if (managementInterface.isDefined()) {
List interfaces = managementInterface.asPropertyList();
for (Property current : interfaces) {
if (current.getName().equals(NATIVE_REMOTING_INTERFACE)) {
/*
* As the native remoting interface is in use we can not narrow down the security realms used so just return them all.
*/
return getAllRealmNames();
}
ModelNode value = current.getValue();
if (value.hasDefined(SECURITY_REALM)) {
realms.add(value.require(SECURITY_REALM).asString());
}
}
}
return realms.toArray(new String[realms.size()]);
}
private String[] getAllRealmNames() throws OperationFailedException {
ArrayList realms = new ArrayList();
ModelNode securityRealm = getSecurityRealm();
if (securityRealm.isDefined()) {
for (Property current : securityRealm.asPropertyList()) {
realms.add(current.getName());
}
}
return realms.toArray(new String[realms.size()]);
}
private ModelNode getAccessAuthorization() {
if (accessAuthorization == null) {
PathElement pathElement = PathElement.pathElement(ACCESS, AUTHORIZATION);
if (managementResource.hasChild(pathElement)) {
Resource authorizationResource = managementResource.getChild(pathElement);
if (authorizationResource.isModelDefined()) {
accessAuthorization = authorizationResource.getModel();
}
}
}
return accessAuthorization;
}
private ModelNode getManagementInterface() {
if (managementInterface == null) {
ModelNode managementInterface = new ModelNode();
Set children = managementResource.getChildren(MANAGEMENT_INTERFACE);
for (ResourceEntry current : children) {
managementInterface.add(new Property(current.getName(), current.getModel()));
}
this.managementInterface = managementInterface;
}
return managementInterface;
}
private ModelNode getSecurityRealm() {
if (securityRealm == null) {
ModelNode securityRealm = new ModelNode();
Set children = managementResource.getChildren(SECURITY_REALM);
for (ResourceEntry current : children) {
securityRealm.add(new Property(current.getName(), current.getModel()));
}
this.securityRealm = securityRealm;
}
return securityRealm;
}
}
}
© 2015 - 2025 Weber Informatics LLC | Privacy Policy